[wp-trac] [WordPress Trac] #4120: call to clean_url() hardcoded in sanitize_comment_cookies()

WordPress Trac wp-trac at lists.automattic.com
Tue Apr 10 08:10:31 GMT 2007


#4120: call to clean_url() hardcoded in sanitize_comment_cookies()
---------------------+------------------------------------------------------
 Reporter:  wnorris  |       Owner:  anonymous
     Type:  defect   |      Status:  new      
 Priority:  low      |   Milestone:  2.3      
Component:  General  |     Version:  2.2      
 Severity:  normal   |    Keywords:           
---------------------+------------------------------------------------------
 the method 'sanitize_comment_cookies' (wp-includes/comment.php) includes a
 hardcoded call to the method clean_url when working with the
 comment_author_url.  This is unnecessary because that is already handled
 as a filter on pre_comment_author_url.  Additionally, it makes it
 impossible (or rather very difficult) to NOT call clean_url.

 Example use case: I have an OpenID plugin in which a user may actually be
 putting an i-name in the URL field (something akin to "=will.norris").
 While this does have a URL form (http://xri.net/=will.norris), I need the
 raw form stored in the cookie.  As it is now, I would have to remove the
 sanitize_comment_cookies filter and re-implement it without the hardcoded
 function call.  If it were removed as I am proposing, this would be
 possible by simply removing the clean_url filter for
 pre_comment_author_url, but with no loss of functionality otherwise.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4120>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list