[wp-trac] Re: [WordPress Trac] #1435: Pages should be searched

WordPress Trac wp-trac at lists.automattic.com
Thu Oct 5 02:32:58 GMT 2006


#1435: Pages should be searched
----------------------------------------------+-----------------------------
 Reporter:  markjaquith                       |        Owner:  anonymous
     Type:  enhancement                       |       Status:  new      
 Priority:  normal                            |    Milestone:  2.2      
Component:  General                           |      Version:  1.5.1.1  
 Severity:  normal                            |   Resolution:           
 Keywords:  search pages static dev-feedback  |  
----------------------------------------------+-----------------------------
Changes (by markjaquith):

  * milestone:  2.1 => 2.2

Comment:

 I reported this and wrote that patch, but no, I don't agree that any
 implementation is better than no implementation.

 Sticking pages within the post results (interspersed) doesn't seem right.

 In fact, any good implementation is going to require theme changes, as
 right now all we can do is stick the pages into the loop.

 Two approaches I see:

 A switch to search posts or pages, defaulting to posts.  We could make a
 new template file: page-search.php, and the Default and Classic themes can
 show our ideal implementation of page search results.  Then it would be up
 to theme authors to create their own implementations.

 Unified searching, but using two WP_Query instances.  We could run the
 query made for posts again, searching for pages.  $page_search = new
 WP_Query('foo');  Then in search.php, we would have a second loop.  Maybe
 it could be up at the top, styled differently, only showing titles.
 Again, it would be up to theme authors to implement that.

 It's one of those things where everyone agrees that we should have it, but
 no one really knows the best way to do it... :-\

 2.2 milestone sounds better.  We're not even past the idea stage here.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/1435>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list