[wp-trac] Re: [WordPress Trac] #1194: dropdown_cats doesn't add the correct selected tag

WordPress Trac wp-trac at lists.automattic.com
Thu Aug 31 19:17:43 GMT 2006


#1194: dropdown_cats doesn't add the correct selected tag
---------------------+------------------------------------------------------
 Reporter:  crahan   |        Owner:  anonymous
     Type:  defect   |       Status:  reopened 
 Priority:  normal   |    Milestone:           
Component:  General  |      Version:  1.5      
 Severity:  minor    |   Resolution:           
 Keywords:           |  
---------------------+------------------------------------------------------
Changes (by markjaquith):

  * resolution:  fixed =>
  * status:  closed => reopened

Comment:

 I verified.  If you use it on a category page, it doesn't select the
 currently-viewed category.

 In the fix, definitely reverse the order of the checks.

 {{{
 if ( $selected && is_category($category->cat_ID) )
 }}}

 Don't want to do all those is_category() calls if we don't have to!

 I'll crank out a patch here in a minute.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/1194>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list