<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[61118] trunk: Plugins: Add missing `$priority` parameter to `has_filter()` and `has_action()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/61118">61118</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/61118","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-11-03 23:45:40 +0000 (Mon, 03 Nov 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugins: Add missing `$priority` parameter to `has_filter()` and `has_action()`.
This brings `has_filter()`/`has_action()` in parity with `add_filter()`/`add_action()` and `remove_filter()`/`remove_action()`, all of which support a `$priority` parameter.
Props westonruter, swissspidy.
Fixes <a href="https://core.trac.wordpress.org/ticket/64186">#64186</a>.
See <a href="https://core.trac.wordpress.org/ticket/64178">#64178</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswphookphp">trunk/src/wp-includes/class-wp-hook.php</a></li>
<li><a href="#trunksrcwpincludespluginphp">trunk/src/wp-includes/plugin.php</a></li>
<li><a href="#trunktestsphpunittestsactionsphp">trunk/tests/phpunit/tests/actions.php</a></li>
<li><a href="#trunktestsphpunittestsfiltersphp">trunk/tests/phpunit/tests/filters.php</a></li>
<li><a href="#trunktestsphpunittestshookshasFilterphp">trunk/tests/phpunit/tests/hooks/hasFilter.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswphookphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-hook.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-hook.php 2025-11-03 21:55:08 UTC (rev 61117)
+++ trunk/src/wp-includes/class-wp-hook.php 2025-11-03 23:45:40 UTC (rev 61118)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -223,16 +223,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * that evaluates to false (e.g. 0), so use the `===` operator for testing the return value.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.9.0 Added the `$priority` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $hook_name Optional. The name of the filter hook. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param callable|string|array|false $callback Optional. The callback to check for.
</span><span class="cx" style="display: block; padding: 0 10px"> * This method can be called unconditionally to speculatively check
</span><span class="cx" style="display: block; padding: 0 10px"> * a callback that may or may not exist. Default false.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|false $priority Optional. The specific priority at which to check for the callback.
+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return bool|int If `$callback` is omitted, returns boolean for whether the hook has
</span><span class="cx" style="display: block; padding: 0 10px"> * anything registered. When checking a specific function, the priority
</span><span class="cx" style="display: block; padding: 0 10px"> * of that hook is returned, or false if the function is not attached.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * If `$callback` and `$priority` are both provided, a boolean is returned
+ * for whether the specific function is registered at that priority.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function has_filter( $hook_name = '', $callback = false ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function has_filter( $hook_name = '', $callback = false, $priority = false ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( false === $callback ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->has_filters();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,9 +248,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $this->callbacks as $priority => $callbacks ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( is_int( $priority ) ) {
+ return isset( $this->callbacks[ $priority ][ $function_key ] );
+ }
+
+ foreach ( $this->callbacks as $callback_priority => $callbacks ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $callbacks[ $function_key ] ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $priority;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return $callback_priority;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludespluginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/plugin.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/plugin.php 2025-11-03 21:55:08 UTC (rev 61117)
+++ trunk/src/wp-includes/plugin.php 2025-11-03 23:45:40 UTC (rev 61118)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -267,6 +267,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * that evaluates to false (e.g. 0), so use the `===` operator for testing the return value.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.5.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.9.0 Added the `$priority` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global WP_Hook[] $wp_filter Stores all of the filters and actions.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -274,11 +275,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param callable|string|array|false $callback Optional. The callback to check for.
</span><span class="cx" style="display: block; padding: 0 10px"> * This function can be called unconditionally to speculatively check
</span><span class="cx" style="display: block; padding: 0 10px"> * a callback that may or may not exist. Default false.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|false $priority Optional. The specific priority at which to check for the callback.
+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return bool|int If `$callback` is omitted, returns boolean for whether the hook has
</span><span class="cx" style="display: block; padding: 0 10px"> * anything registered. When checking a specific function, the priority
</span><span class="cx" style="display: block; padding: 0 10px"> * of that hook is returned, or false if the function is not attached.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * If `$callback` and `$priority` are both provided, a boolean is returned
+ * for whether the specific function is registered at that priority.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function has_filter( $hook_name, $callback = false ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function has_filter( $hook_name, $callback = false, $priority = false ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wp_filter;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $wp_filter[ $hook_name ] ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -285,7 +290,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $wp_filter[ $hook_name ]->has_filter( $hook_name, $callback );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return $wp_filter[ $hook_name ]->has_filter( $hook_name, $callback, $priority );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -574,6 +579,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * that evaluates to false (e.g. 0), so use the `===` operator for testing the return value.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.5.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.9.0 Added the `$priority` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @see has_filter() This function is an alias of has_filter().
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -581,12 +587,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param callable|string|array|false $callback Optional. The callback to check for.
</span><span class="cx" style="display: block; padding: 0 10px"> * This function can be called unconditionally to speculatively check
</span><span class="cx" style="display: block; padding: 0 10px"> * a callback that may or may not exist. Default false.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|false $priority Optional. The specific priority at which to check for the callback.
+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return bool|int If `$callback` is omitted, returns boolean for whether the hook has
</span><span class="cx" style="display: block; padding: 0 10px"> * anything registered. When checking a specific function, the priority
</span><span class="cx" style="display: block; padding: 0 10px"> * of that hook is returned, or false if the function is not attached.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * If `$callback` and `$priority` are both provided, a boolean is returned
+ * for whether the specific function is registered at that priority.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function has_action( $hook_name, $callback = false ) {
- return has_filter( $hook_name, $callback );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function has_action( $hook_name, $callback = false, $priority = false ) {
+ return has_filter( $hook_name, $callback, $priority );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestsactionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/actions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/actions.php 2025-11-03 21:55:08 UTC (rev 61117)
+++ trunk/tests/phpunit/tests/actions.php 2025-11-03 23:45:40 UTC (rev 61118)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,20 +64,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $hook_name = __FUNCTION__;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( $hook_name, array( &$a, 'action' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( $hook_name, array( &$a, 'action' ), 100 );
</ins><span class="cx" style="display: block; padding: 0 10px"> do_action( $hook_name );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Make sure our hook was called correctly.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 1, $a->get_call_count() );
- $this->assertSame( array( $hook_name ), $a->get_hook_names() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 2, $a->get_call_count() );
+ $this->assertSame( array( $hook_name, $hook_name ), $a->get_hook_names() );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Now remove the action, do it again, and make sure it's not called this time.
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( $hook_name, array( &$a, 'action' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ remove_action( $hook_name, array( &$a, 'action' ), 100 );
</ins><span class="cx" style="display: block; padding: 0 10px"> do_action( $hook_name );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 1, $a->get_call_count() );
- $this->assertSame( array( $hook_name ), $a->get_hook_names() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 2, $a->get_call_count() );
+ $this->assertSame( array( $hook_name, $hook_name ), $a->get_hook_names() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 64186
</ins><span class="cx" style="display: block; padding: 0 10px"> * @covers ::has_action
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_has_action() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -89,8 +92,21 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( $hook_name, $callback );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 10, has_action( $hook_name, $callback ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( has_action( $hook_name, $callback, 9 ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( has_action( $hook_name ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( $hook_name, $callback, 9 );
+ add_action( $hook_name, $callback, 11 );
+ $this->assertSame( 9, has_action( $hook_name, $callback ) );
+ $this->assertTrue( has_action( $hook_name, $callback, 9 ) );
+ $this->assertTrue( has_action( $hook_name, $callback, 10 ) );
+ $this->assertTrue( has_action( $hook_name, $callback, 11 ) );
+ $this->assertTrue( has_action( $hook_name ) );
+
+ remove_action( $hook_name, $callback, 9 );
+ remove_action( $hook_name, $callback, 11 );
+ $this->assertSame( 10, has_action( $hook_name, $callback ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> remove_action( $hook_name, $callback );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( has_action( $hook_name, $callback ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( has_action( $hook_name ) );
</span></span></pre></div>
<a id="trunktestsphpunittestsfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/filters.php 2025-11-03 21:55:08 UTC (rev 61117)
+++ trunk/tests/phpunit/tests/filters.php 2025-11-03 23:45:40 UTC (rev 61118)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,6 +25,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( array( $val ), $args );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::remove_filter
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_remove_filter() {
</span><span class="cx" style="display: block; padding: 0 10px"> $a = new MockAction();
</span><span class="cx" style="display: block; padding: 0 10px"> $hook_name = __FUNCTION__;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -31,19 +34,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $val = __FUNCTION__ . '_val';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( $hook_name, array( $a, 'filter' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( $hook_name, array( $a, 'filter' ), 100 );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $val, apply_filters( $hook_name, $val ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Make sure our hook was called correctly.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 1, $a->get_call_count() );
- $this->assertSame( array( $hook_name ), $a->get_hook_names() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 2, $a->get_call_count() );
+ $this->assertSame( array( $hook_name, $hook_name ), $a->get_hook_names() );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Now remove the filter, do it again, and make sure it's not called this time.
</span><span class="cx" style="display: block; padding: 0 10px"> remove_filter( $hook_name, array( $a, 'filter' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ remove_filter( $hook_name, array( $a, 'filter' ), 100 );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $val, apply_filters( $hook_name, $val ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 1, $a->get_call_count() );
- $this->assertSame( array( $hook_name ), $a->get_hook_names() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 2, $a->get_call_count() );
+ $this->assertSame( array( $hook_name, $hook_name ), $a->get_hook_names() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 64186
+ * @covers ::has_filter
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_has_filter() {
</span><span class="cx" style="display: block; padding: 0 10px"> $hook_name = __FUNCTION__;
</span><span class="cx" style="display: block; padding: 0 10px"> $callback = __FUNCTION__ . '_func';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -53,8 +62,21 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( $hook_name, $callback );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 10, has_filter( $hook_name, $callback ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( has_filter( $hook_name, $callback, 9 ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( has_filter( $hook_name ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( $hook_name, $callback, 9 );
+ add_filter( $hook_name, $callback, 11 );
+ $this->assertSame( 9, has_filter( $hook_name, $callback ) );
+ $this->assertTrue( has_filter( $hook_name, $callback, 9 ) );
+ $this->assertTrue( has_filter( $hook_name, $callback, 10 ) );
+ $this->assertTrue( has_filter( $hook_name, $callback, 11 ) );
+ $this->assertTrue( has_filter( $hook_name ) );
+
+ remove_filter( $hook_name, $callback, 9 );
+ remove_filter( $hook_name, $callback, 11 );
+ $this->assertSame( 10, has_filter( $hook_name, $callback ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> remove_filter( $hook_name, $callback );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( has_filter( $hook_name, $callback ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( has_filter( $hook_name ) );
</span></span></pre></div>
<a id="trunktestsphpunittestshookshasFilterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/hooks/hasFilter.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/hooks/hasFilter.php 2025-11-03 21:55:08 UTC (rev 61117)
+++ trunk/tests/phpunit/tests/hooks/hasFilter.php 2025-11-03 23:45:40 UTC (rev 61118)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,16 +8,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Hooks_HasFilter extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 64186
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_has_filter_with_function() {
</span><span class="cx" style="display: block; padding: 0 10px"> $callback = '__return_null';
</span><span class="cx" style="display: block; padding: 0 10px"> $hook = new WP_Hook();
</span><span class="cx" style="display: block; padding: 0 10px"> $hook_name = __FUNCTION__;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $priority = 1;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $priority_a = 1;
+ $priority_b = 10;
</ins><span class="cx" style="display: block; padding: 0 10px"> $accepted_args = 2;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $hook->add_filter( $hook_name, $callback, $priority, $accepted_args );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $hook->add_filter( $hook_name, $callback, $priority_a, $accepted_args );
+ $hook->add_filter( $hook_name, $callback, $priority_b, $accepted_args );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( $priority, $hook->has_filter( $hook_name, $callback ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( $priority_a, $hook->has_filter( $hook_name, $callback ) );
+ $this->assertTrue( $hook->has_filter( $hook_name, $callback, $priority_a ) );
+ $this->assertTrue( $hook->has_filter( $hook_name, $callback, $priority_b ) );
+ $hook->remove_filter( $hook_name, $callback, $priority_a );
+ $this->assertSame( $priority_b, $hook->has_filter( $hook_name, $callback ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_has_filter_with_object() {
</span></span></pre>
</div>
</div>
</body>
</html>