<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[61073] trunk: Script Loader: Restore original return value for `WP_Script_Modules::get_dependencies()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/61073">61073</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/61073","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-10-27 16:10:24 +0000 (Mon, 27 Oct 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Script Loader: Restore original return value for `WP_Script_Modules::get_dependencies()`.
Even though this method is private, there are some usages of it in the ecosystem via the Reflection API. So this reverts the script module IDs `string[]` return value in favor of the original `array<string, array>` return value. This re-emphasizes the need for more public accessor methods being tracked in <a href="https://core.trac.wordpress.org/ticket/60597">#60597</a>.
Developed in https://github.com/WordPress/wordpress-develop/pull/10403
Follow-up to <a href="https://core.trac.wordpress.org/changeset/60999">[60999]</a>.
Props pbiron, westonruter, johnbillion.
See <a href="https://core.trac.wordpress.org/ticket/63486">#63486</a>, <a href="https://core.trac.wordpress.org/ticket/60597">#60597</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpscriptmodulesphp">trunk/src/wp-includes/class-wp-script-modules.php</a></li>
<li><a href="#trunktestsphpunittestsscriptmoduleswpScriptModulesphp">trunk/tests/phpunit/tests/script-modules/wpScriptModules.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpscriptmodulesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-script-modules.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-script-modules.php 2025-10-27 12:35:43 UTC (rev 61072)
+++ trunk/src/wp-includes/class-wp-script-modules.php 2025-10-27 16:10:24 UTC (rev 61073)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -398,7 +398,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ! $this->registered[ $id ]['in_footer']
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // If any dependency is set to be printed in footer, skip printing this module in head.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $dependencies = $this->get_dependencies( array( $id ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $dependencies = array_keys( $this->get_dependencies( array( $id ) ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> foreach ( $dependencies as $dependency_id ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if (
</span><span class="cx" style="display: block; padding: 0 10px"> in_array( $dependency_id, $this->queue, true ) &&
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -528,7 +528,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function get_import_map(): array {
</span><span class="cx" style="display: block; padding: 0 10px"> $imports = array();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $this->get_dependencies( $this->queue ) as $id ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( array_keys( $this->get_dependencies( $this->queue ) ) as $id ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $src = $this->get_src( $id );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( '' !== $src ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $imports[ $id ] = $src;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -566,7 +566,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string[] $ids The identifiers of the script modules for which to gather dependencies.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string[] $import_types Optional. Import types of dependencies to retrieve: 'static', 'dynamic', or both.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default is both.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @return string[] List of IDs for script module dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @return array<string, array> List of dependencies, keyed by script module identifier.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function get_dependencies( array $ids, array $import_types = array( 'static', 'dynamic' ) ): array {
</span><span class="cx" style="display: block; padding: 0 10px"> $all_dependencies = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -584,7 +584,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> in_array( $dependency['import'], $import_types, true ) &&
</span><span class="cx" style="display: block; padding: 0 10px"> isset( $this->registered[ $dependency['id'] ] )
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $all_dependencies[ $dependency['id'] ] = true;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $all_dependencies[ $dependency['id'] ] = $this->registered[ $dependency['id'] ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add this dependency to the list to get dependencies for.
</span><span class="cx" style="display: block; padding: 0 10px"> $id_queue[] = $dependency['id'];
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -592,7 +592,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return array_keys( $all_dependencies );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return $all_dependencies;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestsscriptmoduleswpScriptModulesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/script-modules/wpScriptModules.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/script-modules/wpScriptModules.php 2025-10-27 12:35:43 UTC (rev 61072)
+++ trunk/tests/phpunit/tests/script-modules/wpScriptModules.php 2025-10-27 16:10:24 UTC (rev 61073)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -225,8 +225,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $reflection_class = new ReflectionClass( wp_script_modules() );
</span><span class="cx" style="display: block; padding: 0 10px"> $get_marked_for_enqueue = $reflection_class->getMethod( 'get_marked_for_enqueue' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $get_dependencies = $reflection_class->getMethod( 'get_dependencies' );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( PHP_VERSION_ID < 80100 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $get_marked_for_enqueue->setAccessible( true );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $get_dependencies->setAccessible( true );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $register_and_enqueue = static function ( ...$args ) use ( $use_global_function, $only_enqueue ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -254,6 +256,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( wp_script_modules()->get_queue(), array_keys( $marked_for_enqueue ), 'Expected get_queue() to match keys returned by get_marked_for_enqueue().' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray( $marked_for_enqueue['a'], 'Expected script module "a" to have an array entry.' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '/a.js', $marked_for_enqueue['a']['src'], 'Expected script module "a" to have the given src.' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( array(), $get_dependencies->invoke( wp_script_modules(), array( 'a' ) ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // One Dependency.
</span><span class="cx" style="display: block; padding: 0 10px"> $register( 'b-dep', '/b-dep.js' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -260,6 +263,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $register_and_enqueue( 'b', '/b.js', array( 'b-dep' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( wp_script_modules()->set_fetchpriority( 'b', 'low' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( array( 'a', 'b' ), wp_script_modules()->get_queue() );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame(
+ array(
+ 'b-dep' => array(
+ 'src' => '/b-dep.js',
+ 'version' => false,
+ 'dependencies' => array(),
+ 'in_footer' => false,
+ 'fetchpriority' => 'auto',
+ ),
+ ),
+ $get_dependencies->invoke( wp_script_modules(), array( 'b' ) )
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Two dependencies with different formats and a false version.
</span><span class="cx" style="display: block; padding: 0 10px"> $register( 'c-dep', '/c-static.js', array(), false, array( 'fetchpriority' => 'low' ) );
</span></span></pre>
</div>
</div>
</body>
</html>