<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60728] trunk: I18N: Use `Domain Path` for script translations if available.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60728">60728</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60728","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>swissspidy</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-09-11 10:11:40 +0000 (Thu, 11 Sep 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>I18N: Use `Domain Path` for script translations if available.
This is a follow-up to <a href="https://core.trac.wordpress.org/changeset/59461">[59461]</a> from 6.8, which leveraged `Domain Path` for just-in-time loading of MO/PHP translation files.
Now, the same is done for script translations, which means plugins/themes shipping with their own translation no longer need to manually specify the translation path when calling `wp_set_script_translations()`.
Props tusharbharti, swissspidy, shailu25, jsnajdr.
See <a href="https://core.trac.wordpress.org/ticket/62244">#62244</a>, <a href="https://core.trac.wordpress.org/ticket/54797">#54797</a>.
Fixes <a href="https://core.trac.wordpress.org/ticket/63944">#63944</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesl10nphp">trunk/src/wp-includes/l10n.php</a></li>
<li><a href="#trunktestsphpunittestsdependenciesscriptsphp">trunk/tests/phpunit/tests/dependencies/scripts.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesl10nphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/l10n.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/l10n.php 2025-09-10 20:25:46 UTC (rev 60727)
+++ trunk/src/wp-includes/l10n.php 2025-09-11 10:11:40 UTC (rev 60728)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1134,6 +1134,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @see WP_Scripts::set_translations()
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @global WP_Textdomain_Registry $wp_textdomain_registry WordPress Textdomain Registry.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param string $handle Name of the script to register a translation domain to.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $domain Optional. Text domain. Default 'default'.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $path Optional. The full file path to the directory containing translation files.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1141,6 +1143,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * false if the script textdomain could not be loaded.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function load_script_textdomain( $handle, $domain = 'default', $path = '' ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /** @var WP_Textdomain_Registry $wp_textdomain_registry */
+ global $wp_textdomain_registry;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $wp_scripts = wp_scripts();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1147,9 +1152,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $path = untrailingslashit( $path );
</del><span class="cx" style="display: block; padding: 0 10px"> $locale = determine_locale();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $path ) {
+ $path = $wp_textdomain_registry->get( $domain, $locale );
+ }
+
+ $path = untrailingslashit( $path );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // If a path was given and the handle file exists simply return it.
</span><span class="cx" style="display: block; padding: 0 10px"> $file_base = 'default' === $domain ? $locale : $domain . '-' . $locale;
</span><span class="cx" style="display: block; padding: 0 10px"> $handle_filename = $file_base . '-' . $handle . '.json';
</span></span></pre></div>
<a id="trunktestsphpunittestsdependenciesscriptsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/dependencies/scripts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/dependencies/scripts.php 2025-09-10 20:25:46 UTC (rev 60727)
+++ trunk/tests/phpunit/tests/dependencies/scripts.php 2025-09-11 10:11:40 UTC (rev 60728)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2633,6 +2633,73 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 63944
+ */
+ public function test_wp_set_script_translations_uses_registered_domainpath_for_plugin() {
+ global $wp_textdomain_registry;
+
+ wp_register_script( 'wp-i18n', '/wp-includes/js/dist/wp-i18n.js', array(), null );
+ wp_enqueue_script( 'domain-path-plugin', '/wp-content/plugins/my-plugin/js/script.js', array(), null );
+
+ // Simulate a plugin declaring DomainPath: /languages by registering a custom path.
+ $wp_textdomain_registry->set_custom_path( 'internationalized-plugin', DIR_TESTDATA . '/languages/plugins' );
+ wp_set_script_translations( 'domain-path-plugin', 'internationalized-plugin' );
+
+ $expected = "<script type='text/javascript' src='/wp-includes/js/dist/wp-i18n.js' id='wp-i18n-js'></script>\n";
+ $expected .= str_replace(
+ array(
+ '__DOMAIN__',
+ '__HANDLE__',
+ '__JSON_TRANSLATIONS__',
+ ),
+ array(
+ 'internationalized-plugin',
+ 'domain-path-plugin',
+ file_get_contents( DIR_TESTDATA . '/languages/plugins/internationalized-plugin-en_US-2f86cb96a0233e7cb3b6f03ad573be0b.json' ),
+ ),
+ $this->wp_scripts_print_translations_output
+ );
+ $expected .= "<script type='text/javascript' src='/wp-content/plugins/my-plugin/js/script.js' id='domain-path-plugin-js'></script>\n";
+
+ $this->assertEqualHTML( $expected, get_echo( 'wp_print_scripts' ) );
+ }
+
+ /**
+ * @ticket 63944
+ *
+ * Ensure human-readable script translation filenames are found when a
+ * textdomain has a custom DomainPath registered and no explicit $path is passed.
+ */
+ public function test_wp_set_script_translations_prefers_human_readable_filename_in_registered_domainpath() {
+ global $wp_textdomain_registry;
+
+ wp_register_script( 'wp-i18n', '/wp-includes/js/dist/wp-i18n.js', array(), null );
+ wp_enqueue_script( 'script-handle', '/wp-admin/js/script.js', array(), null );
+
+ // Register the admin textdomain path and use the admin translations file for this script-handle test.
+ $wp_textdomain_registry->set_custom_path( 'admin', DIR_TESTDATA . '/languages' );
+ wp_set_script_translations( 'script-handle', 'admin' );
+
+ $expected = "<script type='text/javascript' src='/wp-includes/js/dist/wp-i18n.js' id='wp-i18n-js'></script>\n";
+ $expected .= str_replace(
+ array(
+ '__DOMAIN__',
+ '__HANDLE__',
+ '__JSON_TRANSLATIONS__',
+ ),
+ array(
+ 'admin',
+ 'script-handle',
+ file_get_contents( DIR_TESTDATA . '/languages/admin-en_US-script-handle.json' ),
+ ),
+ $this->wp_scripts_print_translations_output
+ );
+ $expected .= "<script type='text/javascript' src='/wp-admin/js/script.js' id='script-handle-js'></script>\n";
+
+ $this->assertEqualHTML( $expected, get_echo( 'wp_print_scripts' ) );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 45103
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_set_script_translations_for_plugin() {
</span></span></pre>
</div>
</div>
</body>
</html>