<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60715] trunk/src: Customizer: Accessible errors when adding new pages.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60715">60715</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60715","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-09-07 02:45:32 +0000 (Sun, 07 Sep 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Customizer: Accessible errors when adding new pages.
When setting the home page settings or dynamically adding new pages in the menu manager, the error messages didn't meet accessibility standards.
Add a screen reader announcement, a visible notification, and standardize the error styles.
Props dilipbheda, dlh, celloexpressions, joedolson, jeremiahbratton, shailu25.
Fixes <a href="https://core.trac.wordpress.org/ticket/50696">#50696</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueueswpcustomizecontrolsjs">trunk/src/js/_enqueues/wp/customize/controls.js</a></li>
<li><a href="#trunksrcjs_enqueueswpcustomizenavmenusjs">trunk/src/js/_enqueues/wp/customize/nav-menus.js</a></li>
<li><a href="#trunksrcwpincludesclasswpcustomizecontrolphp">trunk/src/wp-includes/class-wp-customize-control.php</a></li>
<li><a href="#trunksrcwpincludesclasswpcustomizenavmenusphp">trunk/src/wp-includes/class-wp-customize-nav-menus.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueueswpcustomizecontrolsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/customize/controls.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/customize/controls.js 2025-09-06 21:56:18 UTC (rev 60714)
+++ trunk/src/js/_enqueues/wp/customize/controls.js 2025-09-07 02:45:32 UTC (rev 60715)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4066,7 +4066,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return {void}
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> addNewPage: function () {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var control = this, promise, toggle, container, input, title, select;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var control = this, promise, toggle, container, input, inputError, title, select;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'dropdown-pages' !== control.params.type || ! control.params.allow_addition || ! api.Menus ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4075,15 +4075,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> toggle = control.container.find( '.add-new-toggle' );
</span><span class="cx" style="display: block; padding: 0 10px"> container = control.container.find( '.new-content-item-wrapper' );
</span><span class="cx" style="display: block; padding: 0 10px"> input = control.container.find( '.create-item-input' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ inputError = control.container.find('.create-item-error');
</ins><span class="cx" style="display: block; padding: 0 10px"> title = input.val();
</span><span class="cx" style="display: block; padding: 0 10px"> select = control.container.find( 'select' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! title ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- input.addClass( 'invalid' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ container.addClass( 'form-invalid' );
+ input.attr('aria-invalid', 'true');
+ input.attr('aria-describedby', inputError.attr('id'));
+ inputError.slideDown( 'fast' );
+ wp.a11y.speak( inputError.text() );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- input.removeClass( 'invalid' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ container.removeClass( 'form-invalid' );
+ input.attr('aria-invalid', 'false');
+ input.removeAttr('aria-describedby');
+ inputError.hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> input.attr( 'disabled', 'disabled' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // The menus functions add the page, publish when appropriate,
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpcustomizenavmenusjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/customize/nav-menus.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/customize/nav-menus.js 2025-09-06 21:56:18 UTC (rev 60714)
+++ trunk/src/js/_enqueues/wp/customize/nav-menus.js 2025-09-07 02:45:32 UTC (rev 60715)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -661,6 +661,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> itemType = dataContainer.data( 'type' ),
</span><span class="cx" style="display: block; padding: 0 10px"> itemObject = dataContainer.data( 'object' ),
</span><span class="cx" style="display: block; padding: 0 10px"> itemTypeLabel = dataContainer.data( 'type_label' ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ inputError = container.find('.create-item-error'),
</ins><span class="cx" style="display: block; padding: 0 10px"> promise;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! this.currentMenuControl ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -671,13 +672,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'post_type' !== itemType ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( '' === itemName.val().trim() ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- itemName.addClass( 'invalid' );
- itemName.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ container.addClass( 'form-invalid' );
+ itemName.attr('aria-invalid', 'true');
+ itemName.attr('aria-describedby', inputError.attr('id'));
+ inputError.slideDown( 'fast' );
+ wp.a11y.speak( inputError.text() );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- itemName.removeClass( 'invalid' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ container.removeClass( 'form-invalid' );
+ itemName.attr('aria-invalid', 'false');
+ itemName.removeAttr('aria-describedby');
+ inputError.hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> container.find( '.accordion-section-title' ).addClass( 'loading' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpcustomizecontrolphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-customize-control.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-customize-control.php 2025-09-06 21:56:18 UTC (rev 60714)
+++ trunk/src/wp-includes/class-wp-customize-control.php 2025-09-07 02:45:32 UTC (rev 60715)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -646,9 +646,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="new-content-item-wrapper">
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="create-input-<?php echo esc_attr( $this->id ); ?>"><?php _e( 'New page title' ); ?></label>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="new-content-item">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="text" id="create-input-<?php echo esc_attr( $this->id ); ?>" class="create-item-input" >
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="text" id="create-input-<?php echo esc_attr( $this->id ); ?>" class="create-item-input form-required">
</ins><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="button add-content"><?php _e( 'Add' ); ?></button>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <span id="create-input-<?php echo esc_attr( $this->id ); ?>-error" class="create-item-error error-message" style="display: none;"><?php _e( 'Please enter a page title' ); ?></span>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpcustomizenavmenusphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-customize-nav-menus.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-customize-nav-menus.php 2025-09-06 21:56:18 UTC (rev 60714)
+++ trunk/src/wp-includes/class-wp-customize-nav-menus.php 2025-09-07 02:45:32 UTC (rev 60715)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1237,9 +1237,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="new-content-item-wrapper">
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="<?php echo esc_attr( 'create-item-input-' . $available_item_type['object'] ); ?>"><?php echo esc_html( $post_type_obj->labels->add_new_item ); ?></label>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="new-content-item">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="text" id="<?php echo esc_attr( 'create-item-input-' . $available_item_type['object'] ); ?>" class="create-item-input">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="text" id="<?php echo esc_attr( 'create-item-input-' . $available_item_type['object'] ); ?>" class="create-item-input form-required">
</ins><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="button add-content"><?php _e( 'Add' ); ?></button>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <span id="create-input-<?php echo esc_attr( $available_item_type['object'] ); ?>-error" class="create-item-error error-message" style="display: none;"><?php _e( 'Please enter an item title' ); ?></span>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span></span></pre>
</div>
</div>
</body>
</html>