<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60611] trunk: Block Bindings: Add filter to set supported block attributes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60611">60611</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60611","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>Bernhard Reiter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-08-06 18:20:22 +0000 (Wed, 06 Aug 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Block Bindings: Add filter to set supported block attributes.
Add a new filter, `block_bindings_supported_attributes_{$block_type}`, that allows customizing which of a block's attributes can be connected to a Block Bindings source.
Props bernhard-reiter, gziolo, maxschmeling.
Closes <a href="https://core.trac.wordpress.org/ticket/62090">#62090</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpblockphp">trunk/src/wp-includes/class-wp-block.php</a></li>
<li><a href="#trunktestsphpunittestsblockbindingsrenderphp">trunk/tests/phpunit/tests/block-bindings/render.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpblockphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-block.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-block.php 2025-08-06 16:58:46 UTC (rev 60610)
+++ trunk/src/wp-includes/class-wp-block.php 2025-08-06 18:20:22 UTC (rev 60611)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -99,6 +99,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public $inner_content = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * List of supported block attributes for block bindings.
+ *
+ * @since 6.9.0
+ * @var array
+ *
+ * @see WP_Block::process_block_bindings()
+ */
+ private const BLOCK_BINDINGS_SUPPORTED_ATTRIBUTES = array(
+ 'core/paragraph' => array( 'content' ),
+ 'core/heading' => array( 'content' ),
+ 'core/image' => array( 'id', 'url', 'title', 'alt' ),
+ 'core/button' => array( 'url', 'text', 'linkTarget', 'rel' ),
+ 'core/post-date' => array( 'datetime' ),
+ );
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Constructor.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Populates object properties from the provided block instance argument.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -278,20 +294,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array The computed block attributes for the provided block bindings.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function process_block_bindings() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $block_type = $this->name;
</ins><span class="cx" style="display: block; padding: 0 10px"> $parsed_block = $this->parsed_block;
</span><span class="cx" style="display: block; padding: 0 10px"> $computed_attributes = array();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $supported_block_attributes = array(
- 'core/paragraph' => array( 'content' ),
- 'core/heading' => array( 'content' ),
- 'core/image' => array( 'id', 'url', 'title', 'alt' ),
- 'core/button' => array( 'url', 'text', 'linkTarget', 'rel' ),
- 'core/post-date' => array( 'datetime' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $supported_block_attributes =
+ self::BLOCK_BINDINGS_SUPPORTED_ATTRIBUTES[ $block_type ] ??
+ array();
+
+ /**
+ * Filters the supported block attributes for block bindings.
+ *
+ * The dynamic portion of the hook name, `$block_type`, refers to the block type
+ * whose attributes are being filtered.
+ *
+ * @since 6.9.0
+ *
+ * @param string[] $supported_block_attributes The block's attributes that are supported by block bindings.
+ */
+ $supported_block_attributes = apply_filters(
+ "block_bindings_supported_attributes_{$block_type}",
+ $supported_block_attributes
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If the block doesn't have the bindings property, isn't one of the supported
</span><span class="cx" style="display: block; padding: 0 10px"> // block types, or the bindings property is not an array, return the block content.
</span><span class="cx" style="display: block; padding: 0 10px"> if (
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- ! isset( $supported_block_attributes[ $this->name ] ) ||
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ empty( $supported_block_attributes ) ||
</ins><span class="cx" style="display: block; padding: 0 10px"> empty( $parsed_block['attrs']['metadata']['bindings'] ) ||
</span><span class="cx" style="display: block; padding: 0 10px"> ! is_array( $parsed_block['attrs']['metadata']['bindings'] )
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -315,7 +344,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Note that this also omits the `__default` attribute from the
</span><span class="cx" style="display: block; padding: 0 10px"> * resulting array.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $supported_block_attributes[ $parsed_block['blockName'] ] as $attribute_name ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( $supported_block_attributes as $attribute_name ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> // Retain any non-pattern override bindings that might be present.
</span><span class="cx" style="display: block; padding: 0 10px"> $updated_bindings[ $attribute_name ] = isset( $bindings[ $attribute_name ] )
</span><span class="cx" style="display: block; padding: 0 10px"> ? $bindings[ $attribute_name ]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -334,7 +363,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $bindings as $attribute_name => $block_binding ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // If the attribute is not in the supported list, process next attribute.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! in_array( $attribute_name, $supported_block_attributes[ $this->name ], true ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! in_array( $attribute_name, $supported_block_attributes, true ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> // If no source is provided, or that source is not registered, process next attribute.
</span></span></pre></div>
<a id="trunktestsphpunittestsblockbindingsrenderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/block-bindings/render.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/block-bindings/render.php 2025-08-06 16:58:46 UTC (rev 60610)
+++ trunk/tests/phpunit/tests/block-bindings/render.php 2025-08-06 18:20:22 UTC (rev 60611)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,6 +17,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Sets up shared fixtures.
+ *
+ * @since 6.9.0
+ */
+ public static function wpSetUpBeforeClass() {
+ register_block_type(
+ 'test/block',
+ array(
+ 'attributes' => array(
+ 'myAttribute' => array(
+ 'type' => 'string',
+ ),
+ ),
+ 'render_callback' => function ( $attributes ) {
+ return '<p>' . esc_html( $attributes['myAttribute'] ) . '</p>';
+ },
+ )
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Tear down after each test.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.5.0
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,6 +53,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tear down after class.
+ *
+ * @since 6.9.0
+ */
+ public static function wpTearDownAfterClass() {
+ unregister_block_type( 'test/block' );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Test if the block content is updated with the value returned by the source.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 60282
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -73,6 +103,53 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Test if the block_bindings_supported_attributes_{$block_type} filter is applied correctly.
+ *
+ * @ticket 62090
+ */
+ public function test_filter_block_bindings_supported_attributes() {
+ $get_value_callback = function () {
+ return 'test source value';
+ };
+
+ register_block_bindings_source(
+ self::SOURCE_NAME,
+ array(
+ 'label' => self::SOURCE_LABEL,
+ 'get_value_callback' => $get_value_callback,
+ )
+ );
+
+ add_filter(
+ 'block_bindings_supported_attributes_test/block',
+ function ( $supported_attributes ) {
+ $supported_attributes[] = 'myAttribute';
+ return $supported_attributes;
+ }
+ );
+
+ $block_content = <<<HTML
+<!-- wp:test/block {"metadata":{"bindings":{"myAttribute":{"source":"test/source"}}}} -->
+<p>This should not appear</p>
+<!-- /wp:test/block -->
+HTML;
+ $parsed_blocks = parse_blocks( $block_content );
+ $block = new WP_Block( $parsed_blocks[0] );
+ $result = $block->render();
+
+ $this->assertSame(
+ 'test source value',
+ $block->attributes['myAttribute'],
+ "The 'myAttribute' attribute should be updated with the value returned by the source."
+ );
+ $this->assertSame(
+ '<p>test source value</p>',
+ trim( $result ),
+ 'The block content should be updated with the value returned by the source.'
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Test passing arguments to the source.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 60282
</span></span></pre>
</div>
</div>
</body>
</html>