<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60499] trunk: Customize: Account for existing query params in the admin URL when `wp_customize_url()` adds the `theme` query param.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60499">60499</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60499","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-07-24 04:50:40 +0000 (Thu, 24 Jul 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Customize: Account for existing query params in the admin URL when `wp_customize_url()` adds the `theme` query param.
Query parameters may be inserted in the initial `customize.php` URL via the `admin_url` and `site_url` filters.
Props xipasduarte, westonruter.
Fixes <a href="https://core.trac.wordpress.org/ticket/63632">#63632</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesthemephp">trunk/src/wp-includes/theme.php</a></li>
<li><a href="#trunktestsphpunitteststhemewpThemephp">trunk/tests/phpunit/tests/theme/wpTheme.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesthemephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/theme.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/theme.php 2025-07-23 16:58:57 UTC (rev 60498)
+++ trunk/src/wp-includes/theme.php 2025-07-24 04:50:40 UTC (rev 60499)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3771,7 +3771,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function wp_customize_url( $stylesheet = '' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $url = admin_url( 'customize.php' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $stylesheet ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $url .= '?theme=' . urlencode( $stylesheet );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $url = add_query_arg( 'theme', urlencode( $stylesheet ), $url );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> return esc_url( $url );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunitteststhemewpThemephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/theme/wpTheme.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/theme/wpTheme.php 2025-07-23 16:58:57 UTC (rev 60498)
+++ trunk/tests/phpunit/tests/theme/wpTheme.php 2025-07-24 04:50:40 UTC (rev 60499)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -376,6 +376,101 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Test wp_customize_url with no $stylesheet argument.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_no_stylesheet() {
+ $this->assertSame( esc_url( admin_url( 'customize.php' ) ), wp_customize_url() );
+ }
+
+ /**
+ * Test wp_customize_url with no query args.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_without_query_args() {
+ $this->assertSame( esc_url( admin_url( 'customize.php?theme=foo' ) ), wp_customize_url( 'foo' ) );
+ }
+
+ /**
+ * Test wp_customize_url with existing query args.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_with_existing_query_args() {
+ $clean_admin_url = admin_url( 'customize.php' );
+
+ // Ensure the existing query arg is present in the URL.
+ add_filter(
+ 'admin_url',
+ function ( $url ) {
+ return add_query_arg( 'existing_arg', 'value', $url );
+ }
+ );
+ $this->assertSame( esc_url( $clean_admin_url . '?existing_arg=value&theme=foo' ), wp_customize_url( 'foo' ) );
+ }
+
+ /**
+ * Test wp_customize_url with existing theme query arg.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_with_existing_theme_query_arg() {
+ $clean_admin_url = admin_url( 'customize.php' );
+
+ // Ensure the theme query arg is replaced with the new value.
+ add_filter(
+ 'admin_url',
+ function ( $url ) {
+ return add_query_arg( 'theme', 'to-be-replaced', $url );
+ }
+ );
+ $this->assertSame( esc_url( $clean_admin_url . '?theme=foo' ), wp_customize_url( 'foo' ) );
+ }
+
+ /**
+ * Test wp_customize_url with multiple theme query args in array syntax.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_with_multiple_theme_query_args() {
+ $clean_admin_url = admin_url( 'customize.php' );
+
+ // Ensure the theme query arg is replaced with the new value.
+ add_filter(
+ 'admin_url',
+ function ( $url ) {
+ return add_query_arg( array( 'theme' => array( 'to-be-replaced-1', 'to-be-replaced-2' ) ), $url );
+ }
+ );
+ $this->assertSame( esc_url( $clean_admin_url . '?theme=foo' ), wp_customize_url( 'foo' ) );
+ }
+
+ /**
+ * Test wp_customize_url with special characters in the theme name.
+ *
+ * @ticket 63632
+ *
+ * @covers ::wp_customize_url
+ */
+ public function test_wp_customize_url_with_special_chars() {
+ $stylesheet = 'foo!@-_ +';
+ $expected = admin_url( 'customize.php?theme=' . urlencode( $stylesheet ) );
+ $this->assertSame( esc_url( $expected ), wp_customize_url( $stylesheet ) );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Data provider.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span></span></pre>
</div>
</div>
</body>
</html>