<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60446] trunk/tests/phpunit/tests/kses.php: Build/Test Tools: Expand and improve wp_kses_normalize_entities tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60446">60446</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60446","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>jonsurrell</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-07-10 16:00:44 +0000 (Thu, 10 Jul 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Expand and improve wp_kses_normalize_entities tests.
Update test to use a data provider for test cases.
Add a variety of HTML character references covering named, decimal, and hexadecimal forms.
Developed in https://github.com/WordPress/wordpress-develop/pull/9095.
Props jonsurrell, cbravobernal.
See <a href="https://core.trac.wordpress.org/ticket/63167">#63167</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsksesphp">trunk/tests/phpunit/tests/kses.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsksesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/kses.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/kses.php 2025-07-10 12:06:56 UTC (rev 60445)
+++ trunk/tests/phpunit/tests/kses.php 2025-07-10 16:00:44 UTC (rev 60446)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -551,21 +551,72 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @ticket 26290
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Data provider.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_wp_kses_normalize_entities() {
- $this->assertSame( '♠', wp_kses_normalize_entities( '♠' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function data_normalize_entities(): array {
+ return array(
+ /**
+ * These examples are from the wp_kses_normalize_entities function description.
+ */
+ 'AT&T' => array( 'AT&T', 'AT&T' ),
+ ':' => array( ':', ':' ),
+ '&#XYZZY;' => array( '&#XYZZY;', '&#XYZZY;' ),
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( '¹', wp_kses_normalize_entities( '¹' ) );
- $this->assertSame( '²', wp_kses_normalize_entities( '²' ) );
- $this->assertSame( '³', wp_kses_normalize_entities( '³' ) );
- $this->assertSame( '¼', wp_kses_normalize_entities( '¼' ) );
- $this->assertSame( '½', wp_kses_normalize_entities( '½' ) );
- $this->assertSame( '¾', wp_kses_normalize_entities( '¾' ) );
- $this->assertSame( '∴', wp_kses_normalize_entities( '∴' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'Named ref &' => array( '♠', '♠' ),
+ 'Named ref &' => array( '♠', '♠' ),
+ 'Named ref ♠' => array( '♠', '♠' ),
+ 'Named ref ¹' => array( '¹', '¹' ),
+ 'Named ref ²' => array( '²', '²' ),
+ 'Named ref ³' => array( '³', '³' ),
+ 'Named ref ¼' => array( '¼', '¼' ),
+ 'Named ref ½' => array( '½', '½' ),
+ 'Named ref ¾' => array( '¾', '¾' ),
+ 'Named ref ∴' => array( '∴', '∴' ),
+
+ 'Decimal ref 	 ( )' => array( '	', '	' ),
+ 'Decimal ref " (")' => array( '"', '"' ),
+ 'Decimal ref " (")' => array( '"', '"' ),
+ 'Decimal ref & (&)' => array( '&', '&' ),
+ "Decimal ref ' (')" => array( ''', ''' ),
+ 'Decimal ref 😍 (😍)' => array( '😍', '😍' ),
+ 'Decimal ref 😍 (😍)' => array( '😍', '😍' ),
+
+ 'Hex ref 	 ( )' => array( '	', '	' ),
+ 'Hex ref " (")' => array( '"', '"' ),
+ 'Hex ref " (")' => array( '"', '"' ),
+ 'Hex ref & (&)' => array( '&', '&' ),
+ "Hex ref ' (')" => array( ''', ''' ),
+ 'Hex ref 😍 (😍)' => array( '😍', '😍' ),
+ 'Hex ref 😍 (😍)' => array( '😍', '😍' ),
+
+ 'HEX REF " (")' => array( '"', '"' ),
+ 'HEX REF & (&)' => array( '&', '&' ),
+ "HEX REF ' (')" => array( ''', ''' ),
+ 'HEX REF 😍 (😍)' => array( '😍', '😍' ),
+
+ 'Encoded named ref &amp;' => array( '&amp;', '&amp;' ),
+ 'Encoded named ref &amp;' => array( '&amp;', '&amp;' ),
+ 'Encoded named ref &amp;' => array( '&amp;', '&amp;' ),
+
+ /*
+ * The codepoint value here is outside of the valid unicode range whose
+ * maximum is 0x10FFFF or 1114111.
+ */
+ 'Invalid decimal unicode �' => array( '�', '&#1114112;' ),
+ 'Invalid hex unicode �' => array( '�', '&#x110000;' ),
+ );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 26290
+ *
+ * @dataProvider data_normalize_entities
+ */
+ public function test_wp_kses_normalize_entities( string $input, string $expected ) {
+ $this->assertSame( $expected, wp_kses_normalize_entities( $input ) );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Test removal of invalid binary data for HTML.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 28506
</span></span></pre>
</div>
</div>
</body>
</html>