<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60415] trunk: Media: expose height and width attributes to the 'wp_get_attachment_image_attributes' filter.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60415">60415</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60415","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>adamsilverstein</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-07-05 18:55:29 +0000 (Sat, 05 Jul 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: expose height and width attributes to the 'wp_get_attachment_image_attributes' filter.
Include the image height and width in the attributes passed to the 'wp_get_attachment_image_attributes' filter. Developers can use this to adjust the width and height attributes returned from the 'wp_get_attachment_image_attributes' function.
Props divinenephron, nacin, Sam_a, wpsmith, anatolbroder, ericlewis, puggan, SergeyBiryukov, spacedmonkey, adamsilverstein, flixos90, sandeepdahiya, SirLouen.
Fixes <a href="https://core.trac.wordpress.org/ticket/14110">#14110</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesmediaphp">trunk/src/wp-includes/media.php</a></li>
<li><a href="#trunktestsphpunittestsmediaphp">trunk/tests/phpunit/tests/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media.php 2025-07-05 14:27:23 UTC (rev 60414)
+++ trunk/src/wp-includes/media.php 2025-07-05 18:55:29 UTC (rev 60415)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1070,7 +1070,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> list( $src, $width, $height ) = $image;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $attachment = get_post( $attachment_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $hwstring = image_hwstring( $width, $height );
</del><span class="cx" style="display: block; padding: 0 10px"> $size_class = $size;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_array( $size_class ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1090,15 +1089,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $context The context. Default 'wp_get_attachment_image'.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $context = apply_filters( 'wp_get_attachment_image_context', 'wp_get_attachment_image' );
- $attr = wp_parse_args( $attr, $default_attr );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $context = apply_filters( 'wp_get_attachment_image_context', 'wp_get_attachment_image' );
+ $attr = wp_parse_args( $attr, $default_attr );
+ $attr['width'] = $width;
+ $attr['height'] = $height;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $loading_attr = $attr;
- $loading_attr['width'] = $width;
- $loading_attr['height'] = $height;
</del><span class="cx" style="display: block; padding: 0 10px"> $loading_optimization_attr = wp_get_loading_optimization_attributes(
</span><span class="cx" style="display: block; padding: 0 10px"> 'img',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $loading_attr,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attr,
</ins><span class="cx" style="display: block; padding: 0 10px"> $context
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1169,8 +1167,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $attr = apply_filters( 'wp_get_attachment_image_attributes', $attr, $attachment, $size );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attr = array_map( 'esc_attr', $attr );
- $html = rtrim( "<img $hwstring" );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( isset( $attr['height'] ) && is_numeric( $attr['height'] ) ) {
+ $height = absint( $attr['height'] );
+ }
+ if ( isset( $attr['width'] ) && is_numeric( $attr['width'] ) ) {
+ $width = absint( $attr['width'] );
+ }
+ unset( $attr['height'], $attr['width'] );
+ $attr = array_map( 'esc_attr', $attr );
+ $hwstring = image_hwstring( $width, $height );
+ $html = rtrim( "<img $hwstring" );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $attr as $name => $value ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $html .= " $name=" . '"' . $value . '"';
</span></span></pre></div>
<a id="trunktestsphpunittestsmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media.php 2025-07-05 14:27:23 UTC (rev 60414)
+++ trunk/tests/phpunit/tests/media.php 2025-07-05 18:55:29 UTC (rev 60415)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1583,6 +1583,53 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, $output );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 14110
+ */
+ public function test_wp_get_attachment_image_filter_with_height_width() {
+ $mock_action = new MockAction();
+ add_filter( 'wp_get_attachment_image_attributes', array( $mock_action, 'filter' ) );
+ wp_get_attachment_image( self::$large_id );
+ $args = $mock_action->get_args();
+ $this->assertArrayHasKey( '0', $args, 'First argument should be an array.' );
+ $this->assertArrayHasKey( '0', $args[0], 'First argument should be an array.' );
+ $this->assertArrayHasKey( 'width', $args[0][0], 'Width should be set.' );
+ $this->assertArrayHasKey( 'height', $args[0][0], 'Height should be set.' );
+ }
+
+ /**
+ * @ticket 14110
+ */
+ public function test_wp_get_attachment_image_filter_change_height_width() {
+ add_filter(
+ 'wp_get_attachment_image_attributes',
+ static function ( $args ) {
+ $args['height'] = '999';
+ $args['width'] = '999';
+ return $args;
+ }
+ );
+ $output = wp_get_attachment_image( self::$large_id );
+ $this->assertStringContainsString( 'width="999"', $output, 'Width should be changed.' );
+ $this->assertStringContainsString( 'height="999"', $output, 'Height should be changed.' );
+ }
+
+ /**
+ * @ticket 14110
+ */
+ public function test_wp_get_attachment_image_filter_unset_height_width() {
+ add_filter(
+ 'wp_get_attachment_image_attributes',
+ static function ( $args ) {
+ unset( $args['height'], $args['width'] );
+ return $args;
+ }
+ );
+ $output = wp_get_attachment_image( self::$large_id );
+ $this->assertStringContainsString( 'width="150"', $output, 'Width should not be changed.' );
+ $this->assertStringContainsString( 'height="150"', $output, 'Height should not be changed.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function filter_wp_get_attachment_image() {
</span><span class="cx" style="display: block; padding: 0 10px"> return 'Override wp_get_attachment_image';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>