<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60365] trunk: Taxonomy: Avoid unnecessarily recalculating term counts when a post is updated and its status is unchanged.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60365">60365</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60365","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnbillion</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-06-29 22:25:13 +0000 (Sun, 29 Jun 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Taxonomy: Avoid unnecessarily recalculating term counts when a post is updated and its status is unchanged.
If the terms of the post are changed then the term recounting is still handled by `wp_update_term_count()` inside `wp_set_object_terms()`.
Props pbearne, johnbillion, peterwilsoncc, Chouby
Fixes <a href="https://core.trac.wordpress.org/ticket/42522">#42522</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostupdateTermCountOnTransitionPostStatusphp">trunk/tests/phpunit/tests/post/updateTermCountOnTransitionPostStatus.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post.php 2025-06-29 21:45:30 UTC (rev 60364)
+++ trunk/src/wp-includes/post.php 2025-06-29 22:25:13 UTC (rev 60365)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8170,6 +8170,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Post $post Post object.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function _update_term_count_on_transition_post_status( $new_status, $old_status, $post ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $new_status === $old_status ) {
+ return;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Update counts for the post's terms.
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) get_object_taxonomies( $post->post_type ) as $taxonomy ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $tt_ids = wp_get_object_terms( $post->ID, $taxonomy, array( 'fields' => 'tt_ids' ) );
</span></span></pre></div>
<a id="trunktestsphpunittestspostupdateTermCountOnTransitionPostStatusphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/post/updateTermCountOnTransitionPostStatus.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/updateTermCountOnTransitionPostStatus.php (rev 0)
+++ trunk/tests/phpunit/tests/post/updateTermCountOnTransitionPostStatus.php 2025-06-29 22:25:13 UTC (rev 60365)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,180 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * Tests for the _update_term_count_on_transition_post_status function.
+ *
+ * See Tests_Term_WpSetObjectTerms for tests that cover changing terms on a post when saving it.
+ *
+ * @group taxonomy
+ *
+ * @covers ::_update_term_count_on_transition_post_status
+ */
+class Tests_Taxonomy_UpdateTermCountOnTransitionPostStatus extends WP_UnitTestCase {
+
+ /**
+ * @var int Post ID.
+ */
+ protected static $post_id;
+
+ /**
+ * @var int Term ID.
+ */
+ protected static $term_id;
+
+ /**
+ * @var string Post type.
+ */
+ protected static $post_type = 'post';
+
+ /**
+ * @var string Taxonomy name.
+ */
+ protected static $taxonomy = 'category';
+
+ /**
+ * Create shared fixtures.
+ */
+ public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+ self::$post_id = $factory->post->create(
+ array(
+ 'post_type' => self::$post_type,
+ 'post_status' => 'publish',
+ )
+ );
+
+ self::$term_id = $factory->term->create(
+ array(
+ 'taxonomy' => self::$taxonomy,
+ 'name' => 'Test Category',
+ )
+ );
+
+ wp_set_object_terms( self::$post_id, self::$term_id, self::$taxonomy );
+ }
+
+ /**
+ * Test that the term count is updated when a post is published.
+ *
+ * @ticket 42522
+ */
+ public function test_update_term_count_on_publish() {
+ $this->assertTermCount( 1, self::$term_id );
+
+ // Change post status to draft.
+ wp_update_post(
+ array(
+ 'ID' => self::$post_id,
+ 'post_status' => 'draft',
+ )
+ );
+
+ $this->assertTermCount( 0, self::$term_id );
+
+ // Change post status back to publish.
+ wp_update_post(
+ array(
+ 'ID' => self::$post_id,
+ 'post_status' => 'publish',
+ )
+ );
+
+ $this->assertTermCount( 1, self::$term_id );
+ }
+
+ /**
+ * Test that the term count is updated when a post is moved to trash.
+ *
+ * @ticket 42522
+ */
+ public function test_update_term_count_on_trash() {
+ $this->assertTermCount( 1, self::$term_id );
+
+ // Move post to trash.
+ wp_trash_post( self::$post_id );
+
+ $this->assertTermCount( 0, self::$term_id );
+ }
+
+ /**
+ * Test that the term count is updated when a post is restored from trash.
+ *
+ * @ticket 42522
+ */
+ public function test_update_term_count_on_restore() {
+ $this->assertTermCount( 1, self::$term_id );
+
+ // Move post to trash.
+ wp_trash_post( self::$post_id );
+
+ $this->assertTermCount( 0, self::$term_id, 'Post is in trash.' );
+
+ // Restore post from trash.
+ wp_untrash_post( self::$post_id );
+
+ $this->assertTermCount( 0, self::$term_id, 'Post is in draft after untrashing.' );
+
+ // re-publish post.
+ wp_publish_post( self::$post_id );
+
+ $this->assertTermCount( 1, self::$term_id, 'Post is in publish after publishing.' );
+ }
+
+ /**
+ * Test that the term count is updated when a post is deleted permanently.
+ *
+ * @ticket 42522
+ */
+ public function test_update_term_count_on_delete() {
+ $this->assertTermCount( 1, self::$term_id );
+
+ // Delete post permanently.
+ wp_delete_post( self::$post_id, true );
+
+ $this->assertTermCount( 0, self::$term_id );
+ }
+
+ /**
+ * Test that the term count is not recalculated when neither the terms nor the post status change.
+ *
+ * @ticket 42522
+ */
+ public function test_term_count_is_not_recalculated_when_status_does_not_change() {
+ $post_id = self::factory()->post->create(
+ array(
+ 'post_type' => self::$post_type,
+ 'post_status' => 'publish',
+ )
+ );
+
+ wp_set_object_terms(
+ $post_id,
+ self::$term_id,
+ self::$taxonomy
+ );
+ $edited_term_taxonomy_count = did_action( 'edited_term_taxonomy' );
+
+ // Change something about the post but not its status.
+ wp_update_post(
+ array(
+ 'ID' => $post_id,
+ 'post_content' => get_post( $post_id )->post_content . ' - updated',
+ )
+ );
+
+ $this->assertSame( 0, did_action( 'edited_term_taxonomy' ) - $edited_term_taxonomy_count, 'Term taxonomy count should not be recalculated when post status does not change.' );
+ $this->assertTermCount( 2, self::$term_id );
+ }
+
+ /**
+ * Assert that the term count is correct.
+ *
+ * @since 6.9.0
+ *
+ * @param int $expected_count Expected term count.
+ * @param int $term_id Term ID.
+ */
+ protected function assertTermCount( $expected_count, $term_id, $message = '' ) {
+ $term = get_term( $term_id );
+ $this->assertSame( $expected_count, $term->count, $message );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/tests/post/updateTermCountOnTransitionPostStatus.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>