<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[60058] trunk: General: Remove `noopener` from links opening in a new tab in `wp_list_bookmarks()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/60058">60058</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/60058","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>audrasjb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-03-19 23:13:46 +0000 (Wed, 19 Mar 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>General: Remove `noopener` from links opening in a new tab in `wp_list_bookmarks()`.
This changeset removes the automatic addition of `rel="noopener"` from links targeting a new tab via `target="_blank"` in the `wp_list_bookmarks()` function. Since this was introduced, supported browsers have changed their security policies and no longer allow the opened link to have JavaScript access to the previous tab. This also removes the unit test cases previously located in `wpListBookmarks.php` as they were dedicated to test the presence of `rel="noopener"`.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/52061">[52061]</a>, <a href="https://core.trac.wordpress.org/changeset/59120">[59120]</a>.
Props audrasjb, rvouill, marineevain, jeremy80.
Fixes <a href="https://core.trac.wordpress.org/ticket/63096">#63096</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesbookmarktemplatephp">trunk/src/wp-includes/bookmark-template.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsbookmarkwpListBookmarksphp">trunk/tests/phpunit/tests/bookmark/wpListBookmarks.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesbookmarktemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/bookmark-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/bookmark-template.php 2025-03-19 23:01:00 UTC (rev 60057)
+++ trunk/src/wp-includes/bookmark-template.php 2025-03-19 23:13:46 UTC (rev 60058)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,14 +105,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $target = $bookmark->link_target;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( '' !== $target ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( is_string( $rel ) && '' !== $rel ) {
- if ( ! str_contains( $rel, 'noopener' ) ) {
- $rel = trim( $rel ) . ' noopener';
- }
- } else {
- $rel = 'noopener';
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> $target = ' target="' . $target . '"';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsbookmarkwpListBookmarksphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/tests/phpunit/tests/bookmark/wpListBookmarks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/bookmark/wpListBookmarks.php 2025-03-19 23:01:00 UTC (rev 60057)
+++ trunk/tests/phpunit/tests/bookmark/wpListBookmarks.php 2025-03-19 23:13:46 UTC (rev 60058)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,108 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-
-/**
- * Test wp_list_bookmarks().
- *
- * @group bookmark
- * @covers ::wp_list_bookmarks
- */
-class Tests_Functions_wpListBookmarks extends WP_UnitTestCase {
-
- /**
- * Test that wp_list_bookmarks adds "noopener" to the "rel" attribute.
- *
- * @dataProvider data_wp_list_bookmarks_adds_noopener
- *
- * @ticket 53839
- *
- * @param array $args The arguments to create the bookmark.
- * @param string $expected Expected string to test.
- */
- public function test_wp_list_bookmarks_adds_noopener( $args, $expected ) {
- self::factory()->bookmark->create( $args );
- $this->assertStringContainsString( $expected, wp_list_bookmarks( 'echo=0' ) );
- }
-
- /**
- * Data provider.
- *
- * @return array
- */
- public function data_wp_list_bookmarks_adds_noopener() {
- return array(
- 'target as "_blank"' => array(
- 'args' => array(
- 'link_name' => 'With _blank',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_blank',
- ),
- 'expected' => 'rel="noopener"',
- ),
- 'target as "_blank" and a link relationship' => array(
- 'args' => array(
- 'link_name' => 'With _blank and a link relationship',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_blank',
- 'link_rel' => 'me',
- ),
- 'expected' => 'rel="me noopener"',
- ),
- 'target as "_top"' => array(
- 'args' => array(
- 'link_name' => 'With _top',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_top',
- ),
- 'expected' => 'rel="noopener"',
- ),
- 'target as "_top" and a link relationship' => array(
- 'args' => array(
- 'link_name' => 'With _top and a link relationship',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_top',
- 'link_rel' => 'me',
- ),
- 'expected' => 'rel="me noopener"',
- ),
- );
- }
-
- /**
- * Test that wp_list_bookmarks does not add "noopener" to the "rel" attribute.
- *
- * @dataProvider data_wp_list_bookmarks_does_not_add_noopener
- *
- * @ticket 53839
- *
- * @param array $args The arguments to create the bookmark.
- */
- public function test_wp_list_bookmarks_does_not_add_noopener( $args ) {
- self::factory()->bookmark->create( $args );
- $this->assertStringNotContainsString( 'noopener', wp_list_bookmarks( 'echo=0' ) );
- }
-
- /**
- * Data provider.
- *
- * @return array
- */
- public function data_wp_list_bookmarks_does_not_add_noopener() {
- return array(
- 'target as "_none"' => array(
- 'args' => array(
- 'link_name' => 'With _blank',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_none',
- ),
- ),
- 'target as "_none" and a link relationship' => array(
- 'args' => array(
- 'link_name' => 'With _blank and a link relationship',
- 'link_url' => 'https://www.wordpress.org',
- 'link_target' => '_none',
- 'link_rel' => 'me',
- ),
- ),
- );
- }
-}
</del></span></pre>
</div>
</div>
</body>
</html>