<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59937] trunk: Query: Ensure preview links show autosave content to logged in users.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59937">59937</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59937","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>peterwilsoncc</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-03-05 22:12:06 +0000 (Wed, 05 Mar 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Query: Ensure preview links show autosave content to logged in users.
Ensures that the global post object is populated with the autosave post when a preview link is used for a published post. This allows post authors to preview the changes to a post prior to publication.
This modifies `WP_Query::the_post()` to only call `get_post()` if `WP_Query::$posts` does not contain `WP_Post` objects. Other data types (`stdClass` or numeric) indicates partial data was queried, a `WP_Post` object indicates the full data was queried and populated.
Props peterwilsoncc, mamaduka, wildworks, audrasjb.
Fixes <a href="https://core.trac.wordpress.org/ticket/56992">#56992</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpqueryphp">trunk/src/wp-includes/class-wp-query.php</a></li>
<li><a href="#trunktestsphpunittestsquerythePostphp">trunk/tests/phpunit/tests/query/thePost.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpqueryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-query.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-query.php 2025-03-05 13:13:14 UTC (rev 59936)
+++ trunk/src/wp-includes/class-wp-query.php 2025-03-05 22:12:06 UTC (rev 59937)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3779,15 +3779,16 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $post = $this->next_post();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Get the post ID.
- if ( is_object( $post ) ) {
- $global_post_id = $post->ID;
- } else {
- $global_post_id = $post;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Ensure a full post object is available.
+ if ( $post instanceof stdClass ) {
+ // stdClass indicates that a partial post object was queried.
+ $post = get_post( $post->ID );
+ } elseif ( is_numeric( $post ) ) {
+ // Numeric indicates that only post IDs were queried.
+ $post = get_post( $post );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Ensure the global $post is the full post object.
- $post = get_post( $global_post_id );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Set up the global post object for the loop.
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->setup_postdata( $post );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsquerythePostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/query/thePost.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/query/thePost.php 2025-03-05 13:13:14 UTC (rev 59936)
+++ trunk/tests/phpunit/tests/query/thePost.php 2025-03-05 22:12:06 UTC (rev 59937)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -191,4 +191,141 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'post ids and parent' => array( 'id=>parent', 4 ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Ensure draft content is shown for post previews and permalinks for logged in users.
+ *
+ * @ticket 56992
+ */
+ public function test_post_preview_links_draft_posts() {
+ $user_id = self::$author_ids[0];
+ wp_set_current_user( $user_id );
+ $draft_post = $this->factory()->post->create(
+ array(
+ 'post_status' => 'draft',
+ 'post_author' => $user_id,
+ 'post_content' => 'ticket 56992',
+ )
+ );
+
+ // Ensure the global post is populated with the draft content for the preview link.
+ $this->go_to( get_preview_post_link( $draft_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992', get_the_content(), 'Preview link should show draft content to logged in user' );
+
+ // Ensure the global post is populated with the draft content for the permalink.
+ $this->go_to( get_permalink( $draft_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show draft content to logged in user' );
+
+ // Ensure the global post is not populated with the draft content for the preview link when logged out.
+ wp_set_current_user( 0 );
+ $this->go_to( get_preview_post_link( $draft_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertEmpty( get_the_content(), 'Preview link should not show draft content to logged out users' );
+
+ // Ensure the global post is not populated with the draft content for the permalink when logged out.
+ $this->go_to( get_permalink( $draft_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertEmpty( get_the_content(), 'Permalink should not show draft content to logged out users' );
+ }
+
+ /**
+ * Ensure autosave content is shown for post previews.
+ *
+ * @ticket 56992
+ */
+ public function test_post_preview_links_autosaves() {
+ $user_id = self::$author_ids[0];
+ wp_set_current_user( $user_id );
+ $published_post = $this->factory()->post->create(
+ array(
+ 'post_status' => 'publish',
+ 'post_author' => $user_id,
+ 'post_content' => 'ticket 56992',
+ )
+ );
+
+ // Create an autosave for the published post.
+ $autosave = get_post( $published_post, ARRAY_A );
+ $autosave['post_ID'] = $published_post;
+ $autosave['post_content'] = 'ticket 56992 edited';
+ wp_create_post_autosave( $autosave );
+
+ // Set up the preview $_GET parameters.
+ $nonce = wp_create_nonce( 'post_preview_' . $published_post );
+ $query_args['preview_id'] = $published_post;
+ $query_args['preview_nonce'] = $nonce;
+ $post_preview_link = get_preview_post_link( $published_post, $query_args );
+
+ /*
+ * Set up the GET parameters for the preview link.
+ *
+ * _show_post_preview() checks the $_GET super global for preview
+ * and nonce parameters. It needs to run prior to the global query
+ * being set up in WP_Query (via $this->go_to()), so the preview
+ * parameters are created here to ensure _show_post_preview()
+ * runs correctly.
+ */
+ $_GET['preview_id'] = $published_post;
+ $_GET['preview_nonce'] = $nonce;
+ _show_post_preview();
+
+ // Ensure the global post is populated with the autosave content for the preview link.
+ $this->go_to( $post_preview_link );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992 edited', get_the_content(), 'Preview link should show autosave content to logged in user' );
+
+ // Ensure the global post is populated with the published content for the permalink.
+ $this->go_to( get_permalink( $published_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show published content to logged in user' );
+
+ wp_set_current_user( 0 );
+
+ // New user, new nonce; set up the preview $_GET parameters.
+ $nonce = wp_create_nonce( 'post_preview_' . $published_post );
+ $query_args['preview_id'] = $published_post;
+ $query_args['preview_nonce'] = $nonce;
+ $post_preview_link = get_preview_post_link( $published_post, $query_args );
+
+ /*
+ * Set up the GET parameters for the preview link.
+ *
+ * _show_post_preview() checks the $_GET super global for preview
+ * and nonce parameters. It needs to run prior to the global query
+ * being set up in WP_Query (via $this->go_to()), so the preview
+ * parameters are created here to ensure _show_post_preview()
+ * runs correctly.
+ */
+ $_GET['preview_id'] = $published_post;
+ $_GET['preview_nonce'] = $nonce;
+ _show_post_preview();
+
+ // Ensure the global post is not populated with the draft content for the preview link when logged out.
+ $this->go_to( $post_preview_link );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992', get_the_content(), 'Preview link should show published content to logged out users' );
+
+ // Ensure the global post is not populated with the draft content for the permalink when logged out.
+ $this->go_to( get_permalink( $published_post ) );
+ if ( have_posts() ) {
+ the_post();
+ }
+ $this->assertSame( 'ticket 56992', get_the_content(), 'Permalink should show published content to logged out users' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>