<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59818] trunk: Pings/Trackbacks: Add return value to `pingback()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59818">59818</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59818","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>flixos90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-02-12 23:44:00 +0000 (Wed, 12 Feb 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Pings/Trackbacks: Add return value to `pingback()`.
This facilitates debugging and better response / error handling, among other things.
Props audrasjb, coquardcyr, dshanske, ironprogrammer, NathanAtmoz, pbearne, shulard, soulseekah.
Fixes <a href="https://core.trac.wordpress.org/ticket/38197">#38197</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestscommentpingbackphp">trunk/tests/phpunit/tests/comment/pingback.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment.php 2025-02-12 21:48:04 UTC (rev 59817)
+++ trunk/src/wp-includes/comment.php 2025-02-12 23:44:00 UTC (rev 59818)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2890,6 +2890,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $pingback_link_offset_dquote = strpos( $contents, $pingback_str_dquote );
</span><span class="cx" style="display: block; padding: 0 10px"> $pingback_link_offset_squote = strpos( $contents, $pingback_str_squote );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $pingback_link_offset_dquote || $pingback_link_offset_squote ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $quote = ( $pingback_link_offset_dquote ) ? '"' : '\'';
</span><span class="cx" style="display: block; padding: 0 10px"> $pingback_link_offset = ( '"' === $quote ) ? $pingback_link_offset_dquote : $pingback_link_offset_squote;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3079,9 +3080,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 0.71
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0 `$post` can be a WP_Post object.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.8.0 Returns an array of pingback statuses indexed by link.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $content Post content to check for links. If empty will retrieve from post.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int|WP_Post $post Post ID or object.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @return array<string, bool> An array of pingback statuses indexed by link.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function pingback( $content, $post ) {
</span><span class="cx" style="display: block; padding: 0 10px"> require_once ABSPATH . WPINC . '/class-IXR.php';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3093,7 +3096,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $post = get_post( $post );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $post ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return array();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $pung = get_pung( $post );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3108,6 +3111,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $post_links_temp = wp_extract_urls( $content );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ping_status = array();
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Step 2.
</span><span class="cx" style="display: block; padding: 0 10px"> * Walking through the links array.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3179,11 +3183,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // When set to true, this outputs debug messages by itself.
</span><span class="cx" style="display: block; padding: 0 10px"> $client->debug = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $client->query( 'pingback.ping', $pagelinkedfrom, $pagelinkedto ) || ( isset( $client->error->code ) && 48 == $client->error->code ) ) { // Already registered.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $status = $client->query( 'pingback.ping', $pagelinkedfrom, $pagelinkedto );
+
+ if ( $status // Ping registered.
+ || ( isset( $client->error->code ) && 48 === $client->error->code ) // Already registered.
+ ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> add_ping( $post, $pagelinkedto );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ping_status[ $pagelinkedto ] = $status;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ return $ping_status;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestscommentpingbackphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/comment/pingback.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/comment/pingback.php (rev 0)
+++ trunk/tests/phpunit/tests/comment/pingback.php 2025-02-12 23:44:00 UTC (rev 59818)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,91 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group comment
+ * @covers ::pingback
+ */
+class Tests_Comment_Pingback extends WP_UnitTestCase {
+
+ protected static $post_id;
+ protected $response = array();
+
+ public function set_up() {
+ parent::set_up();
+
+ add_filter( 'pre_http_request', array( $this, 'request_response' ) );
+ }
+
+ public function tear_down() {
+ remove_filter( 'pre_http_request', array( $this, 'request_response' ) );
+ parent::tear_down();
+ }
+
+ public function test_pingback() {
+ $content = <<<HTML
+<a href="http://example.org">test</a>
+<a href="http://example1.org/test">test</a>
+<a href="http://example3.org/">test</a>
+HTML;
+
+ $body = <<<BODY
+ <a rel="pingback" href="https://example1.org/test/pingback">test</a>
+BODY;
+
+ $this->response = array(
+ 'body' => $body,
+ 'response' => array( 'code' => 200 ),
+ );
+
+ self::$post_id = self::factory()->post->create(
+ array( 'post_content' => $content )
+ );
+
+ $post = get_post( self::$post_id );
+ $this->assertEquals( array( 'http://example1.org/test' => false ), pingback( $post->post_content, self::$post_id ) );
+ }
+
+ public function test_pingback_no_ping_back() {
+ $content = <<<HTML
+<a href="http://example.org">test</a>
+<a href="http://example1.org/test">test</a>
+<a href="http://example3.org/">test</a>
+HTML;
+
+ $body = <<<BODY
+ <a href="https://example1.org/test">test</a>
+BODY;
+
+ $this->response = array(
+ 'body' => $body,
+ 'response' => array( 'code' => 200 ),
+ );
+
+ self::$post_id = self::factory()->post->create(
+ array( 'post_content' => $content )
+ );
+
+ $post = get_post( self::$post_id );
+ $this->assertEquals( array(), pingback( $post->post_content, self::$post_id ) );
+ }
+
+ public function test_pingback_error_response() {
+ $content = <<<HTML
+<a href="http://example.org">test</a>
+<a href="http://example1.org/test">test</a>
+<a href="http://example3.org/">test</a>
+HTML;
+
+ $this->response = new WP_Error();
+
+ self::$post_id = self::factory()->post->create(
+ array( 'post_content' => $content )
+ );
+
+ $post = get_post( self::$post_id );
+ $this->assertEquals( array(), pingback( $post->post_content, self::$post_id ) );
+ }
+
+ public function request_response() {
+ return $this->response;
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/tests/comment/pingback.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>