<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59741] branches/6.7/tests/phpunit/tests/dependencies/scripts.php: External Libraries: Append .1 to react/react-dom versions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59741">59741</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59741","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>jorbin</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-01-30 20:42:03 +0000 (Thu, 30 Jan 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>External Libraries: Append .1 to react/react-dom versions.
In 6.7, <a href="https://core.trac.wordpress.org/changeset/58775">[58775]</a> changed the way react and react-dom are bundled in Core. This commit resulted in some changes to the built files that are distributed in WordPress even though the actual version of the libraries remained the same. The result can be a blank white screen when trying to edit a post when those two script files are heavily cached.
This uses `.1` as the appendage to prevent issues with third party code expecting the version number in the form `/^[\d\.]+$/`.
Updates include tests in `Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually` to include the modified version used for cache busting.
Reviewed by jorbin.
Merges <a href="https://core.trac.wordpress.org/changeset/59536">[59536]</a> and <a href="https://core.trac.wordpress.org/changeset/59540">[59540]</a> to 6.7 branch.
Props levskipg, get_dave, smerriman, jdnd, juanwp22, seanlanglands, robertstaddon, azaozz, peterwilsoncc, desrosj.
Fixes <a href="https://core.trac.wordpress.org/ticket/62422">#62422</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches67srcwpincludesscriptloaderphp">branches/6.7/src/wp-includes/script-loader.php</a></li>
<li><a href="#branches67testsphpunittestsdependenciesscriptsphp">branches/6.7/tests/phpunit/tests/dependencies/scripts.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches67">branches/6.7/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/6.7
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/6.7 2025-01-30 18:51:17 UTC (rev 59740)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/6.7 2025-01-30 20:42:03 UTC (rev 59741)
</ins><a id="branches67"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/6.7</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43785,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44231-44232,44235,44248,44284,44287-44288
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.5:49373-49379,49381
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.8:51889
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:58570,59279-59280,59283,59286,59289-59290,59293,59306-59307,59314-59319,59325-59326,59329-59330,59339,59341,59344,59346-59348,59358,59362,59366,59368,59374,59379-59380,59382,59386,59391-59392,59398-59399,59407,59409-59410,59413-59416,59422,59424,59426-59427,59430-59431,59448,59451,59454,59464,59482,59510,59580,59682,59730
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:58570,59279-59280,59283,59286,59289-59290,59293,59306-59307,59314-59319,59325-59326,59329-59330,59339,59341,59344,59346-59348,59358,59362,59366,59368,59374,59379-59380,59382,59386,59391-59392,59398-59399,59407,59409-59410,59413-59416,59422,59424,59426-59427,59430-59431,59448,59451,59454,59464,59482,59510,59536,59540,59580,59682,59730
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches67srcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.7/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.7/src/wp-includes/script-loader.php 2025-01-30 18:51:17 UTC (rev 59740)
+++ branches/6.7/src/wp-includes/script-loader.php 2025-01-30 20:42:03 UTC (rev 59741)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,8 +106,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $vendor_scripts_versions = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'react' => '18.3.1',
- 'react-dom' => '18.3.1',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'react' => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
+ 'react-dom' => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'react-jsx-runtime' => '18.3.1',
</span><span class="cx" style="display: block; padding: 0 10px"> 'regenerator-runtime' => '0.14.1',
</span><span class="cx" style="display: block; padding: 0 10px"> 'moment' => '2.30.1',
</span></span></pre></div>
<a id="branches67testsphpunittestsdependenciesscriptsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.7/tests/phpunit/tests/dependencies/scripts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.7/tests/phpunit/tests/dependencies/scripts.php 2025-01-30 18:51:17 UTC (rev 59740)
+++ branches/6.7/tests/phpunit/tests/dependencies/scripts.php 2025-01-30 20:42:03 UTC (rev 59741)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3413,6 +3413,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $handle = $script;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * Append '.1' to the version number for React and ReactDOM.
+ *
+ * This is due to a change in the build to use the UMD version of the
+ * scripts, requiring a different version number in order to break the
+ * caches of some CDNs.
+ *
+ * This can be removed in the next update to the packages.
+ *
+ * See https://core.trac.wordpress.org/ticket/62422
+ */
+ if ( in_array( $handle, array( 'react', 'react-dom' ), true ) ) {
+ $package_json[ $script ] .= '.1';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $script_query = $wp_scripts->query( $handle, 'registered' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertNotFalse( $script_query, "The script '{$handle}' should be registered." );
</span></span></pre>
</div>
</div>
</body>
</html>