<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59677] trunk: Formatting: Preserve `target="_blank"` in Biographical Info and Category Description.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59677">59677</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59677","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>audrasjb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-01-21 22:57:04 +0000 (Tue, 21 Jan 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Formatting: Preserve `target="_blank"` in Biographical Info and Category Description.
This changeset ensures the `target="_blank"` attribute is preserved when adding links in the Biographical Info and Category Description fields. Previously, this attribute was being stripped by the KSES sanitization process.
Additionally, new unit tests have been added to verify the preservation of the `target="_blank"` attribute in these specific contexts.
Props lovewpmu, miqrogroove, bsutcliffe, sjefen6, nofearinc, nacin, harmr, blogitsolutions, stefahn, nirajgirixd, martinkrcho, spacedmonkey, sukhendu2002, audrasjb, gaellebesson, nuryko, guillaumeturpin, maximemeganck, ranafge, azaozz, joedolson, rinkalpagdar, mikinc860.
Fixes <a href="https://core.trac.wordpress.org/ticket/12056">#12056</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesksesphp">trunk/src/wp-includes/kses.php</a></li>
<li><a href="#trunktestsphpunittestsksesphp">trunk/tests/phpunit/tests/kses.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesksesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/kses.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/kses.php 2025-01-21 22:36:50 UTC (rev 59676)
+++ trunk/src/wp-includes/kses.php 2025-01-21 22:57:04 UTC (rev 59677)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -895,9 +895,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $tags;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> case 'user_description':
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ case 'pre_term_description':
</ins><span class="cx" style="display: block; padding: 0 10px"> case 'pre_user_description':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $tags = $allowedtags;
- $tags['a']['rel'] = true;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $tags = $allowedtags;
+ $tags['a']['rel'] = true;
+ $tags['a']['target'] = true;
</ins><span class="cx" style="display: block; padding: 0 10px"> /** This filter is documented in wp-includes/kses.php */
</span><span class="cx" style="display: block; padding: 0 10px"> return apply_filters( 'wp_kses_allowed_html', $tags, $context );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsksesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/kses.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/kses.php 2025-01-21 22:36:50 UTC (rev 59676)
+++ trunk/tests/phpunit/tests/kses.php 2025-01-21 22:57:04 UTC (rev 59677)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2244,4 +2244,76 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->text_array_to_dataprovider( $required_kses_globals );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Tests that the target attribute is preserved in various contexts.
+ *
+ * @dataProvider data_target_attribute_preserved_in_descriptions
+ *
+ * @ticket 12056
+ *
+ * @param string $context The context to test ('user_description' or 'pre_term_description').
+ * @param string $input The input HTML string.
+ * @param string $expected The expected output HTML string.
+ */
+ public function test_target_attribute_preserved_in_context( $context, $input, $expected ) {
+ $allowed = wp_kses_allowed_html( $context );
+ $this->assertTrue( isset( $allowed['a']['target'] ), "Target attribute not allowed in {$context}" );
+ $this->assertEquals( $expected, wp_kses( $input, $context ) );
+ }
+
+ /**
+ * Data provider for test_target_attribute_preserved_in_context.
+ *
+ * @return array
+ */
+ public function data_target_attribute_preserved_in_descriptions() {
+ return array(
+ array(
+ 'user_description',
+ '<a href="https://example.com" target="_blank">Example</a>',
+ '<a href="https://example.com" target="_blank">Example</a>',
+ ),
+ array(
+ 'pre_term_description',
+ '<a href="https://example.com" target="_blank">Example</a>',
+ '<a href="https://example.com" target="_blank">Example</a>',
+ ),
+ );
+ }
+
+ /**
+ * Tests that specific attributes are preserved in various contexts.
+ *
+ * @dataProvider data_allowed_attributes_in_descriptions
+ *
+ * @ticket 12056
+ *
+ * @param string $context The context to test ('user_description' or 'pre_term_description').
+ * @param array $attributes List of attributes to check for.
+ */
+ public function test_specific_attributes_preserved_in_context( $context, $attributes ) {
+ $allowed = wp_kses_allowed_html( $context );
+ foreach ( $attributes as $attribute ) {
+ $this->assertTrue( isset( $allowed['a'][ $attribute ] ), "{$attribute} attribute not allowed in {$context}" );
+ }
+ }
+
+ /**
+ * Data provider for test_specific_attributes_preserved_in_context.
+ *
+ * @return array
+ */
+ public function data_allowed_attributes_in_descriptions() {
+ return array(
+ array(
+ 'user_description',
+ array( 'target', 'href', 'rel' ),
+ ),
+ array(
+ 'pre_term_description',
+ array( 'target', 'href', 'rel' ),
+ ),
+ );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>