<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59280] trunk: Build/Test Tools: Test against MySQL 8.4 in automated testing.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59280">59280</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59280","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-10-23 00:13:07 +0000 (Wed, 23 Oct 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Test against MySQL 8.4 in automated testing.
Additionally, MySQL 8.1, 8.2 and 8.3 have been removed. These were {U+201C}innovation releases{U+201D} and are no longer supported in favor of 8.4, which has LTS.
Props ayeshrajans, johnbillion, aristath, jorbin.
See <a href="https://core.trac.wordpress.org/ticket/61218">#61218</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowsinstalltestingyml">trunk/.github/workflows/install-testing.yml</a></li>
<li><a href="#trunkgithubworkflowsphpunittestsyml">trunk/.github/workflows/phpunit-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsreusableupgradetestingyml">trunk/.github/workflows/reusable-upgrade-testing.yml</a></li>
<li><a href="#trunkgithubworkflowsupgradetestingyml">trunk/.github/workflows/upgrade-testing.yml</a></li>
<li><a href="#trunkversionsupportmysqljson">trunk/.version-support-mysql.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowsinstalltestingyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/install-testing.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/install-testing.yml 2024-10-23 00:05:55 UTC (rev 59279)
+++ trunk/.github/workflows/install-testing.yml 2024-10-23 00:13:07 UTC (rev 59280)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -125,6 +125,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - db-version: '5.0'
</span><span class="cx" style="display: block; padding: 0 10px"> - db-version: '5.1'
</span><span class="cx" style="display: block; padding: 0 10px"> - db-version: '5.5'
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - php: '7.2'
+ db-version: '8.4'
+ - php: '7.3'
+ db-version: '8.4'
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> services:
</span><span class="cx" style="display: block; padding: 0 10px"> database:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,13 +137,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - 3306
</span><span class="cx" style="display: block; padding: 0 10px"> options: >-
</span><span class="cx" style="display: block; padding: 0 10px"> --health-cmd="mysqladmin ping"
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- --health-interval=30s
- --health-timeout=10s
- --health-retries=5
- -e MYSQL_ROOT_PASSWORD=root
- -e MYSQL_DATABASE=test_db
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ --health-interval="30s"
+ --health-timeout="10s"
+ --health-retries="5"
+ -e MYSQL_ROOT_PASSWORD="root"
+ -e MYSQL_DATABASE="test_db"
</ins><span class="cx" style="display: block; padding: 0 10px"> --entrypoint sh ${{ matrix.db-type }}:${{ matrix.db-version }}
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- -c "exec docker-entrypoint.sh mysqld${{ matrix.db-version != '5.5' && ' --default-authentication-plugin=mysql_native_password"' || '' }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ -c "exec docker-entrypoint.sh mysqld${{ matrix.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), matrix.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Set up PHP ${{ matrix.php }}
</span></span></pre></div>
<a id="trunkgithubworkflowsphpunittestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/phpunit-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/phpunit-tests.yml 2024-10-23 00:05:55 UTC (rev 59279)
+++ trunk/.github/workflows/phpunit-tests.yml 2024-10-23 00:13:07 UTC (rev 59280)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -47,7 +47,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ ubuntu-latest ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> tests-domain: [ 'example.org' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><span class="cx" style="display: block; padding: 0 10px"> memcached: [ false ]
</span></span></pre></div>
<a id="trunkgithubworkflowsreusableupgradetestingyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/reusable-upgrade-testing.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/reusable-upgrade-testing.yml 2024-10-23 00:05:55 UTC (rev 59279)
+++ trunk/.github/workflows/reusable-upgrade-testing.yml 2024-10-23 00:13:07 UTC (rev 59280)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,8 +58,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> image: ${{ inputs.db-type }}:${{ inputs.db-version }}
</span><span class="cx" style="display: block; padding: 0 10px"> ports:
</span><span class="cx" style="display: block; padding: 0 10px"> - 3306
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- options: --health-cmd="mysqladmin ping" --health-interval=30s --health-timeout=10s --health-retries=5 -e MYSQL_ROOT_PASSWORD=root -e MYSQL_DATABASE=test_db --entrypoint sh ${{ inputs.db-type }}:${{ inputs.db-version }} -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ options: >-
+ --health-cmd="mysqladmin ping"
+ --health-interval="30s"
+ --health-timeout="10s"
+ --health-retries="5"
+ -e MYSQL_ROOT_PASSWORD="root"
+ -e MYSQL_DATABASE="test_db"
+ --entrypoint sh ${{ inputs.db-type }}:${{ inputs.db-version }}
+ -c "exec docker-entrypoint.sh mysqld${{ inputs.db-type == 'mysql' && contains( fromJSON('["7.2", "7.3"]'), inputs.php ) && ' --default-authentication-plugin=mysql_native_password' || '' }}"
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Set up PHP ${{ inputs.php }}
</span><span class="cx" style="display: block; padding: 0 10px"> uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
</span></span></pre></div>
<a id="trunkgithubworkflowsupgradetestingyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/upgrade-testing.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/upgrade-testing.yml 2024-10-23 00:05:55 UTC (rev 59279)
+++ trunk/.github/workflows/upgrade-testing.yml 2024-10-23 00:13:07 UTC (rev 59280)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,9 +45,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> wp: [ '6.0', '6.1', '6.2', '6.3', '6.4', '6.5', '6.6', '6.7-RC1' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ exclude:
+ - php: '7.2'
+ db-version: '8.4'
+ - php: '7.3'
+ db-version: '8.4'
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> os: ${{ matrix.os }}
</span><span class="cx" style="display: block; padding: 0 10px"> php: ${{ matrix.php }}
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,9 +74,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '7.2', '7.3', '7.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> wp: [ '5.0', '5.1', '5.2', '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ exclude:
+ - php: '7.2'
+ db-version: '8.4'
+ - php: '7.3'
+ db-version: '8.4'
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> os: ${{ matrix.os }}
</span><span class="cx" style="display: block; padding: 0 10px"> php: ${{ matrix.php }}
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,7 +107,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> wp: [ '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -118,9 +130,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '7.2', '7.3', '7.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> wp: [ '4.1', '4.2', '4.3', '4.4', '4.5', '4.6', '4.7', '4.8', '4.9' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ exclude:
+ - php: '7.2'
+ db-version: '8.4'
+ - php: '7.3'
+ db-version: '8.4'
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> os: ${{ matrix.os }}
</span><span class="cx" style="display: block; padding: 0 10px"> php: ${{ matrix.php }}
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -145,7 +163,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><span class="cx" style="display: block; padding: 0 10px"> php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- db-version: [ '5.7', '8.0' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ db-version: [ '5.7', '8.0', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> wp: [ '4.1', '4.2', '4.3', '4.4', '4.5' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span></span></pre></div>
<a id="trunkversionsupportmysqljson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.version-support-mysql.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.version-support-mysql.json 2024-10-23 00:05:55 UTC (rev 59279)
+++ trunk/.version-support-mysql.json 2024-10-23 00:13:07 UTC (rev 59280)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,8 +1,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> {
</span><span class="cx" style="display: block; padding: 0 10px"> "6-8": [
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "8.3",
- "8.2",
- "8.1",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "8.4",
</ins><span class="cx" style="display: block; padding: 0 10px"> "8.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "5.7",
</span><span class="cx" style="display: block; padding: 0 10px"> "5.6",
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -9,9 +7,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "5.5"
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="cx" style="display: block; padding: 0 10px"> "6-7": [
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "8.3",
- "8.2",
- "8.1",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "8.4",
</ins><span class="cx" style="display: block; padding: 0 10px"> "8.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "5.7",
</span><span class="cx" style="display: block; padding: 0 10px"> "5.6",
</span></span></pre>
</div>
</div>
</body>
</html>