<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[59168] trunk: Build/Test Tools: Enable testing for PHP 8.4.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/59168">59168</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/59168","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-10-04 14:07:03 +0000 (Fri, 04 Oct 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Enable testing for PHP 8.4.
With PHP 8.4 due out in November later this year, contributors have been working on ensuring WordPress 6.7 is as compatible as possible. Enough progress has been made during this release cycle where PHPUnit tests now run successfully with no failures reported.
This change enables PHP 8.4 testing throughout Core's GitHub Action workflows to ensure no new problems are introduced going forward.
There are two exceptions to this:
- The Importer plugin has some compatibility issues that produce test failures. There is an open pull request upstream, but these problematic tests have been marked skipped when running on PHP 8.4 until that PR is merged.
- Since no stable versions of xDebug with PHP 8.4 support have been published, these tests are also skipped for now.
Props jrf, desrosj.
See <a href="https://core.trac.wordpress.org/ticket/62061">#62061</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowsphpunittestsyml">trunk/.github/workflows/phpunit-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsreusablephpunittestsv3yml">trunk/.github/workflows/reusable-phpunit-tests-v3.yml</a></li>
<li><a href="#trunkgithubworkflowsupgradetestingyml">trunk/.github/workflows/upgrade-testing.yml</a></li>
<li><a href="#trunkversionsupportphpjson">trunk/.version-support-php.json</a></li>
<li><a href="#trunktestsphpunittestsimportparserphp">trunk/tests/phpunit/tests/import/parser.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowsphpunittestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/phpunit-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/phpunit-tests.yml 2024-10-04 13:22:38 UTC (rev 59167)
+++ trunk/.github/workflows/phpunit-tests.yml 2024-10-04 14:07:03 UTC (rev 59168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,7 +45,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ ubuntu-latest ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-version: [ '5.7', '8.0', '8.1', '8.2', '8.3' ]
</span><span class="cx" style="display: block; padding: 0 10px"> tests-domain: [ 'example.org' ]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -116,7 +116,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ ubuntu-latest ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mariadb' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-version: [ '10.4', '10.6', '10.11', '11.2' ]
</span><span class="cx" style="display: block; padding: 0 10px"> multisite: [ false, true ]
</span></span></pre></div>
<a id="trunkgithubworkflowsreusablephpunittestsv3yml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/reusable-phpunit-tests-v3.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/reusable-phpunit-tests-v3.yml 2024-10-04 13:22:38 UTC (rev 59167)
+++ trunk/.github/workflows/reusable-phpunit-tests-v3.yml 2024-10-04 14:07:03 UTC (rev 59168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -182,7 +182,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # __fakegroup__ is excluded to force PHPUnit to ignore the <exclude> settings in phpunit.xml.dist.
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Run (Xdebug) tests
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ inputs.php != '8.3' }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ inputs.php != '8.4' }}
</ins><span class="cx" style="display: block; padding: 0 10px"> continue-on-error: ${{ inputs.allow-errors }}
</span><span class="cx" style="display: block; padding: 0 10px"> run: LOCAL_PHP_XDEBUG=true node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit -v --group xdebug --exclude-group __fakegroup__
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgithubworkflowsupgradetestingyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/upgrade-testing.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/upgrade-testing.yml 2024-10-04 13:22:38 UTC (rev 59167)
+++ trunk/.github/workflows/upgrade-testing.yml 2024-10-04 14:07:03 UTC (rev 59168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,7 +43,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-version: [ '5.7', '8.0' ]
</span><span class="cx" style="display: block; padding: 0 10px"> wp: [ '6.0', '6.1', '6.2', '6.3', '6.4', '6.5', '6.6' ]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -93,7 +93,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: [ '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-version: [ '5.7', '8.0' ]
</span><span class="cx" style="display: block; padding: 0 10px"> wp: [ '5.3', '5.4', '5.5', '5.6', '5.7', '5.8', '5.9' ]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -143,7 +143,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><span class="cx" style="display: block; padding: 0 10px"> os: [ 'ubuntu-latest' ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: [ '8.0', '8.1', '8.2', '8.3' ]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: [ '8.0', '8.1', '8.2', '8.3', '8.4' ]
</ins><span class="cx" style="display: block; padding: 0 10px"> db-type: [ 'mysql' ]
</span><span class="cx" style="display: block; padding: 0 10px"> db-version: [ '5.7', '8.0' ]
</span><span class="cx" style="display: block; padding: 0 10px"> wp: [ '4.1', '4.2', '4.3', '4.4', '4.5' ]
</span></span></pre></div>
<a id="trunkversionsupportphpjson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.version-support-php.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.version-support-php.json 2024-10-04 13:22:38 UTC (rev 59167)
+++ trunk/.version-support-php.json 2024-10-04 14:07:03 UTC (rev 59168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,7 +6,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "8.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "8.1",
</span><span class="cx" style="display: block; padding: 0 10px"> "8.2",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "8.3"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "8.3",
+ "8.4"
</ins><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="cx" style="display: block; padding: 0 10px"> "6-6": [
</span><span class="cx" style="display: block; padding: 0 10px"> "7.2",
</span></span></pre></div>
<a id="trunktestsphpunittestsimportparserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/import/parser.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/import/parser.php 2024-10-04 13:22:38 UTC (rev 59167)
+++ trunk/tests/phpunit/tests/import/parser.php 2024-10-04 14:07:03 UTC (rev 59168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,6 +25,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers WXR_Parser_XML::parse
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_malformed_wxr() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( PHP_VERSION_ID >= 80400 ) {
+ $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/malformed.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Regex based parser cannot detect malformed XML.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,6 +46,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers WXR_Parser_Regex::parse
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_invalid_wxr() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( PHP_VERSION_ID >= 80400 ) {
+ $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $f1 = DIR_TESTDATA . '/export/missing-version-tag.xml';
</span><span class="cx" style="display: block; padding: 0 10px"> $f2 = DIR_TESTDATA . '/export/invalid-version-tag.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -61,6 +69,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers WXR_Parser_Regex::parse
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wxr_version_1_1() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( PHP_VERSION_ID >= 80400 ) {
+ $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/valid-wxr-1.1.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( array( 'WXR_Parser_SimpleXML', 'WXR_Parser_XML', 'WXR_Parser_Regex' ) as $p ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -159,6 +171,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers WXR_Parser_Regex::parse
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wxr_version_1_0() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( PHP_VERSION_ID >= 80400 ) {
+ $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/valid-wxr-1.0.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( array( 'WXR_Parser_SimpleXML', 'WXR_Parser_XML', 'WXR_Parser_Regex' ) as $p ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -257,6 +273,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers WXR_Parser_Regex::parse
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_escaped_cdata_closing_sequence() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( PHP_VERSION_ID >= 80400 ) {
+ $this->markTestSkipped( 'The Importer plugin is not ready for PHP 8.4 yet. This skip should be removed once it is.' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/crazy-cdata-escaped.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( array( 'WXR_Parser_SimpleXML', 'WXR_Parser_XML', 'WXR_Parser_Regex' ) as $p ) {
</span></span></pre>
</div>
</div>
</body>
</html>