<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58877] trunk/src/wp-includes/html-api/class-wp-html-processor.php: HTML API: Remove completed TODO comments.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58877">58877</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58877","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dmsnell</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-08-10 04:58:16 +0000 (Sat, 10 Aug 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>HTML API: Remove completed TODO comments.
This patch removes TODO comments indicating the need to verify certain behaviors and algorithms. Those verifications have taken place and the comments are no longer needed.
Developed in https://github.com/wordpress/wordpress-develop/pull/7174
Discussed in https://core.trac.wordpress.org/ticket/61646
Follow-up to <a href="https://core.trac.wordpress.org/changeset/58867">[58867]</a>, <a href="https://core.trac.wordpress.org/changeset/58870">[58870]</a>.
Props jonsurrell.
See <a href="https://core.trac.wordpress.org/ticket/64646">#64646</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludeshtmlapiclasswphtmlprocessorphp">trunk/src/wp-includes/html-api/class-wp-html-processor.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludeshtmlapiclasswphtmlprocessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/html-api/class-wp-html-processor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-08-09 18:29:47 UTC (rev 58876)
+++ trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-08-10 04:58:16 UTC (rev 58877)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -775,9 +775,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * foreign content will also act just like a void tag, immediately
</span><span class="cx" style="display: block; padding: 0 10px"> * closing as soon as the processor advances to the next token.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @todo Review the self-closing logic when no node is present, ensure it
- * matches the expectations in `step()`.
- *
</del><span class="cx" style="display: block; padding: 0 10px"> * @since 6.6.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_HTML_Token|null $node Optional. Node to examine, if provided.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3317,12 +3314,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TBODY':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TFOOT':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-THEAD':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * @todo This needs to check if the element in scope is an HTML element, meaning that
- * when SVG and MathML support is added, this needs to differentiate between an
- * HTML element of the given name, such as `<center>`, and a foreign element of
- * the same given name.
- */
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->state->stack_of_open_elements->has_element_in_table_scope( $tag_name ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Parse error: ignore the token.
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->step();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3453,12 +3444,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TBODY':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TFOOT':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-THEAD':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * @todo This needs to check if the element in scope is an HTML element, meaning that
- * when SVG and MathML support is added, this needs to differentiate between an
- * HTML element of the given name, such as `<center>`, and a foreign element of
- * the same given name.
- */
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->state->stack_of_open_elements->has_element_in_table_scope( $tag_name ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Parse error: ignore the token.
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->step();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3521,12 +3506,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TD':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TH':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * @todo This needs to check if the element in scope is an HTML element, meaning that
- * when SVG and MathML support is added, this needs to differentiate between an
- * HTML element of the given name, such as `<center>`, and a foreign element of
- * the same given name.
- */
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->state->stack_of_open_elements->has_element_in_table_scope( $tag_name ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Parse error: ignore the token.
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->step();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3590,12 +3569,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TFOOT':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-THEAD':
</span><span class="cx" style="display: block; padding: 0 10px"> case '-TR':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * @todo This needs to check if the element in scope is an HTML element, meaning that
- * when SVG and MathML support is added, this needs to differentiate between an
- * HTML element of the given name, such as `<center>`, and a foreign element of
- * the same given name.
- */
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->state->stack_of_open_elements->has_element_in_table_scope( $tag_name ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Parse error: ignore the token.
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->step();
</span></span></pre>
</div>
</div>
</body>
</html>