<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58775] trunk/tools/webpack: Build Tools: Use umd builds provided by React instead of bundling our own builds.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58775">58775</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58775","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>youknowriad</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-07-22 10:00:09 +0000 (Mon, 22 Jul 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build Tools: Use umd builds provided by React instead of bundling our own builds.
We tried moving away from the deprecated React UMD builds previously,
the problem we faced is that there's a warning that is triggered on the console because we're not using a separate impact for `createRoot`.
This warning has been removed in React 19 along with the removal of the UMD builds, so we should be able to revert this commit when we upgrade to React 19 but for now, we need to restore the usage of the umd builds.
Props mamaduka.
See <a href="https://core.trac.wordpress.org/ticket/61324">#61324</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktoolswebpackpackagesjs">trunk/tools/webpack/packages.js</a></li>
<li><a href="#trunktoolswebpackvendorsjs">trunk/tools/webpack/vendors.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktoolswebpackpackagesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tools/webpack/packages.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tools/webpack/packages.js 2024-07-21 18:56:45 UTC (rev 58774)
+++ trunk/tools/webpack/packages.js 2024-07-22 10:00:09 UTC (rev 58775)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -96,6 +96,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-importmap.js': 'es-module-shims/dist/es-module-shims.wasm.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'moment.js': 'moment/moment.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'regenerator-runtime.js': 'regenerator-runtime/runtime.js',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'react.js': 'react/umd/react.development.js',
+ 'react-dom.js': 'react-dom/umd/react-dom.development.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const minifiedVendors = {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -109,6 +111,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'objectFitPolyfill/dist/objectFitPolyfill.min.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-inert.min.js': 'wicg-inert/dist/inert.min.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'moment.min.js': 'moment/min/moment.min.js',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'react.min.js': 'react/umd/react.production.min.js',
+ 'react-dom.min.js': 'react-dom/umd/react-dom.production.min.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const minifyVendors = {
</span></span></pre></div>
<a id="trunktoolswebpackvendorsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tools/webpack/vendors.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tools/webpack/vendors.js 2024-07-21 18:56:45 UTC (rev 58774)
+++ trunk/tools/webpack/vendors.js 2024-07-22 10:00:09 UTC (rev 58775)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4,8 +4,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> const { join } = require( 'path' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const importedVendors = {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- react: { import: 'react', global: 'React' },
- 'react-dom': { import: 'react-dom', global: 'ReactDOM' },
</del><span class="cx" style="display: block; padding: 0 10px"> 'react-jsx-runtime': {
</span><span class="cx" style="display: block; padding: 0 10px"> import: 'react/jsx-runtime',
</span><span class="cx" style="display: block; padding: 0 10px"> global: 'ReactJSXRuntime',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,7 +19,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> : mode === 'production'
</span><span class="cx" style="display: block; padding: 0 10px"> ? 'build'
</span><span class="cx" style="display: block; padding: 0 10px"> : 'src';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- buildTarget = buildTarget + '/wp-includes/js/dist/vendor/';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ buildTarget = buildTarget + '/wp-includes/js/dist/vendor/';
</ins><span class="cx" style="display: block; padding: 0 10px"> return [
</span><span class="cx" style="display: block; padding: 0 10px"> ...Object.entries( importedVendors ).flatMap( ( [ name, config ] ) => {
</span><span class="cx" style="display: block; padding: 0 10px"> return [ 'production', 'development' ].map( ( currentMode ) => {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,12 +43,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- externals:
- name === 'react'
- ? {}
- : {
- react: 'React',
- },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ externals: {
+ react: 'React',
+ },
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } ),
</span></span></pre>
</div>
</div>
</body>
</html>