<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58455] trunk/src/js/_enqueues: Administration: A11y: Add `role="alert"` on JS injected admin notices.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58455">58455</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58455","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-06-21 18:15:50 +0000 (Fri, 21 Jun 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Administration: A11y: Add `role="alert"` on JS injected admin notices.
Add the attribute `role="alert"` on 12 instances of admin notices that are injected into the DOM using JavaScript. The `role="alert"` attribute allows screen readers to recognize the addition to the DOM and announce the errors to users.
Props afercia, cyrus11, rcreators, joedolson.
Fixes <a href="https://core.trac.wordpress.org/ticket/47111">#47111</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminprivacytoolsjs">trunk/src/js/_enqueues/admin/privacy-tools.js</a></li>
<li><a href="#trunksrcjs_enqueuesadminuserprofilejs">trunk/src/js/_enqueues/admin/user-profile.js</a></li>
<li><a href="#trunksrcjs_enqueueslibajaxresponsejs">trunk/src/js/_enqueues/lib/ajax-response.js</a></li>
<li><a href="#trunksrcjs_enqueueswpcustomizewidgetsjs">trunk/src/js/_enqueues/wp/customize/widgets.js</a></li>
<li><a href="#trunksrcjs_enqueueswpupdatesjs">trunk/src/js/_enqueues/wp/updates.js</a></li>
<li><a href="#trunksrcjs_enqueueswpwidgetscustomhtmljs">trunk/src/js/_enqueues/wp/widgets/custom-html.js</a></li>
<li><a href="#trunksrcjs_enqueueswpwidgetsmediajs">trunk/src/js/_enqueues/wp/widgets/media.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminprivacytoolsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/privacy-tools.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/privacy-tools.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/admin/privacy-tools.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -47,7 +47,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $requestRow.after( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> return '<tr class="' + resultRowClasses + '"><th colspan="5">' +
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<div class="notice inline notice-alt ' + classes + '">' +
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<div class="notice inline notice-alt ' + classes + '" role="alert">' +
</ins><span class="cx" style="display: block; padding: 0 10px"> '<p>' + summaryMessage + '</p>' +
</span><span class="cx" style="display: block; padding: 0 10px"> itemList +
</span><span class="cx" style="display: block; padding: 0 10px"> '</div>' +
</span></span></pre></div>
<a id="trunksrcjs_enqueuesadminuserprofilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/user-profile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/user-profile.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/admin/user-profile.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -151,7 +151,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {string} message The message to insert.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function addInlineNotice( $this, success, message ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var resultDiv = $( '<div />' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var resultDiv = $( '<div />', {
+ role: 'alert'
+ } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set up the notice div.
</span><span class="cx" style="display: block; padding: 0 10px"> resultDiv.addClass( 'notice inline' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -474,10 +476,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }).done( function( response ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this.prop( 'disabled', true );
</span><span class="cx" style="display: block; padding: 0 10px"> $this.siblings( '.notice' ).remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this.before( '<div class="notice notice-success inline"><p>' + response.message + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this.before( '<div class="notice notice-success inline" role="alert"><p>' + response.message + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }).fail( function( response ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this.siblings( '.notice' ).remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this.before( '<div class="notice notice-error inline"><p>' + response.message + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this.before( '<div class="notice notice-error inline" role="alert"><p>' + response.message + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> e.preventDefault();
</span></span></pre></div>
<a id="trunksrcjs_enqueueslibajaxresponsejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/lib/ajax-response.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/lib/ajax-response.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/lib/ajax-response.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -53,10 +53,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> parsed.responses.push( response );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( err.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- re.html( '<div class="notice notice-error">' + err + '</div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ re.html( '<div class="notice notice-error" role="alert">' + err + '</div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> wp.a11y.speak( err );
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( noticeMessage.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- re.html( '<div class="notice notice-success is-dismissible"><p>' + noticeMessage + '</p></div>');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ re.html( '<div class="notice notice-success is-dismissible" role="alert"><p>' + noticeMessage + '</p></div>');
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery(document).trigger( 'wp-updates-notice-added' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp.a11y.speak( noticeMessage );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,15 +64,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isNaN( x ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp.a11y.speak( x );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return ! re.html( '<div class="notice notice-error"><p>' + x + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return ! re.html( '<div class="notice notice-error" role="alert"><p>' + x + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> x = parseInt( x, 10 );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( -1 === x ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp.a11y.speak( wpAjax.noPerm );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return ! re.html( '<div class="notice notice-error"><p>' + wpAjax.noPerm + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return ! re.html( '<div class="notice notice-error" role="alert"><p>' + wpAjax.noPerm + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else if ( 0 === x ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp.a11y.speak( wpAjax.broken );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return ! re.html( '<div class="notice notice-error"><p>' + wpAjax.broken + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return ! re.html( '<div class="notice notice-error" role="alert"><p>' + wpAjax.broken + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpcustomizewidgetsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/customize/widgets.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/customize/widgets.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/wp/customize/widgets.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1623,7 +1623,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // @todo This should use the Notifications API introduced to panels. See <https://core.trac.wordpress.org/ticket/38794>.
</span><span class="cx" style="display: block; padding: 0 10px"> noticeContainer = $( '<div></div>', {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'class': 'no-widget-areas-rendered-notice'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'class': 'no-widget-areas-rendered-notice',
+ 'role': 'alert'
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> panelMetaContainer.append( noticeContainer );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpupdatesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/updates.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/updates.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/wp/updates.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -875,7 +875,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $card
</span><span class="cx" style="display: block; padding: 0 10px"> .addClass( 'plugin-card-update-failed' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .append( '<div class="notice notice-error notice-alt is-dismissible"><p>' + errorMessage + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .append( '<div class="notice notice-error notice-alt is-dismissible" role="alert"><p>' + errorMessage + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $card.on( 'click', '.notice.is-dismissible .notice-dismiss', function() {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2260,7 +2260,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Remove any existing error.
</span><span class="cx" style="display: block; padding: 0 10px"> $filesystemForm.find( '.notice' ).remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $filesystemForm.find( '#request-filesystem-credentials-title' ).after( '<div class="notice notice-alt notice-error"><p>' + message + '</p></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $filesystemForm.find( '#request-filesystem-credentials-title' ).after( '<div class="notice notice-alt notice-error" role="alert"><p>' + message + '</p></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpwidgetscustomhtmljs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/widgets/custom-html.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/widgets/custom-html.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/wp/widgets/custom-html.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -148,7 +148,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( 0 !== errorAnnotations.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- errorNotice = $( '<div class="inline notice notice-error notice-alt"></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ errorNotice = $( '<div class="inline notice notice-error notice-alt" role="alert"></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> errorNotice.append( $( '<p></p>', {
</span><span class="cx" style="display: block; padding: 0 10px"> text: message
</span><span class="cx" style="display: block; padding: 0 10px"> } ) );
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpwidgetsmediajs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/widgets/media.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/widgets/media.js 2024-06-21 17:24:39 UTC (rev 58454)
+++ trunk/src/js/_enqueues/wp/widgets/media.js 2024-06-21 18:15:50 UTC (rev 58455)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -158,7 +158,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! noticeContainer.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- noticeContainer = $( '<div class="media-widget-embed-notice notice notice-error notice-alt"></div>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ noticeContainer = $( '<div class="media-widget-embed-notice notice notice-error notice-alt" role="alert"></div>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> noticeContainer.hide();
</span><span class="cx" style="display: block; padding: 0 10px"> embedLinkView.views.parent.$el.prepend( noticeContainer );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>