<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58405] trunk/src: Administration: A11y: Add visible labels in theme UI.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58405">58405</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58405","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-06-13 13:55:46 +0000 (Thu, 13 Jun 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Administration: A11y: Add visible labels in theme UI.
Finish task to replace placeholders used for labels with visible label elements. Add label elements in theme browser and theme installation screen. Change position of search input to match other user interfaces in WordPress.
Also crediting all contributors to ticket <a href="https://core.trac.wordpress.org/ticket/61389">#61389</a>, which this also closes.
Props joedolson, rcreators, sabernhardt, balub, rejaulalomkhan, syamraj24, nazmul111, krupajnanda, huzaifaalmesbah, hmbashar, mdnesarmridha, colorful-tones, printsachen1.
Fixes <a href="https://core.trac.wordpress.org/ticket/40331">#40331</a>, <a href="https://core.trac.wordpress.org/ticket/61389">#61389</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueueswpthemejs">trunk/src/js/_enqueues/wp/theme.js</a></li>
<li><a href="#trunksrcwpadmincssthemescss">trunk/src/wp-admin/css/themes.css</a></li>
<li><a href="#trunksrcwpadminnetworksitethemesphp">trunk/src/wp-admin/network/site-themes.php</a></li>
<li><a href="#trunksrcwpadminnetworkthemesphp">trunk/src/wp-admin/network/themes.php</a></li>
<li><a href="#trunksrcwpadminthemeinstallphp">trunk/src/wp-admin/theme-install.php</a></li>
<li><a href="#trunksrcwpadminthemesphp">trunk/src/wp-admin/themes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueueswpthemejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/theme.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/theme.js 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/js/_enqueues/wp/theme.js 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -96,7 +96,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Defines search element container.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- searchContainer: $( '.search-form' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ searchContainer: $( '.search-form .search-box' ),
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Search input and view
</span><span class="cx" style="display: block; padding: 0 10px"> // for current theme collection.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -118,7 +118,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Render and append after screen title.
</span><span class="cx" style="display: block; padding: 0 10px"> view.render();
</span><span class="cx" style="display: block; padding: 0 10px"> this.searchContainer
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .append( $.parseHTML( '<label class="screen-reader-text" for="wp-filter-search-input">' + l10n.search + '</label>' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .append( $.parseHTML( '<label for="wp-filter-search-input">' + l10n.search + '</label>' ) )
</ins><span class="cx" style="display: block; padding: 0 10px"> .append( view.el )
</span><span class="cx" style="display: block; padding: 0 10px"> .on( 'submit', function( event ) {
</span><span class="cx" style="display: block; padding: 0 10px"> event.preventDefault();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1359,7 +1359,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> searching: false,
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> attributes: {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- placeholder: l10n.searchPlaceholder,
</del><span class="cx" style="display: block; padding: 0 10px"> type: 'search',
</span><span class="cx" style="display: block; padding: 0 10px"> 'aria-describedby': 'live-search-desc'
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span></span></pre></div>
<a id="trunksrcwpadmincssthemescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/themes.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/themes.css 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/wp-admin/css/themes.css 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,10 +19,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> clear: both;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.themes-php:not(.network-admin) .wrap h1 {
- margin-bottom: 15px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .themes-php .wrap h1 .button {
</span><span class="cx" style="display: block; padding: 0 10px"> margin-left: 20px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -29,13 +25,17 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Search form */
</span><span class="cx" style="display: block; padding: 0 10px"> .themes-php .search-form {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- display: inline;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: inline-flex;
+ align-items: center;
+ position: relative;
+ top: 0;
+ gap: .5rem;
+ width: 100%;
+ justify-content: end;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .themes-php .wp-filter-search {
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: -2px;
- left: 20px;
</del><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 280px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -955,11 +955,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> clear: both;
</span><span class="cx" style="display: block; padding: 0 10px"> left: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> right: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: -5px 0 20px;
</del><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> max-width: 280px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .theme-install-php .wp-filter p.search-box {
+ display: grid;
+ row-gap: .5rem;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .theme-browser .theme.add-new-theme span:after {
</span><span class="cx" style="display: block; padding: 0 10px"> font: normal 60px/90px dashicons;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 80px;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1029,6 +1033,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-left: 20px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Override column gap adjustment in media library. */
+@media only screen and (max-width: 1000px) {
+ .theme-install-php .wp-filter p.search-box {
+ column-gap: .5rem;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .theme-install-php a.upload,
</span><span class="cx" style="display: block; padding: 0 10px"> .theme-install-php a.browse-themes {
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: pointer;
</span></span></pre></div>
<a id="trunksrcwpadminnetworksitethemesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/network/site-themes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/network/site-themes.php 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/wp-admin/network/site-themes.php 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -237,7 +237,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php _e( 'Network enabled themes are not shown on this screen.' ); ?></p>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <form method="get">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php $wp_list_table->search_box( __( 'Search Installed Themes' ), 'theme' ); ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php $wp_list_table->search_box( __( 'Search installed themes' ), 'theme' ); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> <input type="hidden" name="id" value="<?php echo esc_attr( $id ); ?>" />
</span><span class="cx" style="display: block; padding: 0 10px"> </form>
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminnetworkthemesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/network/themes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/network/themes.php 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/wp-admin/network/themes.php 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -460,7 +460,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <form method="get">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php $wp_list_table->search_box( __( 'Search Installed Themes' ), 'theme' ); ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php $wp_list_table->search_box( __( 'Search installed themes' ), 'theme' ); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> </form>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunksrcwpadminthemeinstallphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/theme-install.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/theme-install.php 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/wp-admin/theme-install.php 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -56,7 +56,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'l10n' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'addNew' => __( 'Add New Theme' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'search' => __( 'Search Themes' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'searchPlaceholder' => __( 'Search themes...' ), // Placeholder (no ellipsis).
</del><span class="cx" style="display: block; padding: 0 10px"> 'upload' => __( 'Upload Theme' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'back' => __( 'Back' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'error' => sprintf(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -217,7 +216,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="button drawer-toggle" aria-expanded="false"><?php _e( 'Feature Filter' ); ?></button>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <form class="search-form"></form>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <form class="search-form"><p class="search-box"></p></form>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="favorites-form">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunksrcwpadminthemesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/themes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/themes.php 2024-06-13 13:52:06 UTC (rev 58404)
+++ trunk/src/wp-admin/themes.php 2024-06-13 13:55:46 UTC (rev 58405)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -232,8 +232,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'l10n' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'addNew' => __( 'Add New Theme' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'search' => __( 'Search Installed Themes' ),
- 'searchPlaceholder' => __( 'Search installed themes...' ), // Placeholder (no ellipsis).
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'search' => __( 'Search installed themes' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %d: Number of themes. */
</span><span class="cx" style="display: block; padding: 0 10px"> 'themesFound' => __( 'Number of Themes found: %d' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'noThemesFound' => __( 'No themes found. Try a different search.' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -252,14 +251,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <h1 class="wp-heading-inline"><?php esc_html_e( 'Themes' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="title-count theme-count"><?php echo ! empty( $_GET['search'] ) ? __( '…' ) : count( $themes ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> </h1>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><span class="cx" style="display: block; padding: 0 10px"> <?php if ( ! is_multisite() && current_user_can( 'install_themes' ) ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <a href="<?php echo esc_url( admin_url( 'theme-install.php' ) ); ?>" class="hide-if-no-js page-title-action"><?php echo esc_html__( 'Add New Theme' ); ?></a>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <hr class="wp-header-end">
+ <form class="search-form search-themes"><p class="search-box"></p></form>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <form class="search-form"></form>
-
- <hr class="wp-header-end">
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! validate_current_theme() || isset( $_GET['broken'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_admin_notice(
</span></span></pre>
</div>
</div>
</body>
</html>