<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58345] trunk/.github/workflows: Build/Test Tools: Simplify inputs for build process testing.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58345">58345</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58345","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-06-05 18:23:08 +0000 (Wed, 05 Jun 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Simplify inputs for build process testing.
This introduces a new input to separate the ability to save the built WordPress ZIP from generating the artifacts necessary for comments with Playground testing details.
The ZIP file is used by the performance testing workflow for performing comparisons, so it should be built and saved for every `push` event. The Playground related steps should only run on `pull_request`.
Follow up to <a href="https://core.trac.wordpress.org/changeset/58274">[58274]</a>.
Props jorbin.
See <a href="https://core.trac.wordpress.org/ticket/59416">#59416</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowsreusabletestcorebuildprocessyml">trunk/.github/workflows/reusable-test-core-build-process.yml</a></li>
<li><a href="#trunkgithubworkflowstestbuildprocessesyml">trunk/.github/workflows/test-build-processes.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowsreusabletestcorebuildprocessyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/reusable-test-core-build-process.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/reusable-test-core-build-process.yml 2024-06-05 16:20:36 UTC (rev 58344)
+++ trunk/.github/workflows/reusable-test-core-build-process.yml 2024-06-05 18:23:08 UTC (rev 58345)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,6 +21,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> required: false
</span><span class="cx" style="display: block; padding: 0 10px"> type: 'boolean'
</span><span class="cx" style="display: block; padding: 0 10px"> default: true
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ save-build:
+ description: 'Whether to save a ZIP of built WordPress as an artifact.'
+ required: false
+ type: 'boolean'
+ default: false
</ins><span class="cx" style="display: block; padding: 0 10px"> prepare-playground:
</span><span class="cx" style="display: block; padding: 0 10px"> description: 'Whether to prepare the artifacts needed for Playground testing.'
</span><span class="cx" style="display: block; padding: 0 10px"> required: false
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -97,7 +102,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Upload ZIP as a GitHub Actions artifact
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ inputs.prepare-playground }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ inputs.save-build || inputs.prepare-playground }}
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> name: wordpress-build-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}
</span><span class="cx" style="display: block; padding: 0 10px"> path: wordpress.zip
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -104,7 +109,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if-no-files-found: error
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Save PR number
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ inputs.prepare-playground && github.repository == 'WordPress/wordpress-develop' && github.event_name == 'pull_request' }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ inputs.prepare-playground }}
</ins><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> mkdir -p ./pr-number
</span><span class="cx" style="display: block; padding: 0 10px"> echo ${{ github.event.number }} > ./pr-number/NR
</span></span></pre></div>
<a id="trunkgithubworkflowstestbuildprocessesyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-build-processes.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-build-processes.yml 2024-06-05 16:20:36 UTC (rev 58344)
+++ trunk/.github/workflows/test-build-processes.yml 2024-06-05 18:23:08 UTC (rev 58345)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -44,10 +44,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # Only prepare artifacts for Playground once.
</span><span class="cx" style="display: block; padding: 0 10px"> - os: ubuntu-latest
</span><span class="cx" style="display: block; padding: 0 10px"> directory: 'build'
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- prepare-playground: true
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ save-build: true
+ prepare-playground: ${{ github.event_name == 'pull_request' && true || '' }}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> os: ${{ matrix.os }}
</span><span class="cx" style="display: block; padding: 0 10px"> directory: ${{ matrix.directory }}
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ save-build: ${{ matrix.save-build && matrix.save-build || false }}
</ins><span class="cx" style="display: block; padding: 0 10px"> prepare-playground: ${{ matrix.prepare-playground && matrix.prepare-playground || false }}
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # Tests the WordPress Core build process on MacOS.
</span></span></pre>
</div>
</div>
</body>
</html>