<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58279] trunk/src: Media: Follow the "proximity of controls" accessibility guidelines in the multi-file uploader.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58279">58279</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58279","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>audrasjb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-06-02 08:35:30 +0000 (Sun, 02 Jun 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Follow the "proximity of controls" accessibility guidelines in the multi-file uploader.
This changeset updates the design of the Upload Media screen to stack progress bars below the file name. After the upload completes, Action buttons also stack below the file name.
Props afercia, rcreators.
Fixes <a href="https://core.trac.wordpress.org/ticket/60141">#60141</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesvendorpluploadhandlersjs">trunk/src/js/_enqueues/vendor/plupload/handlers.js</a></li>
<li><a href="#trunksrcwpadminasyncuploadphp">trunk/src/wp-admin/async-upload.php</a></li>
<li><a href="#trunksrcwpadmincssmediacss">trunk/src/wp-admin/css/media.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesvendorpluploadhandlersjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/vendor/plupload/handlers.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/vendor/plupload/handlers.js 2024-06-02 08:15:59 UTC (rev 58278)
+++ trunk/src/js/_enqueues/vendor/plupload/handlers.js 2024-06-02 08:35:30 UTC (rev 58279)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,8 +16,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( '<div class="media-item">' )
</span><span class="cx" style="display: block; padding: 0 10px"> .attr( 'id', 'media-item-' + fileObj.id )
</span><span class="cx" style="display: block; padding: 0 10px"> .addClass( 'child-of-' + postid )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .append( '<div class="progress"><div class="percent">0%</div><div class="bar"></div></div>',
- jQuery( '<div class="filename original">' ).text( ' ' + fileObj.name ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .append( jQuery( '<div class="filename original">' ).text( ' ' + fileObj.name ),
+ '<div class="progress"><div class="percent">0%</div><div class="bar"></div></div>' )
</ins><span class="cx" style="display: block; padding: 0 10px"> .appendTo( jQuery( '#media-items' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Disable submit.
</span></span></pre></div>
<a id="trunksrcwpadminasyncuploadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/async-upload.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/async-upload.php 2024-06-02 08:15:59 UTC (rev 58278)
+++ trunk/src/wp-admin/async-upload.php 2024-06-02 08:35:30 UTC (rev 58279)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,21 +65,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="filename new">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="media-list-title"><strong><?php echo esc_html( wp_html_excerpt( $title, 60, '…' ) ); ?></strong></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="media-list-subtitle"><?php echo esc_html( wp_basename( $file ) ); ?></span>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="attachment-tools">
+ <?php
+ if ( current_user_can( 'edit_post', $id ) ) {
+ echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '">' . _x( 'Edit', 'media item' ) . '</a>';
+ } else {
+ echo '<span class="edit-attachment">' . _x( 'Success', 'media item' ) . '</span>';
+ }
+ ?>
+ <span class="media-item-copy-container copy-to-clipboard-container edit-attachment">
+ <button type="button" class="button button-small copy-attachment-url" data-clipboard-text="<?php echo $file_url; ?>"><?php _e( 'Copy URL to clipboard' ); ?></button>
+ <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
+ </span>
+ </div>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="attachment-tools">
- <span class="media-item-copy-container copy-to-clipboard-container edit-attachment">
- <button type="button" class="button button-small copy-attachment-url" data-clipboard-text="<?php echo esc_url( $file_url ); ?>"><?php _e( 'Copy URL to clipboard' ); ?></button>
- <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
- </span>
- <?php
- if ( current_user_can( 'edit_post', $id ) ) {
- echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '">' . _x( 'Edit', 'media item' ) . '</a>';
- } else {
- echo '<span class="edit-attachment">' . _x( 'Success', 'media item' ) . '</span>';
- }
- ?>
- </div>
</del><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span></span></pre></div>
<a id="trunksrcwpadmincssmediacss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/media.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/media.css 2024-06-02 08:15:59 UTC (rev 58278)
+++ trunk/src/wp-admin/css/media.css 2024-06-02 08:35:30 UTC (rev 58279)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -112,14 +112,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin-right: 10px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.media-item-wrapper {
- display: grid;
- grid-template-columns: 1fr 1fr;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .media-item .attachment-tools {
</span><span class="cx" style="display: block; padding: 0 10px"> display: flex;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- justify-content: flex-end;
</del><span class="cx" style="display: block; padding: 0 10px"> align-items: center;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -190,15 +184,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.media-item .original {
- position: relative;
- min-height: 34px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .media-item .progress {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- float: right;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: inline-block;
</ins><span class="cx" style="display: block; padding: 0 10px"> height: 22px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: 7px 6px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin: 0 6px 7px;
</ins><span class="cx" style="display: block; padding: 0 10px"> width: 200px;
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 2em;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1436,3 +1425,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> max-width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+@media only screen and (max-width: 375px) {
+ .media-item .attachment-tools {
+ align-items: baseline;
+ }
+ .media-item .edit-attachment.copy-to-clipboard-container {
+ flex-direction: column;
+ }
+
+ .copy-to-clipboard-container .success {
+ line-height: normal;
+ margin-top: 10px;
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>