<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58130] trunk: REST API: Ensure attachments are uploaded to the post's year/month folder.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58130">58130</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58130","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>swissspidy</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-05-10 18:57:53 +0000 (Fri, 10 May 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>REST API: Ensure attachments are uploaded to the post's year/month folder.
If organizing uploads into month- and year-based folders, uploading an attachment to an existing post should store the file in `wp-content/uploads/<year>/<month>` based on the post's publish date. This is in line with the behavior in classic editor / the media modal.
Props swissspidy, adamsilverstein, timothyblynjacobs, skithund, sergeybiryukov, patricia70.
Fixes <a href="https://core.trac.wordpress.org/ticket/61189">#61189</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesfilephp">trunk/src/wp-admin/includes/file.php</a></li>
<li><a href="#trunksrcwpincludesfunctionsphp">trunk/src/wp-includes/functions.php</a></li>
<li><a href="#trunksrcwpincludesrestapiendpointsclasswprestattachmentscontrollerphp">trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestattachmentscontrollerphp">trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesfilephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/file.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/file.php 2024-05-10 18:07:17 UTC (rev 58129)
+++ trunk/src/wp-admin/includes/file.php 2024-05-10 18:57:53 UTC (rev 58130)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1089,7 +1089,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array|false $overrides Optional. An associative array of names => values
</span><span class="cx" style="display: block; padding: 0 10px"> * to override default variables. Default false.
</span><span class="cx" style="display: block; padding: 0 10px"> * See _wp_handle_upload() for accepted values.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $time Optional. Time formatted in 'yyyy/mm'. Default null.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array See _wp_handle_upload() for return value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function wp_handle_upload( &$file, $overrides = false, $time = null ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1120,7 +1120,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array|false $overrides Optional. An associative array of names => values
</span><span class="cx" style="display: block; padding: 0 10px"> * to override default variables. Default false.
</span><span class="cx" style="display: block; padding: 0 10px"> * See _wp_handle_upload() for accepted values.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $time Optional. Time formatted in 'yyyy/mm'. Default null.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array See _wp_handle_upload() for return value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function wp_handle_sideload( &$file, $overrides = false, $time = null ) {
</span></span></pre></div>
<a id="trunksrcwpincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/functions.php 2024-05-10 18:07:17 UTC (rev 58129)
+++ trunk/src/wp-includes/functions.php 2024-05-10 18:57:53 UTC (rev 58130)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2344,10 +2344,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.0.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses _wp_upload_dir()
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $time Optional. Time formatted in 'yyyy/mm'. Default null.
- * @param bool $create_dir Optional. Whether to check and create the uploads directory.
- * Default true for backward compatibility.
- * @param bool $refresh_cache Optional. Whether to refresh the cache. Default false.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
+ * @param bool $create_dir Optional. Whether to check and create the uploads directory.
+ * Default true for backward compatibility.
+ * @param bool $refresh_cache Optional. Whether to refresh the cache. Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array {
</span><span class="cx" style="display: block; padding: 0 10px"> * Array of information about the upload directory.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2419,7 +2419,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.5.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @access private
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $time Optional. Time formatted in 'yyyy/mm'. Default null.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array See wp_upload_dir()
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function _wp_upload_dir( $time = null ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2871,7 +2871,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $name Filename.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param null|string $deprecated Never used. Set to null.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $bits File content
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $time Optional. Time formatted in 'yyyy/mm'. Default null.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array {
</span><span class="cx" style="display: block; padding: 0 10px"> * Information about the newly-uploaded file.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span></span></pre></div>
<a id="trunksrcwpincludesrestapiendpointsclasswprestattachmentscontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php 2024-05-10 18:07:17 UTC (rev 58129)
+++ trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php 2024-05-10 18:57:53 UTC (rev 58130)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -254,10 +254,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $files = $request->get_file_params();
</span><span class="cx" style="display: block; padding: 0 10px"> $headers = $request->get_headers();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $time = null;
+
+ // Matches logic in media_handle_upload().
+ if ( ! empty( $request['post'] ) ) {
+ $post = get_post( $request['post'] );
+ // The post date doesn't usually matter for pages, so don't backdate this upload.
+ if ( $post && 'page' !== $post->post_type && substr( $post->post_date, 0, 4 ) > 0 ) {
+ $time = $post->post_date;
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $files ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $file = $this->upload_from_file( $files, $headers );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $file = $this->upload_from_file( $files, $headers, $time );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $file = $this->upload_from_data( $request->get_body(), $headers );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $file = $this->upload_from_data( $request->get_body(), $headers, $time );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_wp_error( $file ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1035,12 +1046,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Handles an upload via raw POST data.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.6.0 Added the `$time` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $data Supplied file data.
- * @param array $headers HTTP headers from the request.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $data Supplied file data.
+ * @param array $headers HTTP headers from the request.
+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array|WP_Error Data from wp_handle_sideload().
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- protected function upload_from_data( $data, $headers ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected function upload_from_data( $data, $headers, $time = null ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $data ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return new WP_Error(
</span><span class="cx" style="display: block; padding: 0 10px"> 'rest_upload_no_data',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1128,7 +1141,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'test_form' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $sideloaded = wp_handle_sideload( $file_data, $overrides );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $sideloaded = wp_handle_sideload( $file_data, $overrides, $time );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $sideloaded['error'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> @unlink( $tmpfname );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1246,12 +1259,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Handles an upload via multipart/form-data ($_FILES).
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.6.0 Added the `$time` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $files Data from the `$_FILES` superglobal.
- * @param array $headers HTTP headers from the request.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $files Data from the `$_FILES` superglobal.
+ * @param array $headers HTTP headers from the request.
+ * @param string|null $time Optional. Time formatted in 'yyyy/mm'. Default null.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array|WP_Error Data from wp_handle_upload().
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- protected function upload_from_file( $files, $headers ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected function upload_from_file( $files, $headers, $time = null ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $files ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return new WP_Error(
</span><span class="cx" style="display: block; padding: 0 10px"> 'rest_upload_no_data',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1293,7 +1308,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Include filesystem functions to get access to wp_handle_upload().
</span><span class="cx" style="display: block; padding: 0 10px"> require_once ABSPATH . 'wp-admin/includes/file.php';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $file = wp_handle_upload( $files['file'], $overrides );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $file = wp_handle_upload( $files['file'], $overrides, $time );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $file['error'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return new WP_Error(
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestattachmentscontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php 2024-05-10 18:07:17 UTC (rev 58129)
+++ trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php 2024-05-10 18:57:53 UTC (rev 58130)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2075,6 +2075,98 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Chocolate-dipped, no filling', get_post_meta( $response->get_data()['id'], 'best_cannoli', true ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 61189
+ * @requires function imagejpeg
+ */
+ public function test_create_item_year_month_based_folders() {
+ update_option( 'uploads_use_yearmonth_folders', 1 );
+
+ wp_set_current_user( self::$editor_id );
+
+ $published_post = self::factory()->post->create(
+ array(
+ 'post_status' => 'publish',
+ 'post_date' => '2017-02-14 00:00:00',
+ 'post_date_gmt' => '2017-02-14 00:00:00',
+ )
+ );
+
+ $request = new WP_REST_Request( 'POST', '/wp/v2/media' );
+ $request->set_header( 'Content-Type', 'image/jpeg' );
+ $request->set_header( 'Content-Disposition', 'attachment; filename=canola.jpg' );
+ $request->set_param( 'title', 'My title is very cool' );
+ $request->set_param( 'caption', 'This is a better caption.' );
+ $request->set_param( 'description', 'Without a description, my attachment is descriptionless.' );
+ $request->set_param( 'alt_text', 'Alt text is stored outside post schema.' );
+ $request->set_param( 'post', $published_post );
+
+ $request->set_body( file_get_contents( self::$test_file ) );
+ $response = rest_get_server()->dispatch( $request );
+ $data = $response->get_data();
+
+ update_option( 'uploads_use_yearmonth_folders', 0 );
+
+ $this->assertSame( 201, $response->get_status() );
+
+ $attachment = get_post( $data['id'] );
+
+ $this->assertSame( $attachment->post_parent, $data['post'] );
+ $this->assertSame( $attachment->post_parent, $published_post );
+ $this->assertSame( wp_get_attachment_url( $attachment->ID ), $data['source_url'] );
+ $this->assertStringContainsString( '2017/02', $data['source_url'] );
+ }
+
+
+ /**
+ * @ticket 61189
+ * @requires function imagejpeg
+ */
+ public function test_create_item_year_month_based_folders_page_post_type() {
+ update_option( 'uploads_use_yearmonth_folders', 1 );
+
+ wp_set_current_user( self::$editor_id );
+
+ $published_post = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_status' => 'publish',
+ 'post_date' => '2017-02-14 00:00:00',
+ 'post_date_gmt' => '2017-02-14 00:00:00',
+ )
+ );
+
+ $request = new WP_REST_Request( 'POST', '/wp/v2/media' );
+ $request->set_header( 'Content-Type', 'image/jpeg' );
+ $request->set_header( 'Content-Disposition', 'attachment; filename=canola.jpg' );
+ $request->set_param( 'title', 'My title is very cool' );
+ $request->set_param( 'caption', 'This is a better caption.' );
+ $request->set_param( 'description', 'Without a description, my attachment is descriptionless.' );
+ $request->set_param( 'alt_text', 'Alt text is stored outside post schema.' );
+ $request->set_param( 'post', $published_post );
+
+ $request->set_body( file_get_contents( self::$test_file ) );
+ $response = rest_get_server()->dispatch( $request );
+ $data = $response->get_data();
+
+ update_option( 'uploads_use_yearmonth_folders', 0 );
+
+ $time = current_time( 'mysql' );
+ $y = substr( $time, 0, 4 );
+ $m = substr( $time, 5, 2 );
+ $subdir = "/$y/$m";
+
+ $this->assertSame( 201, $response->get_status() );
+
+ $attachment = get_post( $data['id'] );
+
+ $this->assertSame( $attachment->post_parent, $data['post'] );
+ $this->assertSame( $attachment->post_parent, $published_post );
+ $this->assertSame( wp_get_attachment_url( $attachment->ID ), $data['source_url'] );
+ $this->assertStringNotContainsString( '2017/02', $data['source_url'] );
+ $this->assertStringContainsString( $subdir, $data['source_url'] );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function filter_rest_insert_attachment( $attachment ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ++self::$rest_insert_attachment_count;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>