<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[58124] trunk/src/wp-includes/nav-menu-template.php: Coding Standards: Use strict comparison in `wp-includes/nav-menu-template.php`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/58124">58124</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/58124","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-05-09 15:14:46 +0000 (Thu, 09 May 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Use strict comparison in `wp-includes/nav-menu-template.php`.
Includes correcting a conditional in `_wp_menu_item_classes_by_context()` where `$parent_item->object`, which contains a string like `page`, was erroneously compared to the queried object's ID. The correct property to compare is `$parent_item->object_id`.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/14876">[14876]</a>, <a href="https://core.trac.wordpress.org/changeset/14923">[14923]</a>, <a href="https://core.trac.wordpress.org/changeset/14942">[14942]</a>, <a href="https://core.trac.wordpress.org/changeset/15302">[15302]</a>, <a href="https://core.trac.wordpress.org/changeset/16731">[16731]</a>, <a href="https://core.trac.wordpress.org/changeset/16742">[16742]</a>, <a href="https://core.trac.wordpress.org/changeset/22302">[22302]</a>, <a href="https://core.trac.wordpress.org/changeset/47550">[47550]</a>, <a href="https://core.trac.wordpress.org/changeset/47557">[47557]</a>, <a href="https://core.trac.wordpress.org/changeset/47808">[47808]</a>.
Props aristath, poena, afercia, SergeyBiryukov.
See <a href="https://core.trac.wordpress.org/ticket/60700">#60700</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesnavmenutemplatephp">trunk/src/wp-includes/nav-menu-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesnavmenutemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/nav-menu-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/nav-menu-template.php 2024-05-09 04:07:53 UTC (rev 58123)
+++ trunk/src/wp-includes/nav-menu-template.php 2024-05-09 15:14:46 UTC (rev 58124)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -418,14 +418,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If the menu item corresponds to the currently queried post or taxonomy object.
</span><span class="cx" style="display: block; padding: 0 10px"> } elseif (
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $menu_item->object_id == $queried_object_id
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ (int) $menu_item->object_id === $queried_object_id
</ins><span class="cx" style="display: block; padding: 0 10px"> && (
</span><span class="cx" style="display: block; padding: 0 10px"> ( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- && $wp_query->is_home && $home_page_id == $menu_item->object_id )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ && $wp_query->is_home && $home_page_id === (int) $menu_item->object_id )
</ins><span class="cx" style="display: block; padding: 0 10px"> || ( 'post_type' === $menu_item->type && $wp_query->is_singular )
</span><span class="cx" style="display: block; padding: 0 10px"> || ( 'taxonomy' === $menu_item->type
</span><span class="cx" style="display: block; padding: 0 10px"> && ( $wp_query->is_category || $wp_query->is_tag || $wp_query->is_tax )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- && $queried_object->taxonomy == $menu_item->object )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ && $queried_object->taxonomy === $menu_item->object )
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $classes[] = 'current-menu-item';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -512,11 +512,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $active_object = $menu_item->object;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Give front page item the 'current-menu-item' class when extra query arguments are involved.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } elseif ( $item_url == $front_page_url && is_front_page() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( $item_url === $front_page_url && is_front_page() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $classes[] = 'current-menu-item';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( untrailingslashit( $item_url ) == home_url() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( untrailingslashit( $item_url ) === home_url() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $classes[] = 'menu-item-home';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -523,7 +523,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Back-compat with wp_page_menu(): add "current_page_parent" to static home page link for any non-page query.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $home_page_id ) && 'post_type' === $menu_item->type
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- && empty( $wp_query->is_page ) && $home_page_id == $menu_item->object_id
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ && empty( $wp_query->is_page ) && $home_page_id === (int) $menu_item->object_id
</ins><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $classes[] = 'current_page_parent';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -549,7 +549,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> && ! empty( $queried_object->post_type )
</span><span class="cx" style="display: block; padding: 0 10px"> && is_post_type_hierarchical( $queried_object->post_type )
</span><span class="cx" style="display: block; padding: 0 10px"> && in_array( (int) $parent_item->object_id, $queried_object->ancestors, true )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- && $parent_item->object != $queried_object->ID
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ && (int) $parent_item->object_id !== $queried_object->ID
</ins><span class="cx" style="display: block; padding: 0 10px"> ) ||
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Ancestral term.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -559,7 +559,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> && in_array( (int) $parent_item->object_id, $possible_taxonomy_ancestors[ $parent_item->object ], true )
</span><span class="cx" style="display: block; padding: 0 10px"> && (
</span><span class="cx" style="display: block; padding: 0 10px"> ! isset( $queried_object->term_id ) ||
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $parent_item->object_id != $queried_object->term_id
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ (int) $parent_item->object_id !== $queried_object->term_id
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span></span></pre>
</div>
</div>
</body>
</html>