<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57703] trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php: Editor: Improve PHPUnit tests for block pattern registration.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57703">57703</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57703","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joemcgill</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-02-23 16:53:39 +0000 (Fri, 23 Feb 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Editor: Improve PHPUnit tests for block pattern registration.
This is a followup to <a href="https://core.trac.wordpress.org/changeset/57683">[57683]</a>, which adds additional unit test coverage to ensure block pattern content is not loaded from files during registration, but instead when those patterns are accessed. This also improves the `set_up` and `tear_down` methods for the `Tests_Blocks_wpBlockPattersRegistry` test class to ensure that any modifications made to registered blocks during the tests are reset after each test.
Props thekt12, joemcgill.
See <a href="https://core.trac.wordpress.org/ticket/59532">#59532</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsblockswpBlockPatternsRegistryphp">trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsblockswpBlockPatternsRegistryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php 2024-02-23 10:36:36 UTC (rev 57702)
+++ trunk/tests/phpunit/tests/blocks/wpBlockPatternsRegistry.php 2024-02-23 16:53:39 UTC (rev 57703)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,6 +21,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> private $registry = null;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Original registered patterns.
+ * This is the value from the internal private property.
+ *
+ * @since 6.5.0
+ * @var array
+ */
+ private $original_registered_patterns = null;
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Set up each test method.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.4.0
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -28,7 +37,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function set_up() {
</span><span class="cx" style="display: block; padding: 0 10px"> parent::set_up();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->registry = new WP_Block_Patterns_Registry();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->registry = new WP_Block_Patterns_Registry();
+ $this->original_registered_patterns = $this->get_registered_patterns_variable_value();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,6 +55,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $registry->unregister( 'tests/my-block' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->set_registered_patterns_variable_value( $this->original_registered_patterns );
</ins><span class="cx" style="display: block; padding: 0 10px"> parent::tear_down();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -543,4 +554,139 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEmpty( array_intersect( $theme_patterns, $registered ), 'Theme patterns were were incorrectly registered.' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Ensures theme patterns are lazy loaded.
+ *
+ * @ticket 59532
+ *
+ * @covers WP_Block_Patterns_Registry::get_all_registered
+ */
+ public function test_lazy_loading_block_patterns_get_all_registered() {
+ // This test needs to use access static class properties.
+ $registry = WP_Block_Patterns_Registry::get_instance();
+
+ // Testing only the first pattern loaded from the theme.
+ $pattern_name = 'twentytwentythree/footer-default';
+
+ // Ensure we're using a theme with patterns.
+ switch_theme( 'twentytwentythree' );
+
+ // This helper is fired on the init hook.
+ _register_theme_block_patterns();
+
+ // Get the value of the private property.
+ $registered_patterns = $this->get_registered_patterns_variable_value();
+
+ $this->assertTrue(
+ isset( $registered_patterns[ $pattern_name ]['file_path'] ) &&
+ ! isset( $registered_patterns[ $pattern_name ]['content'] ),
+ 'Pattern was not lazy loaded.'
+ );
+
+ $all_patterns = $registry->get_all_registered();
+
+ $loaded_pattern = array_values(
+ array_filter(
+ $all_patterns,
+ function ( $pattern ) use ( $pattern_name ) {
+ return $pattern['name'] === $pattern_name;
+ }
+ )
+ );
+
+ $this->assertTrue(
+ ! empty( $loaded_pattern[0]['content'] ),
+ 'Content not loaded.'
+ );
+
+ // Check if the original property was updated.
+ $registered_patterns = $this->get_registered_patterns_variable_value();
+
+ $this->assertTrue(
+ ! empty( $registered_patterns[ $pattern_name ]['content'] ),
+ 'Content not updated.'
+ );
+ }
+
+ /**
+ * Ensures theme patterns are lazy loaded.
+ *
+ * @ticket 59532
+ *
+ * @covers WP_Block_Patterns_Registry::get_registered
+ */
+ public function test_lazy_loading_block_patterns_get_registered() {
+ // This test needs to use access static class properties.
+ $registry = WP_Block_Patterns_Registry::get_instance();
+
+ // Testing only the first pattern loaded from the theme.
+ $pattern_name = 'twentytwentythree/footer-default';
+
+ // Ensure we're using a theme with patterns.
+ switch_theme( 'twentytwentythree' );
+
+ // This helper is fired on the init hook.
+ _register_theme_block_patterns();
+
+ // Get the value of the private property.
+ $registered_patterns = $this->get_registered_patterns_variable_value();
+
+ $this->assertTrue(
+ isset( $registered_patterns[ $pattern_name ]['file_path'] ) &&
+ ! isset( $registered_patterns[ $pattern_name ]['content'] ),
+ 'Pattern was not lazy loaded.'
+ );
+
+ $loaded_pattern = $registry->get_registered( $pattern_name );
+
+ $this->assertTrue(
+ ! empty( $loaded_pattern['content'] ),
+ 'Content not loaded.'
+ );
+
+ // Check if the original property was updated.
+ $registered_patterns = $this->get_registered_patterns_variable_value();
+
+ $this->assertTrue(
+ ! empty( $registered_patterns[ $pattern_name ]['content'] ),
+ 'Content not updated.'
+ );
+ }
+
+ /**
+ * Get the value of the `$registered_patterns` private property.
+ *
+ * @return array
+ */
+ private function get_registered_patterns_variable_value() {
+ $registry = WP_Block_Patterns_Registry::get_instance();
+ // Use Reflection to access private property.
+ $reflection = new ReflectionClass( $registry );
+ $property = $reflection->getProperty( 'registered_patterns' );
+ $property->setAccessible( true );
+
+ // Get the value of the private property.
+ $registered_patterns = $property->getValue( $registry );
+ $property->setAccessible( false );
+
+ return $registered_patterns;
+ }
+
+ /**
+ * Set the value of the `$registered_patterns` private property.
+ *
+ * @param array $value The value to set.
+ */
+ private function set_registered_patterns_variable_value( $value ) {
+ $registry = WP_Block_Patterns_Registry::get_instance();
+ // Use Reflection to access private property.
+ $reflection = new ReflectionClass( $registry );
+ $property = $reflection->getProperty( 'registered_patterns' );
+ $property->setAccessible( true );
+
+ // Set the value of the private property.
+ $property->setValue( $registry, $value );
+ $property->setAccessible( false );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>