<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57673] trunk/tests/phpunit/tests/image/meta.php: Tests: Use `assertSame()` in `wp_read_image_metadata()` tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57673">57673</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57673","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-02-20 18:14:41 +0000 (Tue, 20 Feb 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Use `assertSame()` in `wp_read_image_metadata()` tests.
This ensures that not only the return values match the expected results, but also that their type is the same.
Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.
Follow-up to [49/tests], [198/tests], <a href="https://core.trac.wordpress.org/changeset/34374">[34374]</a>, <a href="https://core.trac.wordpress.org/changeset/48937">[48937]</a>, <a href="https://core.trac.wordpress.org/changeset/52269">[52269]</a>.
Props costdev.
See <a href="https://core.trac.wordpress.org/ticket/59655">#59655</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsimagemetaphp">trunk/tests/phpunit/tests/image/meta.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsimagemetaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/image/meta.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/image/meta.php 2024-02-20 17:31:36 UTC (rev 57672)
+++ trunk/tests/phpunit/tests/image/meta.php 2024-02-20 18:14:41 UTC (rev 57673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,15 +32,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Exif from a Nikon D70.
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/2004-07-22-DSC_0008.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 6.3, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '6.3', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'NIKON D70', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( strtotime( '2004-07-22 17:14:59' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( (string) strtotime( '2004-07-22 17:14:59' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 27, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 400, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 1 / 40, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '27', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '400', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( (string) ( 1 / 40 ), $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -52,11 +52,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'NIKON D70', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Copyright Alex Shiels', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( strtotime( '2007-06-17 21:18:00' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( (string) strtotime( '2007-06-17 21:18:00' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 0, $out['iso'], 'Iso value not equivalent' ); // Interesting - a Nikon bug?
- $this->assertEquals( 1 / 500, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '0', $out['iso'], 'Iso value not equivalent' ); // Interesting - a Nikon bug?
+ $this->assertSame( (string) ( 1 / 500 ), $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Copyright Alex Shiels', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> // $this->assertSame( array( 'Flowers' ), $out['keywords'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,15 +65,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Exif from a Nikon D70 with IPTC data added later.
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/2004-07-22-DSC_0007.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 6.3, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '6.3', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'IPTC Creator', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'NIKON D70', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'IPTC Caption', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( strtotime( '2004-07-22 17:14:35' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( (string) strtotime( '2004-07-22 17:14:35' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'IPTC Copyright', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 18, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 200, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 1 / 25, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '18', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '200', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( (string) ( 1 / 25 ), $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'IPTC Headline', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -81,15 +81,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Exif from a Fuji FinePix S5600 (thanks Mark).
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/a2-small.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 4.5, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '4.5', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'FinePix S5600', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( strtotime( '2007-09-03 10:17:03' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( (string) strtotime( '2007-09-03 10:17:03' ), $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 6.3, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 64, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 1 / 320, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '6.3', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '64', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( (string) ( 1 / 320 ), $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -101,15 +101,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // This triggers a warning mesage when reading the Exif block.
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/waffles.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 0, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 0, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '0', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( '0', $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -117,15 +117,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // No Exif data in this image (from burningwell.org).
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/canola.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 0, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 0, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '0', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( '0', $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -158,13 +158,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Photoshop Author', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'DMC-LX2', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Photoshop Description', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 1306315327, $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '1306315327', $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Photoshop Copyrright Notice', $out['copyright'], 'Copyright value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '6.3', $out['focal_length'], 'Focal length value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '100', $out['iso'], 'Iso value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '0.0025', $out['shutter_speed'], 'Shutter speed value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Photoshop Document Ttitle', $out['title'], 'Title value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 1, $out['orientation'], 'Orientation value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '1', $out['orientation'], 'Orientation value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( array( 'beach', 'baywatch', 'LA', 'sunset' ), $out['keywords'], 'Keywords not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -246,15 +246,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Unexpected Exif data: FNumber is "0/0", aperture should be 0.
</span><span class="cx" style="display: block; padding: 0 10px"> $out = wp_read_image_metadata( DIR_TESTDATA . '/images/sugarloaf-mountain.jpg' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['aperture'], 'Aperture value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['aperture'], 'Aperture value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['credit'], 'Credit value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'X-T1', $out['camera'], 'Camera value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['caption'], 'Caption value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 0, $out['created_timestamp'], 'Timestamp value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '0', $out['created_timestamp'], 'Timestamp value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( '', $out['copyright'], 'Copyright value not the same' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 50, $out['focal_length'], 'Focal length value not equivalent' );
- $this->assertEquals( 200, $out['iso'], 'Iso value not equivalent' );
- $this->assertEquals( 2, $out['shutter_speed'], 'Shutter speed value not equivalent' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '50', $out['focal_length'], 'Focal length value not equivalent' );
+ $this->assertSame( '200', $out['iso'], 'Iso value not equivalent' );
+ $this->assertSame( '2', $out['shutter_speed'], 'Shutter speed value not equivalent' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Sugarloaf Panorama', $out['title'], 'Title value not the same' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>