<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57605] trunk/src: Media: Update progress spinner position on small screens.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57605">57605</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57605","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-02-12 23:00:04 +0000 (Mon, 12 Feb 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Update progress spinner position on small screens.
Move the media library progress spinner to overlay the filter controls while active. Improves design and prevents unpredictable layout.
Props afercia, kushang78, joedolson, karmatosed.
Fixes <a href="https://core.trac.wordpress.org/ticket/33049">#33049</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjsmediaviewsattachmentsbrowserjs">trunk/src/js/media/views/attachments/browser.js</a></li>
<li><a href="#trunksrcjsmediaviewstoolbarjs">trunk/src/js/media/views/toolbar.js</a></li>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjsmediaviewsattachmentsbrowserjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/media/views/attachments/browser.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/media/views/attachments/browser.js 2024-02-12 22:24:17 UTC (rev 57604)
+++ trunk/src/js/media/views/attachments/browser.js 2024-02-12 23:00:04 UTC (rev 57605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -423,6 +423,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! this.collection.length ) {
</span><span class="cx" style="display: block; padding: 0 10px"> this.toolbar.get( 'spinner' ).show();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.toolbar.$( '.media-bg-overlay' ).show();
</ins><span class="cx" style="display: block; padding: 0 10px"> this.dfd = this.collection.more().done( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! view.collection.length ) {
</span><span class="cx" style="display: block; padding: 0 10px"> noItemsView.$el.removeClass( 'hidden' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -430,10 +431,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> noItemsView.$el.addClass( 'hidden' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> view.toolbar.get( 'spinner' ).hide();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ view.toolbar.$( '.media-bg-overlay' ).hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> noItemsView.$el.addClass( 'hidden' );
</span><span class="cx" style="display: block; padding: 0 10px"> view.toolbar.get( 'spinner' ).hide();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.toolbar.$( '.media-bg-overlay' ).hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcjsmediaviewstoolbarjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/media/views/toolbar.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/media/views/toolbar.js 2024-02-12 22:24:17 UTC (rev 57604)
+++ trunk/src/js/media/views/toolbar.js 2024-02-12 23:00:04 UTC (rev 57605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -28,10 +28,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // The toolbar is composed of two `PriorityList` views.
</span><span class="cx" style="display: block; padding: 0 10px"> this.primary = new wp.media.view.PriorityList();
</span><span class="cx" style="display: block; padding: 0 10px"> this.secondary = new wp.media.view.PriorityList();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.tertiary = new wp.media.view.PriorityList();
</ins><span class="cx" style="display: block; padding: 0 10px"> this.primary.$el.addClass('media-toolbar-primary search-form');
</span><span class="cx" style="display: block; padding: 0 10px"> this.secondary.$el.addClass('media-toolbar-secondary');
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.tertiary.$el.addClass('media-bg-overlay');
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.views.set([ this.secondary, this.primary ]);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.views.set([ this.secondary, this.primary, this.tertiary ]);
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.options.items ) {
</span><span class="cx" style="display: block; padding: 0 10px"> this.set( this.options.items, { silent: true });
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -122,6 +124,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> delete this._views[ id ];
</span><span class="cx" style="display: block; padding: 0 10px"> this.primary.unset( id, options );
</span><span class="cx" style="display: block; padding: 0 10px"> this.secondary.unset( id, options );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.tertiary.unset( id, options );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! options || ! options.silent ) {
</span><span class="cx" style="display: block; padding: 0 10px"> this.refresh();
</span></span></pre></div>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/css/media-views.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/css/media-views.css 2024-02-12 22:24:17 UTC (rev 57604)
+++ trunk/src/wp-includes/css/media-views.css 2024-02-12 23:00:04 UTC (rev 57605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2814,6 +2814,34 @@
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 14px;
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 2.71428571;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ .media-frame .wp-filter .media-toolbar-secondary {
+ position: unset;
+ }
+
+ .media-frame .media-toolbar-secondary .spinner {
+ position: absolute;
+ top: 0;
+ bottom: 0;
+ margin: auto;
+ left: 0;
+ right: 0;
+ z-index: 9;
+ }
+
+ .media-bg-overlay {
+ content: '';
+ background: #ffffff;
+ width: 100%;
+ height: 100%;
+ display: hidden;
+ position: absolute;
+ left: 0;
+ right: 0;
+ top: 0;
+ bottom: 0;
+ opacity: 0.6;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Responsive on portrait and landscape */
</span></span></pre>
</div>
</div>
</body>
</html>