<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57599] trunk/src/wp-content/themes/twentynineteen: Twenty Nineteen: Correct line height for Button block.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57599">57599</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57599","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-02-12 18:50:47 +0000 (Mon, 12 Feb 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Twenty Nineteen: Correct line height for Button block.
This commit moves `line-height` to the Buttons container and removes the duplicate `outline` property.
Props sabernhardt, nidhidhandhukiya, monzuralam, shailu25, hrrarya, karmatosed, harshgajipara, nicolefurlan, fnpen, oglekler, poena, huzaifaalmesbah, audrasjb.
Fixes <a href="https://core.trac.wordpress.org/ticket/58443">#58443</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpcontentthemestwentynineteensassblocks_blocksscss">trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstyleeditorcss">trunk/src/wp-content/themes/twentynineteen/style-editor.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstyleeditorscss">trunk/src/wp-content/themes/twentynineteen/style-editor.scss</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylertlcss">trunk/src/wp-content/themes/twentynineteen/style-rtl.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylecss">trunk/src/wp-content/themes/twentynineteen/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpcontentthemestwentynineteensassblocks_blocksscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss 2024-02-12 16:51:48 UTC (rev 57598)
+++ trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss 2024-02-12 18:50:47 UTC (rev 57599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -163,7 +163,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- //! Button
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ //! Buttons
+ .wp-block-buttons {
+ line-height: $font__line-height-heading;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .wp-block-button {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-block-button__link {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -171,13 +175,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: none;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: $font__size-sm;
</span><span class="cx" style="display: block; padding: 0 10px"> @include font-family( $font__heading );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height: $font__line-height-heading;
</del><span class="cx" style="display: block; padding: 0 10px"> box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span><span class="cx" style="display: block; padding: 0 10px"> text-decoration: none;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: ($size__spacing-unit * .76) $size__spacing-unit;
</span><span class="cx" style="display: block; padding: 0 10px"> outline: none;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- outline: none;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> &:not(.has-background) {
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: $color__background-button;
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstyleeditorcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style-editor.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style-editor.css 2024-02-12 16:51:48 UTC (rev 57598)
+++ trunk/src/wp-content/themes/twentynineteen/style-editor.css 2024-02-12 18:50:47 UTC (rev 57599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1004,8 +1004,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /** === Button === */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.wp-block-buttons {
+ line-height: 1.2;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .wp-block-button .wp-block-button__link {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height: inherit;
</del><span class="cx" style="display: block; padding: 0 10px"> font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 0.88889em;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstyleeditorscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style-editor.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style-editor.scss 2024-02-12 16:51:48 UTC (rev 57598)
+++ trunk/src/wp-content/themes/twentynineteen/style-editor.scss 2024-02-12 18:50:47 UTC (rev 57599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -379,10 +379,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /** === Button === */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.wp-block-buttons {
+ line-height: $font__line-height-heading;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .wp-block-button {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-block-button__link {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height:inherit;
</del><span class="cx" style="display: block; padding: 0 10px"> @include font-family( $font__heading );
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: $font__size-sm;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylertlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2024-02-12 16:51:48 UTC (rev 57598)
+++ trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2024-02-12 18:50:47 UTC (rev 57599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5484,18 +5484,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.entry .entry-content .wp-block-buttons {
+ line-height: 1.2;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-button .wp-block-button__link {
</span><span class="cx" style="display: block; padding: 0 10px"> transition: background 150ms ease-in-out;
</span><span class="cx" style="display: block; padding: 0 10px"> border: none;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 0.88889em;
</span><span class="cx" style="display: block; padding: 0 10px"> font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height: 1.2;
</del><span class="cx" style="display: block; padding: 0 10px"> box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span><span class="cx" style="display: block; padding: 0 10px"> text-decoration: none;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0.76rem 1rem;
</span><span class="cx" style="display: block; padding: 0 10px"> outline: none;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- outline: none;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-button .wp-block-button__link:not(.has-background) {
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style.css 2024-02-12 16:51:48 UTC (rev 57598)
+++ trunk/src/wp-content/themes/twentynineteen/style.css 2024-02-12 18:50:47 UTC (rev 57599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2804,7 +2804,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> background: transparent;
</span><span class="cx" style="display: block; padding: 0 10px"> color: inherit;
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: pointer;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- transition: background 250ms ease-in-out, transform 150ms ease;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ transition: background 250ms ease-in-out,
+ transform 150ms ease;
</ins><span class="cx" style="display: block; padding: 0 10px"> -webkit-appearance: none;
</span><span class="cx" style="display: block; padding: 0 10px"> -moz-appearance: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5496,18 +5497,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.entry .entry-content .wp-block-buttons {
+ line-height: 1.2;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-button .wp-block-button__link {
</span><span class="cx" style="display: block; padding: 0 10px"> transition: background 150ms ease-in-out;
</span><span class="cx" style="display: block; padding: 0 10px"> border: none;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 0.88889em;
</span><span class="cx" style="display: block; padding: 0 10px"> font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height: 1.2;
</del><span class="cx" style="display: block; padding: 0 10px"> box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span><span class="cx" style="display: block; padding: 0 10px"> text-decoration: none;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0.76rem 1rem;
</span><span class="cx" style="display: block; padding: 0 10px"> outline: none;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- outline: none;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-button .wp-block-button__link:not(.has-background) {
</span></span></pre>
</div>
</div>
</body>
</html>