<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57523] trunk/.github/workflows/props-bot.yml: Build/Test Tools: Some improvements to the Props Bot workflow.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57523">57523</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57523","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-02-02 16:35:59 +0000 (Fri, 02 Feb 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Some improvements to the Props Bot workflow.
This makes a few improvements made to the Props Bot workflow:
- The bot will no longer run on draft PRs.
- The bot will no longer run on closed PRs.
- The bot will no longer run when a comment is deleted (this should almost never happen).
Props mamaduka, gziolo.
See <a href="https://core.trac.wordpress.org/ticket/60417">#60417</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowspropsbotyml">trunk/.github/workflows/props-bot.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowspropsbotyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/props-bot.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/props-bot.yml 2024-02-02 15:28:18 UTC (rev 57522)
+++ trunk/.github/workflows/props-bot.yml 2024-02-02 16:35:59 UTC (rev 57523)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,10 +1,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Props Bot
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> on:
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # This event runs anytime a PR is (re)opened, updated, or labeled.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # This event runs anytime a PR is (re)opened, updated, marked ready for review, or labeled.
</ins><span class="cx" style="display: block; padding: 0 10px"> # GitHub does not allow filtering the `labeled` event by a specific label.
</span><span class="cx" style="display: block; padding: 0 10px"> # However, the logic below will short-circuit the workflow when the `props-bot` label is not the one being added.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Note: The pull_request_target event is uesed instead of pull_request because this workflow needs permission to comment
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # Note: The pull_request_target event is used instead of pull_request because this workflow needs permission to comment
</ins><span class="cx" style="display: block; padding: 0 10px"> # on the pull request. Because this event grants extra permissions to `GITHUB_TOKEN`, any code changes within the PR
</span><span class="cx" style="display: block; padding: 0 10px"> # should be considered untrusted. See https://securitylab.github.com/research/github-actions-preventing-pwn-requests/.
</span><span class="cx" style="display: block; padding: 0 10px"> pull_request_target:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,6 +13,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - synchronize
</span><span class="cx" style="display: block; padding: 0 10px"> - reopened
</span><span class="cx" style="display: block; padding: 0 10px"> - labeled
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - ready_for_review
</ins><span class="cx" style="display: block; padding: 0 10px"> # This event runs anytime a comment is added or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> # You cannot filter this event for PR comments only.
</span><span class="cx" style="display: block; padding: 0 10px"> # However, the logic below does short-circuit the workflow for issues.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,7 +20,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> issue_comment:
</span><span class="cx" style="display: block; padding: 0 10px"> type:
</span><span class="cx" style="display: block; padding: 0 10px"> - created
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - deleted
</del><span class="cx" style="display: block; padding: 0 10px"> # This event will run everytime a new PR review is initially submitted.
</span><span class="cx" style="display: block; padding: 0 10px"> pull_request_review:
</span><span class="cx" style="display: block; padding: 0 10px"> types:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -28,7 +28,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pull_request_review_comment:
</span><span class="cx" style="display: block; padding: 0 10px"> types:
</span><span class="cx" style="display: block; padding: 0 10px"> - created
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - deleted
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # Cancels all previous workflow runs for pull requests that have not completed.
</span><span class="cx" style="display: block; padding: 0 10px"> concurrency:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -55,17 +54,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pull-requests: write
</span><span class="cx" style="display: block; padding: 0 10px"> contents: read
</span><span class="cx" style="display: block; padding: 0 10px"> timeout-minutes: 20
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # The job should only run if:
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # The job will run when pull requests are open, ready for review and:
</ins><span class="cx" style="display: block; padding: 0 10px"> #
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - A pull request review is created or commented on.
- # - An issue comment is added to a pull request.
- # - A pull request is opened, synchronized, or reopened.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - A comment is added to the pull request.
+ # - A review is created or commented on.
+ # - The pull request is opened, synchronized, marked ready for review, or reopened.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - The `props-bot` label is added to the pull request.
</span><span class="cx" style="display: block; padding: 0 10px"> if: |
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- contains( fromJSON( '["pull_request_review", "pull_request_review_comment"]' ), github.event_name ) ||
- ( github.event_name == 'issue_comment' && github.event.issue.pull_request ) ||
- github.event_name == 'pull_request_target' && github.event.action != 'labeled' ||
- 'props-bot' == github.event.label.name
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ (
+ github.event_name == 'issue_comment' && github.event.issue.pull_request ||
+ contains( fromJSON( '["pull_request_review", "pull_request_review_comment"]' ), github.event_name ) ||
+ github.event_name == 'pull_request_target' && github.event.action != 'labeled' ||
+ 'props-bot' == github.event.label.name
+ ) &&
+ ( ! github.event.pull_request.draft && github.event.pull_request.state == 'open' || ! github.event.issue.draft && github.event.issue.state == 'open' )
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Gather a list of contributors
</span></span></pre>
</div>
</div>
</body>
</html>