<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57326] trunk: HTML API: Support PARAM, SOURCE, and TRACK tags.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57326">57326</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57326","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dmsnell</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-01-23 01:49:06 +0000 (Tue, 23 Jan 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>HTML API: Support PARAM, SOURCE, and TRACK tags.
Adds support for the following HTML elements to the HTML Processor:
- PARAM, SOURCE, TRACK
Previously these elements were not supported and the HTML Processor would bail when encountering them. Now, with this patch applied, it will proceed to parse an HTML document when encountering those tags.
Props jonsurrell, dmsnell
Fixes <a href="https://core.trac.wordpress.org/ticket/60283">#60283</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludeshtmlapiclasswphtmlprocessorphp">trunk/src/wp-includes/html-api/class-wp-html-processor.php</a></li>
<li><a href="#trunktestsphpunittestshtmlapiwpHtmlProcessorphp">trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php</a></li>
<li><a href="#trunktestsphpunittestshtmlapiwpHtmlProcessorBreadcrumbsphp">trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludeshtmlapiclasswphtmlprocessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/html-api/class-wp-html-processor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-01-22 19:40:18 UTC (rev 57325)
+++ trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-01-23 01:49:06 UTC (rev 57326)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,7 +106,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * - Heading elements: H1, H2, H3, H4, H5, H6, HGROUP.
</span><span class="cx" style="display: block; padding: 0 10px"> * - Links: A.
</span><span class="cx" style="display: block; padding: 0 10px"> * - Lists: DD, DL, DT, LI, OL, LI.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * - Media elements: AUDIO, CANVAS, EMBED, FIGCAPTION, FIGURE, IMG, MAP, PICTURE, VIDEO.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * - Media elements: AUDIO, CANVAS, EMBED, FIGCAPTION, FIGURE, IMG, MAP, PARAM, PICTURE, SOURCE, VIDEO, TRACK.
</ins><span class="cx" style="display: block; padding: 0 10px"> * - Paragraph: BR, P.
</span><span class="cx" style="display: block; padding: 0 10px"> * - Phrasing elements: AREA, ABBR, BDI, BDO, CITE, DATA, DEL, DFN, INS, MARK, OUTPUT, Q, SAMP, SUB, SUP, TIME, VAR.
</span><span class="cx" style="display: block; padding: 0 10px"> * - Sectioning elements: ARTICLE, ASIDE, HR, NAV, SECTION.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -982,6 +982,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->insert_html_element( $this->state->current_token );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->state->frameset_ok = false;
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /*
+ * > A start tag whose tag name is one of: "param", "source", "track"
+ */
+ case '+PARAM':
+ case '+SOURCE':
+ case '+TRACK':
+ $this->insert_html_element( $this->state->current_token );
+ return true;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1027,7 +1036,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'OBJECT':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'OPTGROUP':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'OPTION':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'PARAM':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'PLAINTEXT':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'RB':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'RP':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1036,7 +1044,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'SARCASM':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'SCRIPT':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'SELECT':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'SOURCE':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'STYLE':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'SVG':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TABLE':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1049,7 +1056,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'THEAD':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TITLE':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TR':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'TRACK':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'XMP':
</span><span class="cx" style="display: block; padding: 0 10px"> $this->last_error = self::ERROR_UNSUPPORTED;
</span><span class="cx" style="display: block; padding: 0 10px"> throw new WP_HTML_Unsupported_Exception( "Cannot process {$tag_name} element." );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1712,8 +1718,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'HR' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'IMG' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'INPUT' === $tag_name ||
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'KEYGEN' === $tag_name || // Obsolete but still treated as void.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'LINK' === $tag_name ||
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'KEYGEN' === $tag_name || // Obsolete but still treated as void.
</del><span class="cx" style="display: block; padding: 0 10px"> 'META' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'PARAM' === $tag_name || // Obsolete but still treated as void.
</span><span class="cx" style="display: block; padding: 0 10px"> 'SOURCE' === $tag_name ||
</span></span></pre></div>
<a id="trunktestsphpunittestshtmlapiwpHtmlProcessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php 2024-01-22 19:40:18 UTC (rev 57325)
+++ trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php 2024-01-23 01:49:06 UTC (rev 57326)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -206,6 +206,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'KEYGEN' => array( 'KEYGEN' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'LINK' => array( 'LINK' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'META' => array( 'META' ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'PARAM' => array( 'PARAM' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'SOURCE' => array( 'SOURCE' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'TRACK' => array( 'TRACK' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'WBR' => array( 'WBR' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -264,7 +265,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'OBJECT' => array( 'OBJECT' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'OPTGROUP' => array( 'OPTGROUP' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'OPTION' => array( 'OPTION' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'PARAM' => array( 'PARAM' ),
</del><span class="cx" style="display: block; padding: 0 10px"> 'PLAINTEXT' => array( 'PLAINTEXT' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'RB' => array( 'RB' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'RP' => array( 'RP' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -273,7 +273,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'SARCASM' => array( 'SARCASM' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'SCRIPT' => array( 'SCRIPT' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'SELECT' => array( 'SELECT' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'SOURCE' => array( 'SOURCE' ),
</del><span class="cx" style="display: block; padding: 0 10px"> 'STYLE' => array( 'STYLE' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'SVG' => array( 'SVG' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'TABLE' => array( 'TABLE' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -286,7 +285,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'THEAD' => array( 'THEAD' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'TITLE' => array( 'TITLE' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'TR' => array( 'TR' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'TRACK' => array( 'TRACK' ),
</del><span class="cx" style="display: block; padding: 0 10px"> 'XMP' => array( 'XMP' ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestshtmlapiwpHtmlProcessorBreadcrumbsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php 2024-01-22 19:40:18 UTC (rev 57325)
+++ trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php 2024-01-23 01:49:06 UTC (rev 57326)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -199,7 +199,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'RTC', // Neutralized.
</span><span class="cx" style="display: block; padding: 0 10px"> 'SCRIPT',
</span><span class="cx" style="display: block; padding: 0 10px"> 'SELECT',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'SOURCE',
</del><span class="cx" style="display: block; padding: 0 10px"> 'STYLE',
</span><span class="cx" style="display: block; padding: 0 10px"> 'SVG',
</span><span class="cx" style="display: block; padding: 0 10px"> 'TABLE',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -212,7 +211,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'THEAD',
</span><span class="cx" style="display: block; padding: 0 10px"> 'TITLE',
</span><span class="cx" style="display: block; padding: 0 10px"> 'TR',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'TRACK',
</del><span class="cx" style="display: block; padding: 0 10px"> 'XMP', // Deprecated, use PRE instead.
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>