<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57319] trunk: HTML API: Cleanup tests and list of void elements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57319">57319</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57319","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dmsnell</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-01-20 00:13:19 +0000 (Sat, 20 Jan 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>HTML API: Cleanup tests and list of void elements.
This patch adds newly supported elements to tests that should have been updated
in recent PRs, but which were merged without that. Those PRs removed failing
tests showing that the elements were unsupported, but did not add the elements
to the list of supported ones.
It also removes some elements from the special-exclusion list of unsupported IN
BODY elements. These did not present in failing tests because earlier
conditions in the switch structure caught the tags before hitting the default
block.
Finally it adds some missing elements to the list of void elements. These
elements are not listed as void in the HTML specification because they are
deprecated. However, they are treated as void for the sake of HTML
serialization and the parsing rules indicate that they behave as void elements,
so it's safe to list them within the HTML API as void.
Developed in WordPress/wordpress-develop<a href="https://core.trac.wordpress.org/ticket/5913">#5913</a>
Fixes <a href="https://core.trac.wordpress.org/ticket/60307">#60307</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludeshtmlapiclasswphtmlprocessorphp">trunk/src/wp-includes/html-api/class-wp-html-processor.php</a></li>
<li><a href="#trunktestsphpunittestshtmlapiwpHtmlProcessorBreadcrumbsphp">trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludeshtmlapiclasswphtmlprocessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/html-api/class-wp-html-processor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-01-19 23:58:08 UTC (rev 57318)
+++ trunk/src/wp-includes/html-api/class-wp-html-processor.php 2024-01-20 00:13:19 UTC (rev 57319)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1002,7 +1002,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( $tag_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> case 'APPLET':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'AREA':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'BASE':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'BASEFONT':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'BGSOUND':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1010,8 +1009,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'CAPTION':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'COL':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'COLGROUP':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'DD':
- case 'DT':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'FORM':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'FRAME':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'FRAMESET':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1019,7 +1016,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'HTML':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'IFRAME':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'INPUT':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'LI':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'LINK':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'MARQUEE':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'MATH':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1029,7 +1025,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'NOFRAMES':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'NOSCRIPT':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'OBJECT':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'OL':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'OPTGROUP':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'OPTION':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'PARAM':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1055,7 +1050,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TITLE':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TR':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'TRACK':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'UL':
</del><span class="cx" style="display: block; padding: 0 10px"> case 'XMP':
</span><span class="cx" style="display: block; padding: 0 10px"> $this->last_error = self::ERROR_UNSUPPORTED;
</span><span class="cx" style="display: block; padding: 0 10px"> throw new WP_HTML_Unsupported_Exception( "Cannot process {$tag_name} element." );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1709,9 +1703,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return (
</span><span class="cx" style="display: block; padding: 0 10px"> 'AREA' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'BASE' === $tag_name ||
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'BASEFONT' === $tag_name || // Obsolete but still treated as void.
+ 'BGSOUND' === $tag_name || // Obsolete but still treated as void.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'BR' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'COL' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'EMBED' === $tag_name ||
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'FRAME' === $tag_name ||
</ins><span class="cx" style="display: block; padding: 0 10px"> 'HR' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'IMG' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'INPUT' === $tag_name ||
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1718,6 +1715,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'LINK' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'KEYGEN' === $tag_name || // Obsolete but still treated as void.
</span><span class="cx" style="display: block; padding: 0 10px"> 'META' === $tag_name ||
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'PARAM' === $tag_name || // Obsolete but still treated as void.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'SOURCE' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'TRACK' === $tag_name ||
</span><span class="cx" style="display: block; padding: 0 10px"> 'WBR' === $tag_name
</span></span></pre></div>
<a id="trunktestsphpunittestshtmlapiwpHtmlProcessorBreadcrumbsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php 2024-01-19 23:58:08 UTC (rev 57318)
+++ trunk/tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php 2024-01-20 00:13:19 UTC (rev 57319)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,6 +40,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'ABBR',
</span><span class="cx" style="display: block; padding: 0 10px"> 'ACRONYM', // Neutralized.
</span><span class="cx" style="display: block; padding: 0 10px"> 'ADDRESS',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'AREA',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'ARTICLE',
</span><span class="cx" style="display: block; padding: 0 10px"> 'ASIDE',
</span><span class="cx" style="display: block; padding: 0 10px"> 'AUDIO',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,6 +49,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'BDO',
</span><span class="cx" style="display: block; padding: 0 10px"> 'BIG',
</span><span class="cx" style="display: block; padding: 0 10px"> 'BLINK', // Deprecated.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'BR',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'BUTTON',
</span><span class="cx" style="display: block; padding: 0 10px"> 'CANVAS',
</span><span class="cx" style="display: block; padding: 0 10px"> 'CENTER', // Neutralized.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,6 +67,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'DL',
</span><span class="cx" style="display: block; padding: 0 10px"> 'DT',
</span><span class="cx" style="display: block; padding: 0 10px"> 'EM',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'EMBED',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'FIELDSET',
</span><span class="cx" style="display: block; padding: 0 10px"> 'FIGCAPTION',
</span><span class="cx" style="display: block; padding: 0 10px"> 'FIGURE',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -78,22 +81,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'H6',
</span><span class="cx" style="display: block; padding: 0 10px"> 'HEADER',
</span><span class="cx" style="display: block; padding: 0 10px"> 'HGROUP',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'HR',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'I',
</span><span class="cx" style="display: block; padding: 0 10px"> 'IMG',
</span><span class="cx" style="display: block; padding: 0 10px"> 'INS',
</span><span class="cx" style="display: block; padding: 0 10px"> 'LI',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'ISINDEX', // Deprecated
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'ISINDEX', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'KBD',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'KEYGEN', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'LABEL',
</span><span class="cx" style="display: block; padding: 0 10px"> 'LEGEND',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'LISTING', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'MAIN',
</span><span class="cx" style="display: block; padding: 0 10px"> 'MAP',
</span><span class="cx" style="display: block; padding: 0 10px"> 'MARK',
</span><span class="cx" style="display: block; padding: 0 10px"> 'MENU',
</span><span class="cx" style="display: block; padding: 0 10px"> 'METER',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'MULTICOL', // Deprecated
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'MULTICOL', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'NAV',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'NEXTID', // Deprecated
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'NEXTID', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'OL',
</span><span class="cx" style="display: block; padding: 0 10px"> 'OUTPUT',
</span><span class="cx" style="display: block; padding: 0 10px"> 'P',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,7 +112,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'SECTION',
</span><span class="cx" style="display: block; padding: 0 10px"> 'SLOT',
</span><span class="cx" style="display: block; padding: 0 10px"> 'SMALL',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'SPACER', // Deprecated
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'SPACER', // Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'SPAN',
</span><span class="cx" style="display: block; padding: 0 10px"> 'STRIKE',
</span><span class="cx" style="display: block; padding: 0 10px"> 'STRONG',
</span></span></pre>
</div>
</div>
</body>
</html>