<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57214] branches/6.4: Build/Test Tools: Raise minimum required version of Node.js/npm.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57214">57214</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57214","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-12-20 18:59:17 +0000 (Wed, 20 Dec 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Raise minimum required version of Node.js/npm.
This bumps the minimum required version of Node.js/npm from 16.19.1 and 8.19.3 to 20.10.0 and 10.2.3.
Since 20.10.0 is the latest 20.x version of Node.js, the check-latest option has been enabled for actions/setup-node in GitHub Actions workflows. This performs an additional external call to the Node.js API confirming the latest version is installed on the runner for use. In testing, it seems that 20.10.0 was not consistently deployed to all runner machines in use. This should be removed in the near future when the version of Node.js is reliably above the new minimum requirement.
The Gutenberg repository has also been updated to use the same values for engines.
Merges <a href="https://core.trac.wordpress.org/changeset/57212">[57212]</a> to the 6.4 branch.
Props jorbin, joemcgill, swissspidy, benharri, dhrupo, flootr, gziolo, noahtallen.
See <a href="https://core.trac.wordpress.org/ticket/59663">#59663</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches64githubworkflowsperformanceyml">branches/6.4/.github/workflows/performance.yml</a></li>
<li><a href="#branches64githubworkflowstestnpmyml">branches/6.4/.github/workflows/test-npm.yml</a></li>
<li><a href="#branches64nvmrc">branches/6.4/.nvmrc</a></li>
<li><a href="#branches64READMEmd">branches/6.4/README.md</a></li>
<li><a href="#branches64packagelockjson">branches/6.4/package-lock.json</a></li>
<li><a href="#branches64packagejson">branches/6.4/package.json</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches64">branches/6.4/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/6.4
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/6.4 2023-12-20 18:50:08 UTC (rev 57213)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/6.4 2023-12-20 18:59:17 UTC (rev 57214)
</ins><a id="branches64"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/6.4</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43785,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44231-44232,44235,44248,44284,44287-44288
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.5:49373-49379,49381
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.8:51889
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:56974,56978,56984,56987,56990-56992,56996,56999,57003,57009,57012-57013,57018-57019,57021-57022,57028-57029,57032-57034,57036,57044,57046,57048,57054,57063,57066-57067,57069,57075,57081,57084,57086,57089,57093,57102,57129,57147,57151,57163
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:56974,56978,56984,56987,56990-56992,56996,56999,57003,57009,57012-57013,57018-57019,57021-57022,57028-57029,57032-57034,57036,57044,57046,57048,57054,57063,57066-57067,57069,57075,57081,57084,57086,57089,57093,57102,57129,57147,57151,57163,57212
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches64githubworkflowsperformanceyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/.github/workflows/performance.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/.github/workflows/performance.yml 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/.github/workflows/performance.yml 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -71,11 +71,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # - Run performance tests (current commit).
</span><span class="cx" style="display: block; padding: 0 10px"> # - Print performance tests results.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Check out target commit (target branch or previous commit).
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Switch Node.js versions if necessary.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Install npm dependencies.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Build WordPress.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Run performance tests (previous/target commit).
</span><span class="cx" style="display: block; padding: 0 10px"> # - Print target performance tests results.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Reset to original commit.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Switch Node.js versions if necessary.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Install npm dependencies.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Set the environment to the baseline version.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Run baseline performance tests.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -182,6 +184,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fi
</span><span class="cx" style="display: block; padding: 0 10px"> git reset --hard $TARGET_SHA
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Install npm dependencies
</span><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -201,6 +209,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Reset to original commit
</span><span class="cx" style="display: block; padding: 0 10px"> run: git reset --hard $GITHUB_SHA
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Install npm dependencies
</span><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="branches64githubworkflowstestnpmyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/.github/workflows/test-npm.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/.github/workflows/test-npm.yml 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/.github/workflows/test-npm.yml 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -76,6 +76,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ check-latest: true
</ins><span class="cx" style="display: block; padding: 0 10px"> cache: npm
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -144,6 +145,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ check-latest: true
</ins><span class="cx" style="display: block; padding: 0 10px"> cache: npm
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span></span></pre></div>
<a id="branches64nvmrc"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/.nvmrc</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/.nvmrc 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/.nvmrc 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1 +1 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-16
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+20
</ins></span></pre></div>
<a id="branches64READMEmd"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/README.md</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/README.md 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/README.md 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,7 +35,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> If you are not using a package manager, see the [Node.js download page](https://nodejs.org/en/download/) for installers and binaries.
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-**Note:** WordPress currently only officially supports Node.js `16.x` and npm `8.x`.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+**Note:** WordPress currently only officially supports Node.js `20.x` and npm `10.x`.
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> You will also need [Docker](https://www.docker.com/products/docker-desktop) installed and running on your computer. Docker is the virtualization software that powers the local development environment. Docker can be installed just like any other regular application.
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="branches64packagelockjson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/package-lock.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/package-lock.json 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/package-lock.json 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -159,8 +159,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "webpack-livereload-plugin": "3.0.2"
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> "engines": {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "node": ">=16.19.1",
- "npm": ">=8.19.3 <9"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "node": ">=20.10.0",
+ "npm": ">=10.2.3"
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> "node_modules/@aashutoshrathi/word-wrap": {
</span></span></pre></div>
<a id="branches64packagejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/package.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/package.json 2023-12-20 18:50:08 UTC (rev 57213)
+++ branches/6.4/package.json 2023-12-20 18:59:17 UTC (rev 57214)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7,8 +7,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "url": "https://develop.svn.wordpress.org/trunk"
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> "engines": {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "node": ">=16.19.1",
- "npm": ">=8.19.3 <9"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "node": ">=20.10.0",
+ "npm": ">=10.2.3"
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> "author": "The WordPress Contributors",
</span><span class="cx" style="display: block; padding: 0 10px"> "license": "GPL-2.0-or-later",
</span></span></pre>
</div>
</div>
</body>
</html>