<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[57094] branches/6.4/src/wp-admin: Quick/Bulk Edit: Prevent assigning posts to default categories during bulk edit.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/57094">57094</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/57094","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>peterwilsoncc</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-11-08 23:23:10 +0000 (Wed, 08 Nov 2023)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Quick/Bulk Edit: Prevent assigning posts to default categories during bulk edit.

During a bulk edit of posts with different categories, the categories for the edited posts would be reset to the default category: uncategorized by default.

This reverts <a href="https://core.trac.wordpress.org/changeset/56712">[56712]</a> to resolve the issue.

Merges <a href="https://core.trac.wordpress.org/changeset/57093">[57093]</a> to the 6.4 branch.

Props peterwilsoncc, hellofromtonya, jorbin.
Fixes <a href="https://core.trac.wordpress.org/ticket/59837">#59837</a>.
See <a href="https://core.trac.wordpress.org/ticket/11302">#11302</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branches64srcjs_enqueuesadmininlineeditpostjs">branches/6.4/src/js/_enqueues/admin/inline-edit-post.js</a></li>
<li><a href="#branches64srcwpadmincsslisttablescss">branches/6.4/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#branches64srcwpadminincludespostphp">branches/6.4/src/wp-admin/includes/post.php</a></li>
</ul>

<h3>Property Changed</h3>
<ul>
<li><a href="#branches64">branches/6.4/</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/6.4
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/6.4 2023-11-08 23:20:33 UTC (rev 57093)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/6.4  2023-11-08 23:23:10 UTC (rev 57094)
</ins><a id="branches64"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/6.4</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43785,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44231-44232,44235,44248,44284,44287-44288
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.5:49373-49379,49381
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.8:51889
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:56974,56978,56984,56987,56990-56992,56996,56999,57003,57009,57012-57013,57018-57019,57021-57022,57028-57029,57032-57034,57036,57044,57046,57048,57054,57063,57066-57067,57069,57075,57084,57086,57089
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:56974,56978,56984,56987,56990-56992,56996,56999,57003,57009,57012-57013,57018-57019,57021-57022,57028-57029,57032-57034,57036,57044,57046,57048,57054,57063,57066-57067,57069,57075,57084,57086,57089,57093
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches64srcjs_enqueuesadmininlineeditpostjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/src/js/_enqueues/admin/inline-edit-post.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/src/js/_enqueues/admin/inline-edit-post.js   2023-11-08 23:20:33 UTC (rev 57093)
+++ branches/6.4/src/js/_enqueues/admin/inline-edit-post.js     2023-11-08 23:23:10 UTC (rev 57094)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -178,9 +178,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        setBulk : function(){
</span><span class="cx" style="display: block; padding: 0 10px">                var te = '', type = this.type, c = true;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                var checkedPosts = $( 'tbody th.check-column input[type="checkbox"]:checked' );
-               var categories = {};
-               var indeterminatePostCategoryField = $( '<input type="hidden" name="indeterminate_post_category[]">' );
</del><span class="cx" style="display: block; padding: 0 10px">                 this.revert();
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $( '#bulk-edit td' ).attr( 'colspan', $( 'th:visible, td:visible', '.widefat:first thead' ).length );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -220,45 +217,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">                // Populate the list of items to bulk edit.
</span><span class="cx" style="display: block; padding: 0 10px">                $( '#bulk-titles' ).html( '<ul id="bulk-titles-list" role="list">' + te + '</ul>' );
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                // Gather up some statistics on which of these checked posts are in which categories.
-               checkedPosts.each( function() {
-                       var id      = $( this ).val();
-                       var checked = $( '#category_' + id ).text().split( ',' );
-
-                       checked.map( function( cid ) {
-                               categories[ cid ] || ( categories[ cid ] = 0 );
-                               // Just record that this category is checked.
-                               categories[ cid ]++;
-                       } );
-               } );
-
-               // Compute initial states.
-               $( '.inline-edit-categories input[name="post_category[]"]' ).each( function() {
-                       // Clear indeterminate states.
-                       $( '<input type="hidden" name="indeterminate_post_category[]">' ).remove();
-
-                       if ( categories[ $( this ).val() ] == checkedPosts.length ) {
-                               // If the number of checked categories matches the number of selected posts, then all posts are in this category.
-                               $( this ).prop( 'checked', true );
-                       } else if ( categories[ $( this ).val() ] > 0 ) {
-                               // If the number is less than the number of selected posts, then it's indeterminate.
-                               $( this ).prop( 'indeterminate', true );
-
-                               // Set indeterminate states for the backend.
-                               indeterminatePostCategoryField.val( $( this ).val() );
-                               $( this ).after( indeterminatePostCategoryField );
-                       }
-               } );
-
-               $( '.inline-edit-categories input[name="post_category[]"]' ).on( 'change', function() {
-                       // Remove the indeterminate flags as there was a specific state change.
-                       $( this ).parent().find( 'input[name="indeterminate_post_category[]"]' ).remove();
-               } );
-
-               $( '.inline-edit-save button' ).on( 'click', function() {
-                       $( '.inline-edit-categories input[name="post_category[]"]' ).prop( 'indeterminate', false );
-               } );
-
</del><span class="cx" style="display: block; padding: 0 10px">                 /**
</span><span class="cx" style="display: block; padding: 0 10px">                 * Binds on click events to handle the list of items to bulk edit.
</span><span class="cx" style="display: block; padding: 0 10px">                 *
</span></span></pre></div>
<a id="branches64srcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/src/wp-admin/css/list-tables.css     2023-11-08 23:20:33 UTC (rev 57093)
+++ branches/6.4/src/wp-admin/css/list-tables.css       2023-11-08 23:23:10 UTC (rev 57094)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1147,17 +1147,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">        overflow-y: scroll;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
-       content: '';
-       border-top: 2px solid grey;
-       width: 65%;
-       height: 2px;
-       position: absolute;
-       top: calc( 50% + 1px );
-       left: 50%;
-       transform: translate( -50%, -50% );
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> #bulk-titles .ntdelbutton,
</span><span class="cx" style="display: block; padding: 0 10px"> #bulk-titles .ntdeltitle,
</span><span class="cx" style="display: block; padding: 0 10px"> .inline-edit-row fieldset ul.cat-checklist label {
</span></span></pre></div>
<a id="branches64srcwpadminincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/6.4/src/wp-admin/includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/6.4/src/wp-admin/includes/post.php       2023-11-08 23:20:33 UTC (rev 57093)
+++ branches/6.4/src/wp-admin/includes/post.php 2023-11-08 23:23:10 UTC (rev 57094)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -649,21 +649,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                if ( isset( $new_cats ) && in_array( 'category', $tax_names, true ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        $cats = (array) wp_get_post_categories( $post_id );
-
-                       if (
-                               isset( $post_data['indeterminate_post_category'] )
-                               && is_array( $post_data['indeterminate_post_category'] )
-                       ) {
-                               $indeterminate_post_category = $post_data['indeterminate_post_category'];
-                       } else {
-                               $indeterminate_post_category = array();
-                       }
-
-                       $indeterminate_cats         = array_intersect( $cats, $indeterminate_post_category );
-                       $determinate_cats           = array_diff( $new_cats, $indeterminate_post_category );
-                       $post_data['post_category'] = array_unique( array_merge( $indeterminate_cats, $determinate_cats ) );
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 $cats                       = (array) wp_get_post_categories( $post_id );
+                       $post_data['post_category'] = array_unique( array_merge( $cats, $new_cats ) );
</ins><span class="cx" style="display: block; padding: 0 10px">                         unset( $post_data['tax_input']['category'] );
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span></span></pre>
</div>
</div>

</body>
</html>