<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56665] trunk/src/wp-admin: Administration: Switch order of label/checkbox in `WP_List_Table`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56665">56665</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56665","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-09-22 19:56:48 +0000 (Fri, 22 Sep 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Administration: Switch order of label/checkbox in `WP_List_Table`.
Move the label after the checkbox in `WP_List_Table` instances. Resolve a false positive that will be presented by automated accessibility testing tools. Follow up to <a href="https://core.trac.wordpress.org/changeset/55954">[55954]</a>.
Props dimitrism, joedolson, sabernhardt, oglekler, marybaum, tobiasbg.
Fixes <a href="https://core.trac.wordpress.org/ticket/58703">#58703</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswpcommentslisttablephp">trunk/src/wp-admin/includes/class-wp-comments-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplinkslisttablephp">trunk/src/wp-admin/includes/class-wp-links-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmedialisttablephp">trunk/src/wp-admin/includes/class-wp-media-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmssiteslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsthemeslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsuserslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpprivacyrequeststablephp">trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswptermslisttablephp">trunk/src/wp-admin/includes/class-wp-terms-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpuserslisttablephp">trunk/src/wp-admin/includes/class-wp-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminupdatecorephp">trunk/src/wp-admin/update-core.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/css/list-tables.css 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -570,7 +570,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.check-column .label-covers-full-cell {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.check-column label {
+ box-sizing: border-box;
</ins><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> height: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -579,15 +580,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> left: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.check-column .label-covers-full-cell + input {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.check-column input {
</ins><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><span class="cx" style="display: block; padding: 0 10px"> z-index: 1;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.check-column .label-covers-full-cell:hover + input {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.check-column input:where(:not(:disabled)):hover,
+.check-column:hover input:where(:not(:disabled)) {
</ins><span class="cx" style="display: block; padding: 0 10px"> box-shadow: 0 0 0 1px #2271b1;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.check-column label:hover,
+.check-column input:hover + label {
+ background: rgba(0, 0, 0, 0.05);
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .locked-indicator {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-left: 6px;
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpcommentslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-comments-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -896,7 +896,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $this->user_can ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="cb-select-<?php echo $comment->comment_ID; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
+ <label for="cb-select-<?php echo $comment->comment_ID; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -904,7 +905,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplinkslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-links-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-links-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-links-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -174,7 +174,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $link = $item;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="cb-select-<?php echo $link->link_id; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" />
+ <label for="cb-select-<?php echo $link->link_id; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Link name. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -182,7 +183,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" name="linkcheck[]" id="cb-select-<?php echo $link->link_id; ?>" value="<?php echo esc_attr( $link->link_id ); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1403,13 +1403,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $columns['cb'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> static $cb_counter = 1;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $columns['cb'] = '<label class="label-covers-full-cell" for="cb-select-all-' . $cb_counter . '">' .
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $columns['cb'] = '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />
+ <label for="cb-select-all-' . $cb_counter . '">' .
</ins><span class="cx" style="display: block; padding: 0 10px"> '<span class="screen-reader-text">' .
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. */
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Select All' ) .
</span><span class="cx" style="display: block; padding: 0 10px"> '</span>' .
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '</label>' .
- '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '</label>';
</ins><span class="cx" style="display: block; padding: 0 10px"> ++$cb_counter;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-media-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-media-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-media-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -419,7 +419,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'edit_post', $post->ID ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="cb-select-<?php echo $post->ID; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
+ <label for="cb-select-<?php echo $post->ID; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Attachment title. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -427,7 +428,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" name="media[]" id="cb-select-<?php echo $post->ID; ?>" value="<?php echo $post->ID; ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmssiteslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -420,7 +420,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_main_site( $blog['blog_id'] ) ) :
</span><span class="cx" style="display: block; padding: 0 10px"> $blogname = untrailingslashit( $blog['domain'] . $blog['path'] );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="blog_<?php echo $blog['blog_id']; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]" value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
+ <label for="blog_<?php echo $blog['blog_id']; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Site URL. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -428,8 +429,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" id="blog_<?php echo $blog['blog_id']; ?>" name="allblogs[]"
- value="<?php echo esc_attr( $blog['blog_id'] ); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> endif;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsthemeslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -513,7 +513,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="<?php echo $checkbox_id; ?>" >
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
+ <label for="<?php echo $checkbox_id; ?>" >
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -524,7 +525,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" name="checked[]" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" id="<?php echo $checkbox_id; ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsuserslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -235,7 +235,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="blog_<?php echo $user->ID; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" />
+ <label for="blog_<?php echo $user->ID; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: User login. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,7 +244,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" id="blog_<?php echo $user->ID; ?>" name="allusers[]" value="<?php echo esc_attr( $user->ID ); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -993,12 +993,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $checkbox = '';
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $checkbox = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<label class="label-covers-full-cell" for="%1$s"><span class="screen-reader-text">%2$s</span></label>' .
- '<input type="checkbox" name="checked[]" value="%3$s" id="%1$s" />',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<input type="checkbox" name="checked[]" value="%1$s" id="%2$s" />' .
+ '<label for="%2$s"><span class="screen-reader-text">%3$s</span></label>',
+ esc_attr( $plugin_file ),
</ins><span class="cx" style="display: block; padding: 0 10px"> $checkbox_id,
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Plugin name. */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- sprintf( __( 'Select %s' ), $plugin_data['Name'] ),
- esc_attr( $plugin_file )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ sprintf( __( 'Select %s' ), $plugin_data['Name'] )
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1034,7 +1034,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> if ( apply_filters( 'wp_list_table_show_post_checkbox', $show, $post ) ) :
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="label-covers-full-cell" for="cb-select-<?php the_ID(); ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
+ <label for="cb-select-<?php the_ID(); ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Post title. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1042,7 +1043,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input id="cb-select-<?php the_ID(); ?>" type="checkbox" name="post[]" value="<?php the_ID(); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <div class="locked-indicator">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="locked-indicator-icon" aria-hidden="true"></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpprivacyrequeststablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -416,8 +416,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function column_cb( $item ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<label class="label-covers-full-cell" for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
- '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" /><span class="spinner"></span>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<input type="checkbox" name="request_id[]" id="requester_%1$s" value="%1$s" />' .
+ '<label for="requester_%1$s"><span class="screen-reader-text">%2$s</span></label><span class="spinner"></span>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_attr( $item->ID ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Email address. */
</span><span class="cx" style="display: block; padding: 0 10px"> sprintf( __( 'Select %s' ), $item->email )
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswptermslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-terms-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-terms-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-terms-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -364,8 +364,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'delete_term', $tag->term_id ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<label class="label-covers-full-cell" for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>' .
- '<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<input type="checkbox" name="delete_tags[]" value="%1$s" id="cb-select-%1$s" />' .
+ '<label for="cb-select-%1$s"><span class="screen-reader-text">%2$s</span></label>',
</ins><span class="cx" style="display: block; padding: 0 10px"> $tag->term_id,
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Taxonomy term name. */
</span><span class="cx" style="display: block; padding: 0 10px"> sprintf( __( 'Select %s' ), $tag->name )
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpuserslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-users-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-users-list-table.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/includes/class-wp-users-list-table.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -524,12 +524,12 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set up the checkbox (because the user is editable, otherwise it's empty).
</span><span class="cx" style="display: block; padding: 0 10px"> $checkbox = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<label class="label-covers-full-cell" for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
- '<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<input type="checkbox" name="users[]" id="user_%1$s" class="%2$s" value="%1$s" />' .
+ '<label for="user_%1$s"><span class="screen-reader-text">%3$s</span></label>',
</ins><span class="cx" style="display: block; padding: 0 10px"> $user_object->ID,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $role_classes,
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: User login. */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- sprintf( __( 'Select %s' ), $user_object->user_login ),
- $role_classes
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ sprintf( __( 'Select %s' ), $user_object->user_login )
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span></span></pre></div>
<a id="trunksrcwpadminupdatecorephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/update-core.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/update-core.php 2023-09-22 19:06:45 UTC (rev 56664)
+++ trunk/src/wp-admin/update-core.php 2023-09-22 19:56:48 UTC (rev 56665)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -582,7 +582,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="check-column">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $compatible_php ) : ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
+ <label for="<?php echo $checkbox_id; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Plugin name. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -590,7 +591,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="plugin-title"><p>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -760,7 +760,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="check-column">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $compatible_wp && $compatible_php ) : ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
+ <label for="<?php echo $checkbox_id; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Hidden accessibility text. %s: Theme name. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -768,7 +769,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
</del><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="plugin-title"><p>
</span></span></pre>
</div>
</div>
</body>
</html>