<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56648] trunk/tests/phpunit/tests/option/option.php: Options, Meta APIs: Add further test coverage for comparison between old and new option value.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56648">56648</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56648","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>flixos90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-09-21 15:21:45 +0000 (Thu, 21 Sep 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Options, Meta APIs: Add further test coverage for comparison between old and new option value.
This ensures potential future changes to the logic are covered by existing tests that should pass before and after.
Props joemcgill.
See <a href="https://core.trac.wordpress.org/ticket/22192">#22192</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsoptionoptionphp">trunk/tests/phpunit/tests/option/option.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsoptionoptionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/option/option.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/option/option.php 2023-09-21 13:24:50 UTC (rev 56647)
+++ trunk/tests/phpunit/tests/option/option.php 2023-09-21 15:21:45 UTC (rev 56648)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -368,4 +368,160 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'autoload_false', false, 'no' ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Ensure the database is getting updated when type changes, but not otherwise.
+ *
+ * @ticket 22192
+ *
+ * @covers ::update_option
+ *
+ * @dataProvider data_update_option_type_juggling
+ */
+ public function test_update_loosey_options( $old_value, $new_value, $update = false ) {
+ add_option( 'foo', $old_value );
+
+ // Comparison will happen against value cached during add_option() above.
+ $updated = update_option( 'foo', $new_value );
+
+ if ( $update ) {
+ $this->assertTrue( $updated, 'This loosely equal option should trigger an update.' );
+ } else {
+ $this->assertFalse( $updated, 'Loosely equal option should not trigger an update.' );
+ }
+ }
+
+ /**
+ * Ensure the database is getting updated when type changes, but not otherwise.
+ *
+ * @ticket 22192
+ *
+ * @covers ::update_option
+ *
+ * @dataProvider data_update_option_type_juggling
+ */
+ public function test_update_loosey_options_from_db( $old_value, $new_value, $update = false ) {
+ add_option( 'foo', $old_value );
+
+ // Delete cache.
+ wp_cache_delete( 'alloptions', 'options' );
+ $updated = update_option( 'foo', $new_value );
+
+ if ( $update ) {
+ $this->assertTrue( $updated, 'This loosely equal option should trigger an update.' );
+ } else {
+ $this->assertFalse( $updated, 'Loosely equal option should not trigger an update.' );
+ }
+ }
+
+ /**
+ * Ensure the database is getting updated when type changes, but not otherwise.
+ *
+ * @ticket 22192
+ *
+ * @covers ::update_option
+ *
+ * @dataProvider data_update_option_type_juggling
+ */
+ public function test_update_loosey_options_from_refreshed_cache( $old_value, $new_value, $update = false ) {
+ add_option( 'foo', $old_value );
+
+ // Delete and refresh cache from DB.
+ wp_cache_delete( 'alloptions', 'options' );
+ wp_load_alloptions();
+
+ $updated = update_option( 'foo', $new_value );
+
+ if ( $update ) {
+ $this->assertTrue( $updated, 'This loosely equal option should trigger an update.' );
+ } else {
+ $this->assertFalse( $updated, 'Loosely equal option should not trigger an update.' );
+ }
+ }
+
+
+ /**
+ * Data provider.
+ *
+ * @return array
+ */
+ public function data_update_option_type_juggling() {
+ return array(
+ /*
+ * Truthy values.
+ * Loosely equal truthy scalar values should never result in a DB update.
+ */
+ array( '1', '1' ),
+ array( '1', 1 ),
+ array( '1', 1.0 ),
+ array( '1', true ),
+ array( 1, '1' ),
+ array( 1, 1 ),
+ array( 1, 1.0 ),
+ array( 1, true ),
+ array( 1.0, '1' ),
+ array( 1.0, 1 ),
+ array( 1.0, 1.0 ),
+ array( 1.0, true ),
+ array( true, '1' ),
+ array( true, 1 ),
+ array( true, 1.0 ),
+ array( true, true ),
+
+ /*
+ * Falsey values.
+ * Loosely equal falsey scalar values only sometimes result in a DB update.
+ */
+ array( '0', '0' ),
+ array( '0', 0 ),
+ array( '0', 0.0 ),
+ array( '0', false, true ), // Should update.
+ array( '', '' ),
+ array( '', 0, true ), // Should update.
+ array( '', 0.0, true ), // Should update.
+ array( '', false ),
+ array( 0, '0' ),
+ array( 0, '', true ), // Should update.
+ array( 0, 0 ),
+ array( 0, 0.0 ),
+ array( 0, false, true ), // Should update.
+ array( 0.0, '0' ),
+ array( 0.0, '', true ), // Should update.
+ array( 0.0, 0 ),
+ array( 0.0, 0.0 ),
+ array( 0.0, false, true ), // Should update.
+ array( false, '0', true ), // Should update.
+ array( false, '' ),
+ array( false, 0, true ), // Should update.
+ array( false, 0.0, true ), // Should update.
+ array( false, false ),
+
+ /*
+ * Non scalar values.
+ * Loosely equal non-scalar values should almost always result in an update.
+ */
+ array( false, array(), true ),
+ array( 'false', array(), true ),
+ array( '', array(), true ),
+ array( 0, array(), true ),
+ array( '0', array(), true ),
+ array( false, null ), // Does not update.
+ array( 'false', null, true ),
+ array( '', null ), // Does not update.
+ array( 0, null, true ),
+ array( '0', null, true ),
+ array( array(), false, true ),
+ array( array(), 'false', true ),
+ array( array(), '', true ),
+ array( array(), 0, true ),
+ array( array(), '0', true ),
+ array( array(), null, true ),
+ array( null, false ), // Does not update.
+ array( null, 'false', true ),
+ array( null, '' ), // Does not update.
+ array( null, 0, true ),
+ array( null, '0', true ),
+ array( null, array(), true ),
+ );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>