<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56616] trunk/tests/phpunit/tests: Coding Standards: Replace PHP alias `join()` with `implode()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56616">56616</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56616","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>costdev</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-09-19 12:23:16 +0000 (Tue, 19 Sep 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Replace PHP alias `join()` with `implode()`.
In <a href="https://core.trac.wordpress.org/changeset/52190">[52190]</a>, some new instances of the `join()` alias were introduced in the test suite.
Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.
This replaces the new `join()` uses with the canonical `implode()` function name.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/46182">[46182]</a>, <a href="https://core.trac.wordpress.org/changeset/49193">[49193]</a>, <a href="https://core.trac.wordpress.org/changeset/49805">[49805]</a>, <a href="https://core.trac.wordpress.org/changeset/52190">[52190]</a>.
Props david.binda, mukesh27.
Fixes <a href="https://core.trac.wordpress.org/ticket/59389">#59389</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsmediagetPostGalleriesphp">trunk/tests/phpunit/tests/media/getPostGalleries.php</a></li>
<li><a href="#trunktestsphpunittestsmediaphp">trunk/tests/phpunit/tests/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsmediagetPostGalleriesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media/getPostGalleries.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media/getPostGalleries.php 2023-09-19 01:43:07 UTC (rev 56615)
+++ trunk/tests/phpunit/tests/media/getPostGalleries.php 2023-09-19 12:23:16 UTC (rev 56616)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -575,7 +575,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids_joined = join( ',', $ids );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids_joined = implode( ',', $ids );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $global_post_id = self::factory()->post->create(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -844,8 +844,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
- $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+ $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> [gallery ids="$ids1_joined"]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -907,8 +907,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
- $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+ $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> [gallery ids="$ids1_joined" type="type" foo="bar"]
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media.php 2023-09-19 01:43:07 UTC (rev 56615)
+++ trunk/tests/phpunit/tests/media.php 2023-09-19 12:23:16 UTC (rev 56616)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -552,8 +552,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $ids2_srcs[] = 'http://' . WP_TESTS_DOMAIN . '/wp-content/uploads/' . "image$i.jpg";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids1_joined = join( ',', array_slice( $ids1, 0, 3 ) );
- $ids2_joined = join( ',', array_slice( $ids2, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids1_joined = implode( ',', array_slice( $ids1, 0, 3 ) );
+ $ids2_joined = implode( ',', array_slice( $ids2, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> [gallery ids="$ids1_joined"]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -638,8 +638,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $imgs[] = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $imgs1_joined = join( "\n", array_slice( $imgs, 0, 3 ) );
- $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $imgs1_joined = implode( "\n", array_slice( $imgs, 0, 3 ) );
+ $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- wp:gallery -->
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -677,8 +677,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids1_joined = join( ',', array_slice( $ids, 0, 3 ) );
- $ids2_joined = join( ',', array_slice( $ids, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids1_joined = implode( ',', array_slice( $ids, 0, 3 ) );
+ $ids2_joined = implode( ',', array_slice( $ids, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- wp:gallery {"ids":[$ids1_joined]} -->
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -718,9 +718,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $imgs[] = '<figure><img src="' . $url . '" data-id="' . $i . '" /></figure>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $ids1_joined = join( "\n", array_slice( $ids, 0, 3 ) );
- $ids2_joined = join( "\n", array_slice( $ids, 3, 3 ) );
- $imgs2_joined = join( "\n", array_slice( $imgs, 3, 3 ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $ids1_joined = implode( "\n", array_slice( $ids, 0, 3 ) );
+ $ids2_joined = implode( "\n", array_slice( $ids, 3, 3 ) );
+ $imgs2_joined = implode( "\n", array_slice( $imgs, 3, 3 ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> [gallery ids="$ids1_joined"]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -762,7 +762,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $imgs_joined = join( "\n", $imgs );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $imgs_joined = implode( "\n", $imgs );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- wp:columns -->
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -805,7 +805,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $imgs_joined = join( "\n", $imgs );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $imgs_joined = implode( "\n", $imgs );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $blob = <<<BLOB
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- wp:gallery -->
</span></span></pre>
</div>
</div>
</body>
</html>