<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56605] trunk/src/wp-includes: Editor: add text orientation for blocks with typography support.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56605">56605</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56605","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>isabel_brison</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-09-18 06:47:44 +0000 (Mon, 18 Sep 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Editor: add text orientation for blocks with typography support.
Adds a new text orientation option to the typography block support, implemented with CSS writing-mode.
Props poena.
Fixes <a href="https://core.trac.wordpress.org/ticket/59306">#59306</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesblocksupportstypographyphp">trunk/src/wp-includes/block-supports/typography.php</a></li>
<li><a href="#trunksrcwpincludesclasswpthemejsonphp">trunk/src/wp-includes/class-wp-theme-json.php</a></li>
<li><a href="#trunksrcwpincludesthemejson">trunk/src/wp-includes/theme.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesblocksupportstypographyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/block-supports/typography.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/block-supports/typography.php 2023-09-18 06:25:49 UTC (rev 56604)
+++ trunk/src/wp-includes/block-supports/typography.php 2023-09-18 06:47:44 UTC (rev 56605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,6 +34,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_columns_support = _wp_array_get( $typography_supports, array( 'textColumns' ), false );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_decoration_support = _wp_array_get( $typography_supports, array( '__experimentalTextDecoration' ), false );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_transform_support = _wp_array_get( $typography_supports, array( '__experimentalTextTransform' ), false );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $has_writing_mode_support = _wp_array_get( $typography_supports, array( '__experimentalWritingMode' ), false );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $has_typography_support = $has_font_family_support
</span><span class="cx" style="display: block; padding: 0 10px"> || $has_font_size_support
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,7 +44,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> || $has_line_height_support
</span><span class="cx" style="display: block; padding: 0 10px"> || $has_text_columns_support
</span><span class="cx" style="display: block; padding: 0 10px"> || $has_text_decoration_support
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- || $has_text_transform_support;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ || $has_text_transform_support
+ || $has_writing_mode_support;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $block_type->attributes ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $block_type->attributes = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,6 +107,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_columns_support = _wp_array_get( $typography_supports, array( 'textColumns' ), false );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_decoration_support = _wp_array_get( $typography_supports, array( '__experimentalTextDecoration' ), false );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_text_transform_support = _wp_array_get( $typography_supports, array( '__experimentalTextTransform' ), false );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $has_writing_mode_support = _wp_array_get( $typography_supports, array( '__experimentalWritingMode' ), false );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Whether to skip individual block support features.
</span><span class="cx" style="display: block; padding: 0 10px"> $should_skip_font_size = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'fontSize' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -116,6 +119,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $should_skip_text_decoration = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'textDecoration' );
</span><span class="cx" style="display: block; padding: 0 10px"> $should_skip_text_transform = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'textTransform' );
</span><span class="cx" style="display: block; padding: 0 10px"> $should_skip_letter_spacing = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'letterSpacing' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $should_skip_writing_mode = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'writingMode' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $typography_block_styles = array();
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $has_font_size_support && ! $should_skip_font_size ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -205,6 +209,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $has_writing_mode_support &&
+ ! $should_skip_writing_mode &&
+ isset( $block_attributes['style']['typography']['writingMode'] )
+ ) {
+ $typography_block_styles['writingMode'] = _wp_array_get(
+ $block_attributes,
+ array( 'style', 'typography', 'writingMode' ),
+ null
+ );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $attributes = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $styles = wp_style_engine_get_styles(
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'typography' => $typography_block_styles ),
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpthemejsonphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-theme-json.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-theme-json.php 2023-09-18 06:25:49 UTC (rev 56604)
+++ trunk/src/wp-includes/class-wp-theme-json.php 2023-09-18 06:47:44 UTC (rev 56605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -203,6 +203,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * removed the `--wp--style--block-gap` property.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.2.0 Added `outline-*`, and `min-height` properties.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.3.0 Added `column-count` property.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.4.0 Added `writing-mode` property.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @var array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -261,6 +262,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'text-transform' => array( 'typography', 'textTransform' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'filter' => array( 'filter', 'duotone' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'box-shadow' => array( 'shadow' ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'writing-mode' => array( 'typography', 'writingMode' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -340,7 +342,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.2.0 Added `dimensions.minHeight`, 'shadow.presets', 'shadow.defaultPresets',
</span><span class="cx" style="display: block; padding: 0 10px"> * `position.fixed` and `position.sticky`.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.3.0 Added support for `typography.textColumns`, removed `layout.definitions`.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @since 6.4.0 Added `layout.allowEditing`.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.4.0 Added `layout.allowEditing` and `typography.writingMode`.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @var array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -409,6 +411,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'textColumns' => null,
</span><span class="cx" style="display: block; padding: 0 10px"> 'textDecoration' => null,
</span><span class="cx" style="display: block; padding: 0 10px"> 'textTransform' => null,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'writingMode' => null,
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -471,6 +474,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'textColumns' => null,
</span><span class="cx" style="display: block; padding: 0 10px"> 'textDecoration' => null,
</span><span class="cx" style="display: block; padding: 0 10px"> 'textTransform' => null,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'writingMode' => null,
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'css' => null,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span></span></pre></div>
<a id="trunksrcwpincludesthemejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/theme.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/theme.json 2023-09-18 06:25:49 UTC (rev 56604)
+++ trunk/src/wp-includes/theme.json 2023-09-18 06:47:44 UTC (rev 56605)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -263,7 +263,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "letterSpacing": true,
</span><span class="cx" style="display: block; padding: 0 10px"> "lineHeight": false,
</span><span class="cx" style="display: block; padding: 0 10px"> "textDecoration": true,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "textTransform": true
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "textTransform": true,
+ "writingMode": false
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> "blocks": {
</span><span class="cx" style="display: block; padding: 0 10px"> "core/button": {
</span></span></pre>
</div>
</div>
</body>
</html>