<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56574] trunk: Editor: disable default style engine optimisation.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56574">56574</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56574","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>isabel_brison</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-09-14 04:54:22 +0000 (Thu, 14 Sep 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Editor: disable default style engine optimisation.
Stops style engine from combining CSS selectors by default so that rule order is preserved.
Props ramonopoly, rajinsharwar, timdix, costdev, audrasjb, SergeyBiryukov, JeffPaul, mukesh27.
Fixes <a href="https://core.trac.wordpress.org/ticket/58811">#58811</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
<li><a href="#trunksrcwpincludesstyleengineclasswpstyleengineprocessorphp">trunk/src/wp-includes/style-engine/class-wp-style-engine-processor.php</a></li>
<li><a href="#trunksrcwpincludesstyleengineclasswpstyleenginephp">trunk/src/wp-includes/style-engine/class-wp-style-engine.php</a></li>
<li><a href="#trunksrcwpincludesstyleenginephp">trunk/src/wp-includes/style-engine.php</a></li>
<li><a href="#trunktestsphpunittestsstyleenginestyleEnginephp">trunk/tests/phpunit/tests/style-engine/styleEngine.php</a></li>
<li><a href="#trunktestsphpunittestsstyleenginewpStyleEngineProcessorphp">trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/src/wp-includes/script-loader.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3053,7 +3053,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Default empty array.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $optimize Whether to optimize the CSS output, e.g., combine rules.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Default true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool $prettify Whether to add new lines and indents to output.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default to whether the `SCRIPT_DEBUG` constant is defined.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span></span></pre></div>
<a id="trunksrcwpincludesstyleengineclasswpstyleengineprocessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/style-engine/class-wp-style-engine-processor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/style-engine/class-wp-style-engine-processor.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/src/wp-includes/style-engine/class-wp-style-engine-processor.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,12 +85,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Gets the CSS rules as a string.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 6.1.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.4.0 The Optimization is no longer the default.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $options {
</span><span class="cx" style="display: block; padding: 0 10px"> * Optional. An array of options. Default empty array.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $optimize Whether to optimize the CSS output, e.g. combine rules.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Default true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool $prettify Whether to add new lines and indents to output.
</span><span class="cx" style="display: block; padding: 0 10px"> * Defaults to whether the `SCRIPT_DEBUG` constant is defined.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -98,7 +99,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function get_css( $options = array() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $defaults = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'optimize' => true,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'optimize' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'prettify' => defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $options = wp_parse_args( $options, $defaults );
</span></span></pre></div>
<a id="trunksrcwpincludesstyleengineclasswpstyleenginephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/style-engine/class-wp-style-engine.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/style-engine/class-wp-style-engine.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/src/wp-includes/style-engine/class-wp-style-engine.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -624,7 +624,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * e.g. 'block-supports' or 'global-styles'. Default 'block-supports'.
</span><span class="cx" style="display: block; padding: 0 10px"> * When set, the style engine will attempt to store the CSS rules.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $optimize Whether to optimize the CSS output, e.g. combine rules.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Default true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool $prettify Whether to add new lines and indents to output.
</span><span class="cx" style="display: block; padding: 0 10px"> * Defaults to whether the `SCRIPT_DEBUG` constant is defined.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span></span></pre></div>
<a id="trunksrcwpincludesstyleenginephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/style-engine.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/style-engine.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/src/wp-includes/style-engine.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -130,7 +130,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * e.g. 'block-supports' or 'global-styles'. Default 'block-supports'.
</span><span class="cx" style="display: block; padding: 0 10px"> * When set, the style engine will attempt to store the CSS rules.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $optimize Whether to optimize the CSS output, e.g. combine rules.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Default true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool $prettify Whether to add new lines and indents to output.
</span><span class="cx" style="display: block; padding: 0 10px"> * Defaults to whether the `SCRIPT_DEBUG` constant is defined.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -178,7 +178,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Optional. An array of options. Default empty array.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $optimize Whether to optimize the CSS output, e.g. combine rules.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Default true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool $prettify Whether to add new lines and indents to output.
</span><span class="cx" style="display: block; padding: 0 10px"> * Defaults to whether the `SCRIPT_DEBUG` constant is defined.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span></span></pre></div>
<a id="trunktestsphpunittestsstyleenginestyleEnginephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/style-engine/styleEngine.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/style-engine/styleEngine.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/tests/phpunit/tests/style-engine/styleEngine.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -654,6 +654,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Tests that incoming styles are deduped and merged.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 58811
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 56467
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::wp_style_engine_get_stylesheet_from_css_rules
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -697,6 +698,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $compiled_stylesheet = wp_style_engine_get_stylesheet_from_css_rules( $css_rules, array( 'prettify' => false ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( '.gandalf{color:white;height:190px;border-style:dotted;padding:10px;margin-bottom:100px;}.dumbledore,.rincewind{color:grey;height:90px;border-style:dotted;}', $compiled_stylesheet );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( '.gandalf{color:white;height:190px;border-style:dotted;padding:10px;margin-bottom:100px;}.dumbledore{color:grey;height:90px;border-style:dotted;}.rincewind{color:grey;height:90px;border-style:dotted;}', $compiled_stylesheet );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsstyleenginewpStyleEngineProcessorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php 2023-09-14 02:13:42 UTC (rev 56573)
+++ trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php 2023-09-14 04:54:22 UTC (rev 56574)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -81,16 +81,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $a_wonderful_processor = new WP_Style_Engine_Processor();
</span><span class="cx" style="display: block; padding: 0 10px"> $a_wonderful_processor->add_rules( array( $a_wonderful_css_rule, $a_very_wonderful_css_rule, $a_more_wonderful_css_rule ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '.a-more-wonderful-rule {
- font-family: Wonderful sans;
- font-size: 1em;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '.a-wonderful-rule {
+ color: var(--wonderful-color);
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: orange;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.a-wonderful-rule,
</del><span class="cx" style="display: block; padding: 0 10px"> .a-very_wonderful-rule {
</span><span class="cx" style="display: block; padding: 0 10px"> color: var(--wonderful-color);
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: orange;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.a-more-wonderful-rule {
+ font-family: Wonderful sans;
+ font-size: 1em;
+ background-color: orange;
+}
</ins><span class="cx" style="display: block; padding: 0 10px"> ';
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSameIgnoreEOL(
</span><span class="cx" style="display: block; padding: 0 10px"> $expected,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -184,6 +187,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Tests printing out 'unoptimized' CSS, that is, uncombined selectors and duplicate CSS rules.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * This is the default.
+ *
+ * @ticket 58811
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 56467
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::get_css
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -230,11 +236,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Tests that 'optimized' CSS is output, that is, that duplicate CSS rules are combined under their corresponding selectors.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 58811
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 56467
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::get_css
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_should_optimize_css_output_by_default() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_should_not_optimize_css_output_by_default() {
</ins><span class="cx" style="display: block; padding: 0 10px"> $a_sweet_rule = new WP_Style_Engine_CSS_Rule(
</span><span class="cx" style="display: block; padding: 0 10px"> '.a-sweet-rule',
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -255,14 +262,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $a_sweet_processor->add_rules( array( $a_sweet_rule, $a_sweeter_rule ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '.a-sweet-rule,#an-even-sweeter-rule > marquee{color:var(--sweet-color);background-color:purple;}',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '.a-sweet-rule{color:var(--sweet-color);background-color:purple;}#an-even-sweeter-rule > marquee{color:var(--sweet-color);background-color:purple;}',
</ins><span class="cx" style="display: block; padding: 0 10px"> $a_sweet_processor->get_css( array( 'prettify' => false ) )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Tests that incoming CSS rules are merged with existing CSS rules.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that incoming CSS rules are optimized and merged with existing CSS rules.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 58811
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 56467
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::add_rules
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -286,7 +294,12 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame(
</span><span class="cx" style="display: block; padding: 0 10px"> '.a-lovely-rule,.a-lovelier-rule{border-color:purple;}',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $a_lovely_processor->get_css( array( 'prettify' => false ) ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $a_lovely_processor->get_css(
+ array(
+ 'prettify' => false,
+ 'optimize' => true,
+ )
+ ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'Return value of get_css() does not match expectations when combining 2 CSS rules'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -308,7 +321,12 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame(
</span><span class="cx" style="display: block; padding: 0 10px"> '.a-lovely-rule,.a-lovelier-rule,.a-most-lovely-rule,.a-perfectly-lovely-rule{border-color:purple;}',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $a_lovely_processor->get_css( array( 'prettify' => false ) ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $a_lovely_processor->get_css(
+ array(
+ 'prettify' => false,
+ 'optimize' => true,
+ )
+ ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'Return value of get_css() does not match expectations when combining 4 CSS rules'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>