<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56252] trunk/src/js/_enqueues/vendor/farbtastic.js: External Libraries: Update deprecated jQuery code in Farbtastic lib.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56252">56252</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56252","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>audrasjb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-07-17 22:01:08 +0000 (Mon, 17 Jul 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>External Libraries: Update deprecated jQuery code in Farbtastic lib.
This changeset updates some deprecated jQuery code in the Farbtastic external library. As this vendor script is not maintained anymore, this changeset
also adds a docblock to specify that the library has been "adopted" by WP Core.
Props Malae, sabernhardt, SergeyBiryukov, Presskopp, mrinal013, peterwilsoncc, oglekler, jorbin.
Fixes <a href="https://core.trac.wordpress.org/ticket/57946">#57946</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesvendorfarbtasticjs">trunk/src/js/_enqueues/vendor/farbtastic.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesvendorfarbtasticjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/vendor/farbtastic.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/vendor/farbtastic.js 2023-07-17 21:32:47 UTC (rev 56251)
+++ trunk/src/js/_enqueues/vendor/farbtastic.js 2023-07-17 22:01:08 UTC (rev 56252)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,9 +1,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /*!
</span><span class="cx" style="display: block; padding: 0 10px"> * Farbtastic: jQuery color picker plug-in v1.3u
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * https://github.com/mattfarina/farbtastic
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Licensed under the GPL license:
</span><span class="cx" style="display: block; padding: 0 10px"> * http://www.gnu.org/licenses/gpl.html
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+ * Modified for WordPress: replaced deprecated jQuery methods.
+ * See https://core.trac.wordpress.org/ticket/57946.
+ */
+
</ins><span class="cx" style="display: block; padding: 0 10px"> (function($) {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $.fn.farbtastic = function (options) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,7 +55,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fb.linkTo = function (callback) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Unbind previous nodes
</span><span class="cx" style="display: block; padding: 0 10px"> if (typeof fb.callback == 'object') {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $(fb.callback).unbind('keyup', fb.updateValue);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $(fb.callback).off('keyup', fb.updateValue);
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Reset color
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -61,7 +67,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> else if (typeof callback == 'object' || typeof callback == 'string') {
</span><span class="cx" style="display: block; padding: 0 10px"> fb.callback = $(callback);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- fb.callback.bind('keyup', fb.updateValue);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ fb.callback.on('keyup', fb.updateValue);
</ins><span class="cx" style="display: block; padding: 0 10px"> if (fb.callback.get(0).value) {
</span><span class="cx" style="display: block; padding: 0 10px"> fb.setColor(fb.callback.get(0).value);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -116,7 +122,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> fb.mousedown = function (event) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Capture mouse
</span><span class="cx" style="display: block; padding: 0 10px"> if (!document.dragging) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $(document).bind('mousemove', fb.mousemove).bind('mouseup', fb.mouseup);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $(document).on('mousemove', fb.mousemove).on('mouseup', fb.mouseup);
</ins><span class="cx" style="display: block; padding: 0 10px"> document.dragging = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -155,8 +161,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> fb.mouseup = function () {
</span><span class="cx" style="display: block; padding: 0 10px"> // Uncapture mouse
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $(document).unbind('mousemove', fb.mousemove);
- $(document).unbind('mouseup', fb.mouseup);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $(document).off('mousemove', fb.mousemove);
+ $(document).off('mouseup', fb.mouseup);
</ins><span class="cx" style="display: block; padding: 0 10px"> document.dragging = false;
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -262,7 +268,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Install mousedown handler (the others are set on the document on-demand)
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('*', e).mousedown(fb.mousedown);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('*', e).on('mousedown', fb.mousedown);
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Init color
</span><span class="cx" style="display: block; padding: 0 10px"> fb.setColor('#000000');
</span></span></pre>
</div>
</div>
</body>
</html>