<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56247] trunk: Build Tools: Remove outmoded jsvalidate task from Gruntfile.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56247">56247</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56247","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>kadamwhite</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-07-17 14:05:51 +0000 (Mon, 17 Jul 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build Tools: Remove outmoded jsvalidate task from Gruntfile.
grunt-jsvalidate was added to catch situations where minification introduced parsing errors in Internet Explorer.
IE is no longer supported by WordPress, and the grunt task itself has not been maintained for a decade.
Removing this task simplifies the build and avoids false-positive warnings where the outdated tool flags modern JS syntax incorrectly.
Props westonruter, joemcgill, jorbin, youknowriad, desrosj, swissspidy.
Fixes <a href="https://core.trac.wordpress.org/ticket/58645">#58645</a>. See <a href="https://core.trac.wordpress.org/ticket/26615">#26615</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
<li><a href="#trunkpackagelockjson">trunk/package-lock.json</a></li>
<li><a href="#trunkpackagejson">trunk/package.json</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/Gruntfile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/Gruntfile.js 2023-07-17 14:04:00 UTC (rev 56246)
+++ trunk/Gruntfile.js 2023-07-17 14:05:51 UTC (rev 56247)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1036,29 +1036,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jsvalidate:{
- options: {
- globals: {},
- esprimaOptions:{},
- verbose: false
- },
- build: {
- files: {
- src: [
- WORKING_DIR + 'wp-{admin,includes}/**/*.js',
- WORKING_DIR + 'wp-content/themes/twenty*/**/*.js',
- '!' + WORKING_DIR + 'wp-content/themes/twenty*/node_modules/**/*.js',
- '!' + WORKING_DIR + 'wp-includes/blocks/**/*.js',
- '!' + WORKING_DIR + 'wp-includes/js/dist/**/*.js',
- ]
- }
- },
- dynamic: {
- files: {
- src: []
- }
- }
- },
</del><span class="cx" style="display: block; padding: 0 10px"> imagemin: {
</span><span class="cx" style="display: block; padding: 0 10px"> core: {
</span><span class="cx" style="display: block; padding: 0 10px"> expand: true,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1191,7 +1168,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> 'js-enqueues': {
</span><span class="cx" style="display: block; padding: 0 10px"> files: [SOURCE_DIR + 'js/_enqueues/**/*.js'],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- tasks: ['clean:dynamic', 'copy:dynamic-js', 'uglify:dynamic', 'jsvalidate:dynamic'],
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ tasks: ['clean:dynamic', 'copy:dynamic-js', 'uglify:dynamic'],
</ins><span class="cx" style="display: block; padding: 0 10px"> options: {
</span><span class="cx" style="display: block; padding: 0 10px"> dot: true,
</span><span class="cx" style="display: block; padding: 0 10px"> spawn: false
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1203,7 +1180,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '!' + SOURCE_DIR + 'js/_enqueues/**/*.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'webpack-dev.config.js'
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- tasks: ['clean:dynamic', 'webpack:dev', 'uglify:dynamic', 'jsvalidate:dynamic'],
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ tasks: ['clean:dynamic', 'webpack:dev', 'uglify:dynamic'],
</ins><span class="cx" style="display: block; padding: 0 10px"> options: {
</span><span class="cx" style="display: block; padding: 0 10px"> dot: true,
</span><span class="cx" style="display: block; padding: 0 10px"> spawn: false
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1504,8 +1481,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'file_append',
</span><span class="cx" style="display: block; padding: 0 10px"> 'uglify:all',
</span><span class="cx" style="display: block; padding: 0 10px"> 'concat:tinymce',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'concat:emoji',
- 'jsvalidate:build'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'concat:emoji'
</ins><span class="cx" style="display: block; padding: 0 10px"> ] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> grunt.registerTask( 'build:css', [
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1842,7 +1818,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( action !== 'deleted' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> grunt.config( [ 'copy', 'dynamic-js', 'files' ], files );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // For the webpack builds configure the jsvalidate task to only check those files build by webpack.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // For the webpack builds configure the task to only check those files built by webpack.
</ins><span class="cx" style="display: block; padding: 0 10px"> } else if ( target === 'js-webpack' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> src = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-includes/js/media-audiovideo.js',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1870,11 +1846,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // For javascript also minify and validate the changed file.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( target === 'js-enqueues' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> grunt.config( [ 'uglify', 'dynamic', 'src' ], src );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- grunt.config( [ 'jsvalidate', 'dynamic', 'files', 'src' ], src.map( function( dir ) { return WORKING_DIR + dir; } ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ grunt.config( [ 'dynamic', 'files', 'src' ], src.map( function( dir ) { return WORKING_DIR + dir; } ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> // For webpack only validate the file, minification is handled by webpack itself.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( target === 'js-webpack' ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- grunt.config( [ 'jsvalidate', 'dynamic', 'files', 'src' ], src.map( function( dir ) { return WORKING_DIR + dir; } ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ grunt.config( [ 'dynamic', 'files', 'src' ], src.map( function( dir ) { return WORKING_DIR + dir; } ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> // For css run the rtl task on just the changed file.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( target === 'rtl' ) {
</span></span></pre></div>
<a id="trunkpackagelockjson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/package-lock.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/package-lock.json 2023-07-17 14:04:00 UTC (rev 56246)
+++ trunk/package-lock.json 2023-07-17 14:05:51 UTC (rev 56247)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13903,23 +13903,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "grunt-jsvalidate": {
- "version": "0.2.2",
- "resolved": "https://registry.npmjs.org/grunt-jsvalidate/-/grunt-jsvalidate-0.2.2.tgz",
- "integrity": "sha512-FWpPrwspDVc0oZmnraBrLm5yx81gXroTLO4sYZd0iCMXxki/9TzKKhx30iOzTpAUGtUM7Q4rym+Y00MMmijBYQ==",
- "dev": true,
- "requires": {
- "esprima": "~1.0.0"
- },
- "dependencies": {
- "esprima": {
- "version": "1.0.4",
- "resolved": "https://registry.npmjs.org/esprima/-/esprima-1.0.4.tgz",
- "integrity": "sha512-rp5dMKN8zEs9dfi9g0X1ClLmV//WRyk/R15mppFNICIFRG5P92VP7Z04p8pk++gABo9W2tY+kHyu6P1mEHgmTA==",
- "dev": true
- }
- }
- },
</del><span class="cx" style="display: block; padding: 0 10px"> "grunt-known-options": {
</span><span class="cx" style="display: block; padding: 0 10px"> "version": "2.0.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "resolved": "https://registry.npmjs.org/grunt-known-options/-/grunt-known-options-2.0.0.tgz",
</span></span></pre></div>
<a id="trunkpackagejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/package.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/package.json 2023-07-17 14:04:00 UTC (rev 56246)
+++ trunk/package.json 2023-07-17 14:05:51 UTC (rev 56247)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,7 +50,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-watch": "~1.1.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-file-append": "0.0.7",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-jsdoc": "2.4.1",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "grunt-jsvalidate": "~0.2.2",
</del><span class="cx" style="display: block; padding: 0 10px"> "grunt-legacy-util": "^2.0.1",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-patch-wordpress": "~3.0.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-replace-lts": "~1.1.0",
</span></span></pre>
</div>
</div>
</body>
</html>