<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56164] trunk: Media: Avoid programmatically created images within post content from incorrectly receiving `fetchpriority="high"`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56164">56164</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56164","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>flixos90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-07-07 18:06:49 +0000 (Fri, 07 Jul 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Avoid programmatically created images within post content from incorrectly receiving `fetchpriority="high"`.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/56037">[56037]</a>, as that changeset accidentally did not consider the changes made in <a href="https://core.trac.wordpress.org/changeset/55825">[55825]</a>: Images that are programmatically injected into post content (e.g. through a block, or shortcode, or any hook calling a function like `wp_get_attachment_image()`) must be treated as part of the whole post content blob since otherwise the heuristics for applying `fetchpriority="high"` and `loading="lazy"` are skewed by parsing certain images before others rather than sequentially parsing the entire post content. <a href="https://core.trac.wordpress.org/changeset/55825">[55825]</a> addressed that for lazy-loading, but when <a href="https://core.trac.wordpress.org/changeset/56037">[56037]</a> introduced `fetchpriority` support, the related refactor missed making the same consideration for that attribute.
Props flixos90, spacedmonkey, thekt12, mukesh27.
Fixes <a href="https://core.trac.wordpress.org/ticket/58235">#58235</a>.
See <a href="https://core.trac.wordpress.org/ticket/58089">#58089</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesmediaphp">trunk/src/wp-includes/media.php</a></li>
<li><a href="#trunktestsphpunittestsmediaphp">trunk/tests/phpunit/tests/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media.php 2023-07-07 17:51:11 UTC (rev 56163)
+++ trunk/src/wp-includes/media.php 2023-07-07 18:06:49 UTC (rev 56164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5666,11 +5666,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Skip programmatically created images within post content as they need to be handled together with the other
</span><span class="cx" style="display: block; padding: 0 10px"> * images within the post content.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Without this clause, they would already be counted below which skews the number and can result in the first
- * post content image being lazy-loaded only because there are images elsewhere in the post content.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Without this clause, they would already be considered below which skews the image count and can result in
+ * the first post content image being lazy-loaded or an image further down the page being marked as a high
+ * priority.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> if ( doing_filter( 'the_content' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $postprocess( $loading_attrs, true );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return $loading_attrs;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Conditionally skip lazy-loading on images before the loop.
</span></span></pre></div>
<a id="trunktestsphpunittestsmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media.php 2023-07-07 17:51:11 UTC (rev 56163)
+++ trunk/tests/phpunit/tests/media.php 2023-07-07 18:06:49 UTC (rev 56164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4134,19 +4134,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::wp_filter_content_tags
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::wp_get_loading_optimization_attributes
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_wp_filter_content_tags_does_not_lazy_load_special_images_within_the_content() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_wp_filter_content_tags_does_not_apply_loading_optimization_to_special_images_within_the_content() {
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wp_query, $wp_the_query;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Force no lazy-loading on the image tag expected in the content.
- $expected_content = wpautop(
- wp_get_attachment_image(
- self::$large_id,
- 'large',
- false,
- array(
- 'loading' => false,
- 'fetchpriority' => 'high',
- )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Force no lazy-loading or fetchpriority on the image tag expected in the content.
+ $expected_image = wp_get_attachment_image(
+ self::$large_id,
+ 'large',
+ false,
+ array(
+ 'loading' => false,
+ 'fetchpriority' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4153,12 +4151,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Reset high priority flag as the forced `fetchpriority="high"` above already modified it.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->reset_high_priority_element_flag();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $image_within_content = '';
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Overwrite post content with an image.
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter(
</span><span class="cx" style="display: block; padding: 0 10px"> 'the_content',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- static function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ static function() use ( &$image_within_content ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> // Replace content with an image tag, i.e. the 'wp_get_attachment_image' context is used while running 'the_content' filter.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return wp_get_attachment_image( self::$large_id, 'large', false );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $image_within_content = wp_get_attachment_image( self::$large_id, 'large', false );
+ return $image_within_content;
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> 9 // Run before wp_filter_content_tags().
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4178,8 +4179,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $content = get_echo( 'the_content' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Ensure that parsed content has the image without lazy-loading.
- $this->assertSame( $expected_content, $content );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Ensure that parsed image within content does not receive any loading optimization attributes.
+ $this->assertSame( $expected_image, $image_within_content, 'Image with wp_get_attachment_image context within post content should not receive loading optimization attributes' );
+
+ // Ensure that parsed content has the image with fetchpriority as it is the first large image.
+ $expected_content = wpautop( str_replace( '<img ', '<img fetchpriority="high" ', $expected_image ) );
+ $this->assertSame( $expected_content, $content, 'Post content with programmatically injected image is missing loading optimization attributes' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4503,7 +4508,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Tests that wp_get_loading_optimization_attributes() returns false for special contexts when they're used within 'the_content' filter.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that wp_get_loading_optimization_attributes() does not modify any attributes for special contexts when they're used within 'the_content' filter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 58089
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 58235
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4514,7 +4519,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $context Context for the element for which the `loading` attribute value is requested.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_wp_get_loading_optimization_attributes_should_return_false_for_special_contexts_within_the_content( $context ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_wp_get_loading_optimization_attributes_should_not_modify_images_for_special_contexts_within_the_content( $context ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> remove_all_filters( 'the_content' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $result = null;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4528,11 +4533,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> apply_filters( 'the_content', '' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame(
- array( 'fetchpriority' => 'high' ),
- $result,
- 'First large image is loaded with high fetchpriority.'
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( array(), $result );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>