<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[56022] trunk: Quick/Bulk Edit: Don't set publish date when editing drafts.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/56022">56022</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/56022","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-06-25 15:18:12 +0000 (Sun, 25 Jun 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Quick/Bulk Edit: Don't set publish date when editing drafts.
Ensure that quick edit does not define a publish date if the post status is one of 'draft', 'pending', or 'auto-draft'.
Props uxtremist, SergeyBiryukov, Denis-de-Bernardy, jane, rfischmann, mista-flo, rutviksavsani, oglekler, joedolson.
Fixes <a href="https://core.trac.wordpress.org/ticket/19907">#19907</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadmininlineeditpostjs">trunk/src/js/_enqueues/admin/inline-edit-post.js</a></li>
<li><a href="#trunksrcwpadminincludespostphp">trunk/src/wp-admin/includes/post.php</a></li>
<li><a href="#trunktestsphpunittestsajaxwpAjaxInlineSavephp">trunk/tests/phpunit/tests/ajax/wpAjaxInlineSave.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadmininlineeditpostjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/inline-edit-post.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/inline-edit-post.js 2023-06-25 10:48:28 UTC (rev 56021)
+++ trunk/src/js/_enqueues/admin/inline-edit-post.js 2023-06-25 15:18:12 UTC (rev 56022)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -449,6 +449,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> fields = $('#edit-'+id).find(':input').serialize();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ var status = $(':input[name="_status"]').val();
+
+ if ( [ 'draft', 'pending', 'auto-draft' ].includes( status ) ) {
+ params.edit_date = 'false';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> params = fields + '&' + $.param(params);
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Make Ajax request.
</span></span></pre></div>
<a id="trunksrcwpadminincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/post.php 2023-06-25 10:48:28 UTC (rev 56021)
+++ trunk/src/wp-admin/includes/post.php 2023-06-25 15:18:12 UTC (rev 56022)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -169,6 +169,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( isset( $post_data['edit_date'] ) && 'false' === $post_data['edit_date'] ) {
+ $post_data['edit_date'] = false;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $post_data['edit_date'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $aa = $post_data['aa'];
</span><span class="cx" style="display: block; padding: 0 10px"> $mm = $post_data['mm'];
</span></span></pre></div>
<a id="trunktestsphpunittestsajaxwpAjaxInlineSavephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/ajax/wpAjaxInlineSave.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/ajax/wpAjaxInlineSave.php 2023-06-25 10:48:28 UTC (rev 56021)
+++ trunk/tests/phpunit/tests/ajax/wpAjaxInlineSave.php 2023-06-25 15:18:12 UTC (rev 56022)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -87,4 +87,59 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $post_terms_2 = wp_get_object_terms( $post->ID, 'wptests_tax_2' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSameSets( array( $t2 ), wp_list_pluck( $post_terms_2, 'term_id' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * When updating a draft in quick edit mode, it should not set the publish date of the post when this one will be published.
+ *
+ * @ticket 19907
+ *
+ * @covers ::edit_post
+ */
+ public function test_quick_edit_draft_should_not_set_publish_date() {
+ // Become an administrator.
+ $this->_setRole( 'administrator' );
+
+ $user = get_current_user_id();
+
+ $post = self::factory()->post->create_and_get(
+ array(
+ 'post_status' => 'draft',
+ 'post_author' => $user,
+ )
+ );
+
+ $this->assertSame( 'draft', $post->post_status );
+
+ $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+ // Set up a request.
+ $_POST['_inline_edit'] = wp_create_nonce( 'inlineeditnonce' );
+ $_POST['post_ID'] = $post->ID;
+ $_POST['post_type'] = 'post';
+ $_POST['content'] = 'content test';
+ $_POST['excerpt'] = 'excerpt test';
+ $_POST['_status'] = $post->post_status;
+ $_POST['post_status'] = $post->post_status;
+ $_POST['post_author'] = $user;
+ $_POST['screen'] = 'edit-post';
+ $_POST['post_view'] = 'list';
+ $_POST['edit_date'] = 'false';
+ $_POST['mm'] = '09';
+ $_POST['jj'] = 11;
+ $_POST['aa'] = 2020;
+ $_POST['hh'] = 19;
+ $_POST['mn'] = 20;
+ $_POST['ss'] = 11;
+
+ // Make the request.
+ try {
+ $this->_handleAjax( 'inline-save' );
+ } catch ( WPAjaxDieContinueException $e ) {
+ unset( $e );
+ }
+
+ $post = get_post( $post->ID );
+
+ $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>