<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55590] trunk/tests/phpunit/tests/post: Tests: Move `wp_dropdown_pages()` tests to their own file.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/55590">55590</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/55590","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-03-24 16:12:35 +0000 (Fri, 24 Mar 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Move `wp_dropdown_pages()` tests to their own file.
This aims to make the tests more discoverable and easier to expand.
Includes removing a basic test hidden among `get_pages()` tests, as there is already a more comprehensive set of tests available.
Follow-up to [1279/tests], <a href="https://core.trac.wordpress.org/changeset/28399">[28399]</a>, <a href="https://core.trac.wordpress.org/changeset/31338">[31338]</a>.
See <a href="https://core.trac.wordpress.org/ticket/57841">#57841</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostgetPagesphp">trunk/tests/phpunit/tests/post/getPages.php</a></li>
<li><a href="#trunktestsphpunittestsposttemplatephp">trunk/tests/phpunit/tests/post/template.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostwpDropdownPagesphp">trunk/tests/phpunit/tests/post/wpDropdownPages.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestspostgetPagesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/post/getPages.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/getPages.php 2023-03-24 15:05:29 UTC (rev 55589)
+++ trunk/tests/phpunit/tests/post/getPages.php 2023-03-24 16:12:35 UTC (rev 55590)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -487,17 +487,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @ticket 22389
- */
- public function test_wp_dropdown_pages() {
- self::factory()->post->create_many( 5, array( 'post_type' => 'page' ) );
-
- preg_match_all( '#<option#', wp_dropdown_pages( 'echo=0' ), $matches );
-
- $this->assertCount( 5, $matches[0] );
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * @ticket 22208
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_children_fields_ids() {
</span></span></pre></div>
<a id="trunktestsphpunittestsposttemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/post/template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/template.php 2023-03-24 15:05:29 UTC (rev 55589)
+++ trunk/tests/phpunit/tests/post/template.php 2023-03-24 16:12:35 UTC (rev 55590)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -131,219 +131,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $pagelink, $output );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_wp_dropdown_pages() {
- $none = wp_dropdown_pages( array( 'echo' => 0 ) );
- $this->assertEmpty( $none );
-
- $bump = ' ';
- $page_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
- $child_id = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_parent' => $page_id,
- )
- );
- $grandchild_id = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_parent' => $child_id,
- )
- );
-
- $title1 = get_post( $page_id )->post_title;
- $title2 = get_post( $child_id )->post_title;
- $title3 = get_post( $grandchild_id )->post_title;
-
- $lineage = <<<LINEAGE
-<select name='page_id' id='page_id'>
- <option class="level-0" value="$page_id">$title1</option>
- <option class="level-1" value="$child_id">{$bump}$title2</option>
- <option class="level-2" value="$grandchild_id">{$bump}{$bump}$title3</option>
-</select>
-
-LINEAGE;
-
- $output = wp_dropdown_pages( array( 'echo' => 0 ) );
- $this->assertSameIgnoreEOL( $lineage, $output );
-
- $depth = <<<DEPTH
-<select name='page_id' id='page_id'>
- <option class="level-0" value="$page_id">$title1</option>
-</select>
-
-DEPTH;
-
- $output = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'depth' => 1,
- )
- );
- $this->assertSameIgnoreEOL( $depth, $output );
-
- $option_none = <<<NONE
-<select name='page_id' id='page_id'>
- <option value="Woo">Hoo</option>
- <option class="level-0" value="$page_id">$title1</option>
-</select>
-
-NONE;
-
- $output = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'depth' => 1,
- 'show_option_none' => 'Hoo',
- 'option_none_value' => 'Woo',
- )
- );
- $this->assertSameIgnoreEOL( $option_none, $output );
-
- $option_no_change = <<<NO
-<select name='page_id' id='page_id'>
- <option value="-1">Burrito</option>
- <option value="Woo">Hoo</option>
- <option class="level-0" value="$page_id">$title1</option>
-</select>
-
-NO;
-
- $output = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'depth' => 1,
- 'show_option_none' => 'Hoo',
- 'option_none_value' => 'Woo',
- 'show_option_no_change' => 'Burrito',
- )
- );
- $this->assertSameIgnoreEOL( $option_no_change, $output );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @ticket 12494
- */
- public function test_wp_dropdown_pages_value_field_should_default_to_ID() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- )
- );
-
- // Should contain page ID by default.
- $this->assertStringContainsString( 'value="' . $p . '"', $found );
- }
-
- /**
- * @ticket 12494
- */
- public function test_wp_dropdown_pages_value_field_ID() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'value_field' => 'ID',
- )
- );
-
- $this->assertStringContainsString( 'value="' . $p . '"', $found );
- }
-
- /**
- * @ticket 12494
- */
- public function test_wp_dropdown_pages_value_field_post_name() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_name' => 'foo',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'value_field' => 'post_name',
- )
- );
-
- $this->assertStringContainsString( 'value="foo"', $found );
- }
-
- /**
- * @ticket 12494
- */
- public function test_wp_dropdown_pages_value_field_should_fall_back_on_ID_when_an_invalid_value_is_provided() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_name' => 'foo',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'value_field' => 'foo',
- )
- );
-
- $this->assertStringContainsString( 'value="' . $p . '"', $found );
- }
-
- /**
- * @ticket 30082
- */
- public function test_wp_dropdown_pages_should_not_contain_class_attribute_when_no_class_is_passed() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_name' => 'foo',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- )
- );
-
- $this->assertDoesNotMatchRegularExpression( '/<select[^>]+class=\'/', $found );
- }
-
- /**
- * @ticket 30082
- */
- public function test_wp_dropdown_pages_should_obey_class_parameter() {
- $p = self::factory()->post->create(
- array(
- 'post_type' => 'page',
- 'post_name' => 'foo',
- )
- );
-
- $found = wp_dropdown_pages(
- array(
- 'echo' => 0,
- 'class' => 'bar',
- )
- );
-
- $this->assertMatchesRegularExpression( '/<select[^>]+class=\'bar\'/', $found );
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * @ticket 31389
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_page_template_slug_by_id() {
</span></span></pre></div>
<a id="trunktestsphpunittestspostwpDropdownPagesphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/post/wpDropdownPages.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/wpDropdownPages.php (rev 0)
+++ trunk/tests/phpunit/tests/post/wpDropdownPages.php 2023-03-24 16:12:35 UTC (rev 55590)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,222 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group post
+ * @group template
+ *
+ * @covers ::wp_dropdown_pages
+ */
+class Tests_Post_wpDropdownPages extends WP_UnitTestCase {
+
+ public function test_wp_dropdown_pages() {
+ $none = wp_dropdown_pages( array( 'echo' => 0 ) );
+ $this->assertEmpty( $none );
+
+ $bump = ' ';
+ $page_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
+ $child_id = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_parent' => $page_id,
+ )
+ );
+ $grandchild_id = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_parent' => $child_id,
+ )
+ );
+
+ $title1 = get_post( $page_id )->post_title;
+ $title2 = get_post( $child_id )->post_title;
+ $title3 = get_post( $grandchild_id )->post_title;
+
+ $lineage = <<<LINEAGE
+<select name='page_id' id='page_id'>
+ <option class="level-0" value="$page_id">$title1</option>
+ <option class="level-1" value="$child_id">{$bump}$title2</option>
+ <option class="level-2" value="$grandchild_id">{$bump}{$bump}$title3</option>
+</select>
+
+LINEAGE;
+
+ $output = wp_dropdown_pages( array( 'echo' => 0 ) );
+ $this->assertSameIgnoreEOL( $lineage, $output );
+
+ $depth = <<<DEPTH
+<select name='page_id' id='page_id'>
+ <option class="level-0" value="$page_id">$title1</option>
+</select>
+
+DEPTH;
+
+ $output = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'depth' => 1,
+ )
+ );
+ $this->assertSameIgnoreEOL( $depth, $output );
+
+ $option_none = <<<NONE
+<select name='page_id' id='page_id'>
+ <option value="Woo">Hoo</option>
+ <option class="level-0" value="$page_id">$title1</option>
+</select>
+
+NONE;
+
+ $output = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'depth' => 1,
+ 'show_option_none' => 'Hoo',
+ 'option_none_value' => 'Woo',
+ )
+ );
+ $this->assertSameIgnoreEOL( $option_none, $output );
+
+ $option_no_change = <<<NO
+<select name='page_id' id='page_id'>
+ <option value="-1">Burrito</option>
+ <option value="Woo">Hoo</option>
+ <option class="level-0" value="$page_id">$title1</option>
+</select>
+
+NO;
+
+ $output = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'depth' => 1,
+ 'show_option_none' => 'Hoo',
+ 'option_none_value' => 'Woo',
+ 'show_option_no_change' => 'Burrito',
+ )
+ );
+ $this->assertSameIgnoreEOL( $option_no_change, $output );
+ }
+
+ /**
+ * @ticket 12494
+ */
+ public function test_wp_dropdown_pages_value_field_should_default_to_ID() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ )
+ );
+
+ // Should contain page ID by default.
+ $this->assertStringContainsString( 'value="' . $p . '"', $found );
+ }
+
+ /**
+ * @ticket 12494
+ */
+ public function test_wp_dropdown_pages_value_field_ID() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'value_field' => 'ID',
+ )
+ );
+
+ $this->assertStringContainsString( 'value="' . $p . '"', $found );
+ }
+
+ /**
+ * @ticket 12494
+ */
+ public function test_wp_dropdown_pages_value_field_post_name() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_name' => 'foo',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'value_field' => 'post_name',
+ )
+ );
+
+ $this->assertStringContainsString( 'value="foo"', $found );
+ }
+
+ /**
+ * @ticket 12494
+ */
+ public function test_wp_dropdown_pages_value_field_should_fall_back_on_ID_when_an_invalid_value_is_provided() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_name' => 'foo',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'value_field' => 'foo',
+ )
+ );
+
+ $this->assertStringContainsString( 'value="' . $p . '"', $found );
+ }
+
+ /**
+ * @ticket 30082
+ */
+ public function test_wp_dropdown_pages_should_not_contain_class_attribute_when_no_class_is_passed() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_name' => 'foo',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ )
+ );
+
+ $this->assertDoesNotMatchRegularExpression( '/<select[^>]+class=\'/', $found );
+ }
+
+ /**
+ * @ticket 30082
+ */
+ public function test_wp_dropdown_pages_should_obey_class_parameter() {
+ $p = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_name' => 'foo',
+ )
+ );
+
+ $found = wp_dropdown_pages(
+ array(
+ 'echo' => 0,
+ 'class' => 'bar',
+ )
+ );
+
+ $this->assertMatchesRegularExpression( '/<select[^>]+class=\'bar\'/', $found );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/tests/post/wpDropdownPages.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>