<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55313] trunk/tests/phpunit/tests: Tests: Move PasswordHash test file to a more appropriate place.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/55313">55313</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/55313","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-02-13 14:20:30 +0000 (Mon, 13 Feb 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Move PasswordHash test file to a more appropriate place.
While also used for post passwords and application passwords, the PasswordHash library appears to be initially introduced and primarily used for user passwords, so the test file can be moved to the `user` directory.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/6350">[6350]</a>, <a href="https://core.trac.wordpress.org/changeset/55310">[55310]</a>.
See <a href="https://core.trac.wordpress.org/ticket/56340">#56340</a>.</pre>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsuserpasswordHashphp">trunk/tests/phpunit/tests/user/passwordHash.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspasswordHashphp">trunk/tests/phpunit/tests/passwordHash.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestspasswordHashphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/tests/phpunit/tests/passwordHash.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/passwordHash.php 2023-02-13 09:21:59 UTC (rev 55312)
+++ trunk/tests/phpunit/tests/passwordHash.php 2023-02-13 14:20:30 UTC (rev 55313)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,35 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-
-/**
- * Tests for the PasswordHash external library.
- *
- * @covers PasswordHash
- */
-class Tests_PasswordHash extends WP_UnitTestCase {
-
- public static function set_up_before_class() {
- parent::set_up_before_class();
-
- require_once ABSPATH . WPINC . '/class-phpass.php';
- }
-
- /**
- * Tests that PasswordHash::gensalt_blowfish() does not throw a deprecation
- * notice on PHP 8.1 for "Implicit conversion from float to int loses precision".
- *
- * Should this test fail, it will produce an error "E" in the results.
- *
- * @ticket 56340
- *
- * @covers PasswordHash::gensalt_blowfish
- *
- * @requires PHP 8.1
- */
- public function test_gensalt_blowfish_should_not_throw_deprecation_notice_in_php81() {
- $this->expectNotToPerformAssertions();
-
- $hasher = new PasswordHash( 8, true );
- $hasher->gensalt_blowfish( 'a password string' );
- }
-
-}
</del></span></pre></div>
<a id="trunktestsphpunittestsuserpasswordHashphpfromrev55312trunktestsphpunittestspasswordHashphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: trunk/tests/phpunit/tests/user/passwordHash.php (from rev 55312, trunk/tests/phpunit/tests/passwordHash.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/passwordHash.php (rev 0)
+++ trunk/tests/phpunit/tests/user/passwordHash.php 2023-02-13 14:20:30 UTC (rev 55313)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,34 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * Tests for the PasswordHash external library.
+ *
+ * @covers PasswordHash
+ */
+class Tests_User_PasswordHash extends WP_UnitTestCase {
+
+ public static function set_up_before_class() {
+ parent::set_up_before_class();
+
+ require_once ABSPATH . WPINC . '/class-phpass.php';
+ }
+
+ /**
+ * Tests that PasswordHash::gensalt_blowfish() does not throw a deprecation notice on PHP 8.1.
+ *
+ * The notice that we should not see:
+ * `Deprecated: Implicit conversion from float to int loses precision`.
+ *
+ * @ticket 56340
+ *
+ * @covers PasswordHash::gensalt_blowfish
+ *
+ * @requires PHP 8.1
+ * @doesNotPerformAssertions
+ */
+ public function test_gensalt_blowfish_should_not_throw_deprecation_notice_on_php81() {
+ $hasher = new PasswordHash( 8, true );
+ $hasher->gensalt_blowfish( 'a password string' );
+ }
+
+}
</ins></span></pre>
</div>
</div>
</body>
</html>