<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55324] trunk: Comments: Use correct `orderby` parameter name in personal data exporter and eraser.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/55324">55324</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/55324","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-02-13 22:03:30 +0000 (Mon, 13 Feb 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Comments: Use correct `orderby` parameter name in personal data exporter and eraser.
This ensures that `get_comments()` is called with the correct parameter name in:
* `wp_comments_personal_data_exporter()`
* `wp_comments_personal_data_eraser()`
Follow-up to <a href="https://core.trac.wordpress.org/changeset/42888">[42888]</a>, <a href="https://core.trac.wordpress.org/changeset/42994">[42994]</a>.
Props smeunus, kapilpaul, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/57700">#57700</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
<li><a href="#trunktestsphpunittestscommentwpCommentsPersonalDataEraserphp">trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataEraser.php</a></li>
<li><a href="#trunktestsphpunittestscommentwpCommentsPersonalDataExporterphp">trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataExporter.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment.php 2023-02-13 20:48:53 UTC (rev 55323)
+++ trunk/src/wp-includes/comment.php 2023-02-13 22:03:30 UTC (rev 55324)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3692,7 +3692,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'author_email' => $email_address,
</span><span class="cx" style="display: block; padding: 0 10px"> 'number' => $number,
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => $page,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'order_by' => 'comment_ID',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'orderby' => 'comment_ID',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'order' => 'ASC',
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_comment_meta_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3815,7 +3815,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'author_email' => $email_address,
</span><span class="cx" style="display: block; padding: 0 10px"> 'number' => $number,
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => $page,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'order_by' => 'comment_ID',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'orderby' => 'comment_ID',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'order' => 'ASC',
</span><span class="cx" style="display: block; padding: 0 10px"> 'include_unapproved' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span></span></pre></div>
<a id="trunktestsphpunittestscommentwpCommentsPersonalDataEraserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataEraser.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataEraser.php 2023-02-13 20:48:53 UTC (rev 55323)
+++ trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataEraser.php 2023-02-13 22:03:30 UTC (rev 55324)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -229,4 +229,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function wp_anonymize_comment_custom_message( $anonymize, $comment, $anonymized_comment ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return sprintf( 'Some custom message for comment %d.', $comment->comment_ID );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Testing that `wp_comments_personal_data_eraser()` orders comments by ID.
+ *
+ * @ticket 57700
+ */
+ public function test_wp_comments_personal_data_eraser_orders_comments_by_id() {
+
+ $args = array(
+ 'comment_post_ID' => self::$post_id,
+ 'comment_author' => 'Comment Author',
+ 'comment_author_email' => 'personal@local.host',
+ 'comment_author_url' => 'https://local.host/',
+ 'comment_author_IP' => '192.168.0.1',
+ 'comment_date' => '2018-04-14 17:20:00',
+ 'comment_agent' => 'COMMENT_AGENT',
+ 'comment_content' => 'Comment Content',
+ );
+ self::factory()->comment->create( $args );
+
+ $filter = new MockAction();
+ add_filter( 'comments_clauses', array( &$filter, 'filter' ) );
+
+ wp_comments_personal_data_eraser( $args['comment_author_email'] );
+
+ $clauses = $filter->get_args()[0][0];
+
+ $this->assertStringContainsString( 'comment_ID', $clauses['orderby'] );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestscommentwpCommentsPersonalDataExporterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataExporter.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataExporter.php 2023-02-13 20:48:53 UTC (rev 55323)
+++ trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataExporter.php 2023-02-13 22:03:30 UTC (rev 55324)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -132,4 +132,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Number of exported comments.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertCount( 0, $actual['data'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Testing that `wp_comments_personal_data_exporter()` orders comments by ID.
+ *
+ * @ticket 57700
+ */
+ public function test_wp_comments_personal_data_exporter_orders_comments_by_id() {
+
+ $args = array(
+ 'comment_post_ID' => self::$post_id,
+ 'comment_author' => 'Comment Author',
+ 'comment_author_email' => 'personal@local.host',
+ 'comment_author_url' => 'https://local.host/',
+ 'comment_author_IP' => '192.168.0.1',
+ 'comment_date' => '2018-03-28 20:05:00',
+ 'comment_agent' => 'SOME_AGENT',
+ 'comment_content' => 'Comment',
+ );
+ self::factory()->comment->create( $args );
+
+ $filter = new MockAction();
+ add_filter( 'comments_clauses', array( &$filter, 'filter' ) );
+
+ wp_comments_personal_data_exporter( $args['comment_author_email'] );
+
+ $clauses = $filter->get_args()[0][0];
+
+ $this->assertStringContainsString( 'comment_ID', $clauses['orderby'] );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>