<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[55093] trunk: Media: Allow for customization of lazy-loading featured images.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/55093">55093</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/55093","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>flixos90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-01-19 07:32:28 +0000 (Thu, 19 Jan 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Allow for customization of lazy-loading featured images.
When lazy-loading images was introduced, in <a href="https://core.trac.wordpress.org/changeset/52065">[52065]</a> the check for `wp_lazy_loading_enabled()` was omitted by accident in the logic to set the attribute with its default value on `img` tags from `get_the_post_thumbnail()`. Without this check, it is impossible for third-party developers to modify the behavior for featured images.
This changeset fixes the problem by introducing the check.
Props flixos90, joemcgill, mukesh27.
Fixes <a href="https://core.trac.wordpress.org/ticket/57490">#57490</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludespostthumbnailtemplatephp">trunk/src/wp-includes/post-thumbnail-template.php</a></li>
<li><a href="#trunktestsphpunittestspostthumbnailsphp">trunk/tests/phpunit/tests/post/thumbnails.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludespostthumbnailtemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post-thumbnail-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post-thumbnail-template.php 2023-01-18 21:58:00 UTC (rev 55092)
+++ trunk/src/wp-includes/post-thumbnail-template.php 2023-01-19 07:32:28 UTC (rev 55093)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -186,17 +186,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> update_post_thumbnail_cache();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Get the 'loading' attribute value to use as default, taking precedence over the default from
- // `wp_get_attachment_image()`.
- $loading = wp_get_loading_attr_default( 'the_post_thumbnail' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add `loading` attribute.
+ if ( wp_lazy_loading_enabled( 'img', 'the_post_thumbnail' ) ) {
+ // Get the 'loading' attribute value to use as default, taking precedence over the default from
+ // `wp_get_attachment_image()`.
+ $loading = wp_get_loading_attr_default( 'the_post_thumbnail' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Add the default to the given attributes unless they already include a 'loading' directive.
- if ( empty( $attr ) ) {
- $attr = array( 'loading' => $loading );
- } elseif ( is_array( $attr ) && ! array_key_exists( 'loading', $attr ) ) {
- $attr['loading'] = $loading;
- } elseif ( is_string( $attr ) && ! preg_match( '/(^|&)loading=/', $attr ) ) {
- $attr .= '&loading=' . $loading;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add the default to the given attributes unless they already include a 'loading' directive.
+ if ( empty( $attr ) ) {
+ $attr = array( 'loading' => $loading );
+ } elseif ( is_array( $attr ) && ! array_key_exists( 'loading', $attr ) ) {
+ $attr['loading'] = $loading;
+ } elseif ( is_string( $attr ) && ! preg_match( '/(^|&)loading=/', $attr ) ) {
+ $attr .= '&loading=' . $loading;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $html = wp_get_attachment_image( $post_thumbnail_id, $size, false, $attr );
</span></span></pre></div>
<a id="trunktestsphpunittestspostthumbnailsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/post/thumbnails.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/thumbnails.php 2023-01-18 21:58:00 UTC (rev 55092)
+++ trunk/tests/phpunit/tests/post/thumbnails.php 2023-01-19 07:32:28 UTC (rev 55093)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -408,6 +408,41 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, $result );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 57490
+ */
+ public function test_get_the_post_thumbnail_includes_loading_lazy() {
+ set_post_thumbnail( self::$post, self::$attachment_id );
+
+ $html = get_the_post_thumbnail( self::$post );
+ $this->assertStringContainsString( ' loading="lazy"', $html );
+ }
+
+ /**
+ * @ticket 57490
+ */
+ public function test_get_the_post_thumbnail_respects_passed_loading_attr() {
+ set_post_thumbnail( self::$post, self::$attachment_id );
+
+ $html = get_the_post_thumbnail( self::$post, 'post-thumbnail', array( 'loading' => 'eager' ) );
+ $this->assertStringContainsString( ' loading="eager"', $html, 'loading=eager was not present in img tag because attributes array with loading=eager was overwritten.' );
+
+ $html = get_the_post_thumbnail( self::$post, 'post-thumbnail', 'loading=eager' );
+ $this->assertStringContainsString( ' loading="eager"', $html, 'loading=eager was not present in img tag because attributes string with loading=eager was overwritten.' );
+ }
+
+ /**
+ * @ticket 57490
+ */
+ public function test_get_the_post_thumbnail_respects_wp_lazy_loading_enabled_filter() {
+ set_post_thumbnail( self::$post, self::$attachment_id );
+
+ add_filter( 'wp_lazy_loading_enabled', '__return_false' );
+
+ $html = get_the_post_thumbnail( self::$post );
+ $this->assertStringNotContainsString( ' loading="lazy"', $html );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function data_post_thumbnail_size_filter_complex() {
</span><span class="cx" style="display: block; padding: 0 10px"> return array(
</span><span class="cx" style="display: block; padding: 0 10px"> array( 0, 'medium' ),
</span></span></pre>
</div>
</div>
</body>
</html>