<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54863] trunk/tests/phpunit/tests/media: Tests: Add unit tests for attachment's file size being included in metadata.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54863">54863</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54863","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-11-22 19:43:25 +0000 (Tue, 22 Nov 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Add unit tests for attachment's file size being included in metadata.
These tests ensure that `wp_generate_attachment_metadata()` stores the file size of all newly uploaded attachments under the `filesize` array key. The tests were initially supposed to be committed with <a href="https://core.trac.wordpress.org/changeset/52837">[52837]</a>.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/52837">[52837]</a>, <a href="https://core.trac.wordpress.org/changeset/52932">[52932]</a>, <a href="https://core.trac.wordpress.org/changeset/54861">[54861]</a>.
Props spacedmonkey, johnwatkins0, mitogh, adamsilverstein, pbearne, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/57171">#57171</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsmediawpImageTagAddDecodingAttrphp">trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsmediawpGenerateAttachmentMetadataphp">trunk/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsmediawpGenerateAttachmentMetadataphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php (rev 0)
+++ trunk/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php 2022-11-22 19:43:25 UTC (rev 54863)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,89 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * Tests for the `wp_generate_attachment_metadata()` function.
+ *
+ * @group media
+ * @covers ::wp_generate_attachment_metadata
+ */
+class Tests_Media_wpGenerateAttachmentMetadata extends WP_UnitTestCase {
+
+ public function tear_down() {
+ $this->remove_added_uploads();
+
+ parent::tear_down();
+ }
+
+ /**
+ * Tests that filesize meta is generated for JPEGs.
+ *
+ * @ticket 49412
+ *
+ * @covers ::wp_create_image_subsizes
+ */
+ public function test_wp_generate_attachment_metadata_includes_filesize_in_jpg_meta() {
+ $attachment = $this->factory->attachment->create_upload_object( DIR_TESTDATA . '/images/canola.jpg' );
+
+ $metadata = wp_get_attachment_metadata( $attachment );
+
+ $this->assertSame( wp_filesize( get_attached_file( $attachment ) ), $metadata['filesize'] );
+
+ foreach ( $metadata['sizes'] as $intermediate_size ) {
+ $this->assertArrayHasKey( 'filesize', $intermediate_size );
+ $this->assertNotEmpty( $intermediate_size['filesize'] );
+ $this->assertIsNumeric( $intermediate_size['filesize'] );
+ }
+ }
+
+ /**
+ * Checks that filesize meta is generated for PNGs.
+ *
+ * @ticket 49412
+ *
+ * @covers ::wp_create_image_subsizes
+ */
+ public function test_wp_generate_attachment_metadata_includes_filesize_in_png_meta() {
+ $attachment = $this->factory->attachment->create_upload_object( DIR_TESTDATA . '/images/test-image.png' );
+
+ $metadata = wp_get_attachment_metadata( $attachment );
+
+ $this->assertSame( wp_filesize( get_attached_file( $attachment ) ), $metadata['filesize'] );
+ }
+
+ /**
+ * Checks that filesize meta is generated for PDFs.
+ *
+ * @ticket 49412
+ */
+ public function test_wp_generate_attachment_metadata_includes_filesize_in_pdf_meta() {
+ $attachment = $this->factory->attachment->create_upload_object( DIR_TESTDATA . '/images/wordpress-gsoc-flyer.pdf' );
+
+ $metadata = wp_get_attachment_metadata( $attachment );
+
+ $this->assertSame( wp_filesize( get_attached_file( $attachment ) ), $metadata['filesize'] );
+ }
+
+ /**
+ * Checks that filesize meta is generated for PSDs.
+ *
+ * @ticket 49412
+ */
+ public function test_wp_generate_attachment_metadata_includes_filesize_in_psd_meta() {
+ if ( is_multisite() ) {
+ // PSD mime type is not allowed by default on multisite.
+ add_filter(
+ 'upload_mimes',
+ static function( $mimes ) {
+ $mimes['psd'] = 'application/octet-stream';
+ return $mimes;
+ }
+ );
+ }
+
+ $attachment = $this->factory->attachment->create_upload_object( DIR_TESTDATA . '/images/test-image.psd' );
+
+ $metadata = wp_get_attachment_metadata( $attachment );
+
+ $this->assertSame( wp_filesize( get_attached_file( $attachment ) ), $metadata['filesize'] );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/tests/media/wpGenerateAttachmentMetadata.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunittestsmediawpImageTagAddDecodingAttrphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php 2022-11-22 15:09:33 UTC (rev 54862)
+++ trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php 2022-11-22 19:43:25 UTC (rev 54863)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,7 +1,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Tests the `wp_img_tag_add_decoding_attr()` function.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests for the `wp_img_tag_add_decoding_attr()` function.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @group media
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::wp_img_tag_add_decoding_attr
</span></span></pre>
</div>
</div>
</body>
</html>